Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PYTHON-1371 Throw a specific error for vector serialization failure cases #1193

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

absurdfarce
Copy link
Collaborator

No description provided.

Copy link

@hemidactylus hemidactylus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caveat: I cannot access the jenkins server where the CI failure is shown.
Looking at the code, howewer, it would LGTM

@SiyaoIsHiding
Copy link
Collaborator

The CI failure is just

*_results.xml — Archive JUnit-formatted test results
[2023-12-14T20:12:35.894Z] Recording test results
[2023-12-14T20:12:36.952Z] [Checks API] No suitable checks publisher found.

Looks good to me.

@absurdfarce
Copy link
Collaborator Author

Test failures are all known issues, calling this good

@absurdfarce absurdfarce merged commit e90c0f5 into master Dec 18, 2023
4 of 5 checks passed
@absurdfarce absurdfarce deleted the python1371 branch December 19, 2023 21:04
fruch added a commit to fruch/python-driver that referenced this pull request Jun 6, 2024
…sync_with_upstream_3.29.1

version 3.29.0

* tag '3.29.0' of https://github.com/datastax/python-driver:
  Documentation (and other) updates for 3.29.0 (datastax#1194)
  PYTHON-1331 ssl.match_hostname() is deprecated in 3.7 (datastax#1191)
  PYTHON-1371 Add explicit exception type for serialization failures (datastax#1193)
  Remove outdated Python pre-3.7 references (datastax#1186)
  PYTHON-1368 Avoid installing DSE deps + executing DSE tests for Python 3.12 (datastax#1188)
  PYTHON-1366 Handle removal of asyncore in Python 3.12 (datastax#1187)
  Removed backup(.bak) files (datastax#1185)
  docs: Fix typo in add_callbacks (datastax#1177)
  Remove some remnants of Python2 (datastax#1172)
  PYTHON-1313 Fix asyncio removals in Python 3.10 (datastax#1179)
  PYTHON-1364 Fix ssl.wrap_socket errors (from eventlet) for Python 3.12 (datastax#1181)
  Add Jenkins support for Python 3.12.0 (datastax#1180)
  Update redirects in docs.yaml (datastax#1178)
  Jenkins using new python versions in the matrix (datastax#1174)
  Update docs.yaml to point to most recent 3.28.0 docs changes
  CONN-38 Notes for 3.28.0 on PYTHON-1350 (datastax#1167)
  Include docs for 3.28.0
  Fixed non-valid rst in README
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants