Collect trace and span id when present #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1.0.0 Release
1.1.0 Release
1.2.0 Release
2.0.0 Release
2.1.0 Release
3.0.0 Release
nblumhardt
commented
Jan 10, 2024
nblumhardt
commented
Jan 10, 2024
| _messageAttribute = new("@m", new FormattedMessageLayout()), | ||
| _messageTemplateAttribute = new("@mt", new SimpleLayout("${onhasproperties:${message:raw=true}}")), | ||
| _traceIdAttribute = new("@tr", new TraceIdLayout()), | ||
| _spanIdAttribute = new("@sp", new SpanIdLayout()); |
There was a problem hiding this comment.
Equivalents of these are available in NLog.DiagnosticSource, but it seems better to avoid the dependency.
3.1.0 Release
Merged
…to collect-trace-id
|
This will need a squash :-) |
liammclennan
reviewed
Apr 3, 2024
|
|
||
| namespace NLog.Targets.Seq.Layouts | ||
| { | ||
| class TraceIdLayout: Layout |
There was a problem hiding this comment.
Seems rather similar to SpanIdLayout
There was a problem hiding this comment.
Yeah, could definitely factor this out; I'll take a quick look tomorrow :)
liammclennan
approved these changes
Apr 3, 2024
nblumhardt
added a commit
that referenced
this pull request
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seq 2023+ includes special handling of trace and span ids. This is a spike showing how the sink could collect them - still needs some tests and cleanup, but otherwise appears to be straightforward.