Add dev environment and update docs #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guzman-raphael
changed the title
dimitri-yatsenko
approved these changes
Feb 19, 2021
Synicix
approved these changes
Feb 19, 2021
| command: pharus | ||
| fakeservices.datajoint.io: | ||
| <<: *net | ||
| image: raphaelguzman/nginx:v0.0.15 |
There was a problem hiding this comment.
Should this be hosted on a datajoint dockerhub verse our own dev username?
There was a problem hiding this comment.
@Synicix Good catch. Unfortunately, this one is tricky to solve properly... It is a repo I created a long while back that I wasn't sure if we would need it but now it has grown to be dependent on various projects. I'd like to move it now but it would have breaking changes for other projects. Let's use it for now and I can mirror it to a datajoint or vathes public repo soon to give some time for us to migrate things over.
There was a problem hiding this comment.
I will file an issue for it then. Just as a concern
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR serves to:
devdocker environment that supports hot/live reloading.basedocker environment to simplify dependencies.Fix #74