Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix different test names with different runs #36

Merged
merged 1 commit into from
Nov 18, 2015

Conversation

redixin
Copy link
Contributor

@redixin redixin commented Nov 18, 2015

Remove hash randomization checking. Simply do not mess with
non-trivial values. Simple enumerated test names are much better
then long ugly names with many underscores.

Close #35

@landscape-bot
Copy link

Code Health
Repository health decreased by 1% when pulling 12bdc27 on redixin:fix_mock_testr into 2aba978 on txels:master.

@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling 9e06d7b on redixin:fix_mock_testr into 2aba978 on txels:master.

@txels
Copy link
Collaborator

txels commented Nov 18, 2015

Sounds sensible. I like it.
Would you mind squashing these into a single commit? It is not a big change, and some of the commits are just small fixes anyway.

@redixin
Copy link
Contributor Author

redixin commented Nov 18, 2015

@txels

Sure. Should I create another pull request?

Remove hash randomization checking. Simply do not mess with
non-trivial values. Simple enumerated test names are much better
then long ugly names with many underscores.
@redixin
Copy link
Contributor Author

redixin commented Nov 18, 2015

@txels oh, just rebase and force-push, ok. Done.

txels added a commit that referenced this pull request Nov 18, 2015
Fix different test names with different runs
@txels txels merged commit 9fcc499 into datadriventests:master Nov 18, 2015
@txels
Copy link
Collaborator

txels commented Nov 18, 2015

Thanks @redixin. Released as 1.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants