Added `token` block to `databricks_mws_workspaces` #969

nfx · 2021-12-15T12:15:07Z

Fixes #957

codecov · 2021-12-15T12:19:00Z

Codecov Report

Merging #969 (20f4be2) into master (8a1921a) will increase coverage by 0.14%.
The diff coverage is 93.10%.

❗ Current head 20f4be2 differs from pull request most recent head f0c7de6. Consider uploading reports for the commit f0c7de6 to get more accurate results

@@            Coverage Diff             @@
##           master     #969      +/-   ##
==========================================
+ Coverage   85.69%   85.84%   +0.14%     
==========================================
  Files         103      102       -1     
  Lines        9131     9210      +79     
==========================================
+ Hits         7825     7906      +81     
+ Misses        794      792       -2     
  Partials      512      512

Impacted Files	Coverage Δ
mws/resource_workspace.go	`87.36% <93.10%> (+8.03%)`	⬆️
sqlanalytics/resource_widget.go	`85.40% <0.00%> (-0.73%)`	⬇️

alexott

lgtm

docs/resources/mws_workspaces.md

nfx added 2 commits December 14, 2021 19:46

Add token {} to workspace resource

77bf159

Added token block to databricks_mws_workspaces

20f4be2

Fixes #957

nfx added this to the v0.4.1 milestone Dec 15, 2021

nfx requested a review from alexott December 15, 2021 12:15

alexott approved these changes Dec 15, 2021

View reviewed changes

docs/resources/mws_workspaces.md Show resolved Hide resolved

Apply review comments

f0c7de6

nfx merged commit ed62099 into master Dec 15, 2021

nfx deleted the mws-spn branch December 15, 2021 16:47

AndreasSko mentioned this pull request Dec 23, 2021

cannot create mws workspaces: cannot create token: cannot configure direct auth: host is empty, but is required by basic_auth. Environment variables used: DATABRICKS_HOST, DATABRICKS_USERNAME, DATABRICKS_PASSWORD #994

Closed

michael-berk pushed a commit to michael-berk/terraform-provider-databricks that referenced this pull request Feb 15, 2023

Added token block to databricks_mws_workspaces (databricks#969)

70eb0e4

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added `token` block to `databricks_mws_workspaces` #969

Added `token` block to `databricks_mws_workspaces` #969

nfx commented Dec 15, 2021

codecov bot commented Dec 15, 2021 •

edited

Loading

alexott left a comment

Added token block to databricks_mws_workspaces #969

Added token block to databricks_mws_workspaces #969

Conversation

nfx commented Dec 15, 2021

codecov bot commented Dec 15, 2021 • edited Loading

Codecov Report

alexott left a comment

Choose a reason for hiding this comment

Added `token` block to `databricks_mws_workspaces` #969

Added `token` block to `databricks_mws_workspaces` #969

codecov bot commented Dec 15, 2021 •

edited

Loading