Remove failed libraries on running clusters #956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whenever a library fails to get installed on a running cluster, we automatically remove it, so that the clean state of managed libraries is properly maintained. Without this fix users had to manually go to Clusters UI and remove library from a cluster, where it failed to install. Libraries add up to CREATE and UPDATE timeouts of `databricks_cluster` resource. Fixes #599
Codecov Report
@@ Coverage Diff @@
## master #956 +/- ##
==========================================
+ Coverage 85.66% 85.69% +0.03%
==========================================
Files 103 103
Lines 9060 9093 +33
==========================================
+ Hits 7761 7792 +31
- Misses 789 790 +1
- Partials 510 511 +1
|
nfx
added
the
suppress diff
alexott
approved these changes
Dec 12, 2021
| Messages []string `json:"messages,omitempty"` | ||
| Library *Library `json:"library,omitempty"` | ||
| Status string `json:"status,omitempty"` | ||
| IsGlobal bool `json:"is_library_for_all_clusters,omitempty"` |
There was a problem hiding this comment.
should we start deprecation of this flag? Because per documentation:
This option does not install the library on clusters running Databricks Runtime 7.0 and above.
There was a problem hiding this comment.
It's not changeable by users anymore 🤷🏻♂️ but there still might be some workspaces with dbr7.0, that have this
michael-berk
pushed a commit
to michael-berk/terraform-provider-databricks
that referenced
this pull request
Feb 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever a library fails to get installed on a running cluster, we automatically remove it, so that the clean state of managed libraries is properly maintained. Without this fix users had to manually go to Clusters UI and remove library from a cluster, where it failed to install. Libraries add up to CREATE and UPDATE timeouts of
databricks_clusterresource.Fixes #599