Add support for PythonWheelTask #872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfx
requested changes
Oct 26, 2021
There was a problem hiding this comment.
please reformat code and also add few lines to documentation in https://github.com/databrickslabs/terraform-provider-databricks/blob/master/docs/resources/job.md, so that users would know of the feature.
you can reuse the HCL example you've been testing with in docs.
compute/model.go
Outdated
| @@ -517,6 +517,14 @@ type SparkSubmitTask struct { | |||
| Parameters []string `json:"parameters,omitempty"` | |||
| } | |||
|
|
|||
| // PythonWheelTask contains the information for python wheel jobs | |||
| type PythonWheelTask struct { | |||
| EntryPoint string `json:"entry_point,omitempty"` | |||
There was a problem hiding this comment.
please run make fmt and commit :)
Codecov Report
@@ Coverage Diff @@
## master #872 +/- ##
=======================================
Coverage 83.80% 83.80%
=======================================
Files 92 92
Lines 8233 8233
=======================================
Hits 6900 6900
Misses 842 842
Partials 491 491
|
Merged
michael-berk
pushed a commit
to michael-berk/terraform-provider-databricks
that referenced
this pull request
Feb 15, 2023
* Add support for PythonWheelTask Co-authored-by: Serge Smertin <259697+nfx@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP - to be tested