Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare release 0.3.6 #726

Merged
merged 10 commits into from
Jul 19, 2021
Merged

Prepare release 0.3.6 #726

merged 10 commits into from
Jul 19, 2021

Conversation

nfx
Copy link
Contributor

@nfx nfx commented Jul 14, 2021 •
edited
Loading

Version changelog

0.3.6

  • Added support for hybrid pools (#689)
  • Added support for always_running jobs, which are restarted on resource updates (#715)
  • Azure CLI auth is now forcing JSON output (#717)
  • databricks_permissions are getting validation on terraform plan stage (#706)
  • Added databricks_directory resource (#690)
  • Added support for hybrid instance pools (#689)
  • Added run_as_role field to databricks_sql_query (#684)
  • Added user_id attribute for databricks_user data resource, so that it's possible to dynamically create resources based on members of the group (#714)
  • Added more selectors to databricks_node_type data source (#723)
  • Azure auth with SPN now uses AAD token by default instead of PAT. Previous behavior (using PAT) could be restored by setting azure_use_pat_for_spn to true (#721)
  • deployment_name for databricks_mws_workspaces is now optional, how it should have been. This enables creation of Databricks workspaces without an account prefix.
  • Various documentation and bugfixes

Updated dependency versions:

  • Bump github.com/aws/aws-sdk-go from 1.38.51 to 1.38.71
  • Bump github.com/Azure/go-autorest/autorest/azure/auth from 0.5.7 to 0.5.8
  • Bump github.com/Azure/go-autorest/autorest from 0.11.18 to 0.11.19
  • Bump github.com/Azure/go-autorest/autorest/adal from 0.9.13 to 0.9.14
  • Bump github.com/zclconf/go-cty from 1.8.3 to 1.8.4
  • Bump github.com/hashicorp/terraform-plugin-sdk/v2 from 2.6.1 to 2.7.0

awsmt

  • TestAccClusterResource_CreateClusterWithLibraries (235.71s)
  • TestAccClusterResource_CreateSingleNodeCluster (64.42s)
  • TestAccGroup (14.77s)
  • TestAccUserResource (7.24s)
  • TestAwsAccServicePrincipalResource (6.90s)
  • access.TestAccIPACL (1.44s)
  • access.TestAccPermissionsClusterPolicy (13.06s)
  • access.TestAccPermissionsClusters (197.83s)
  • access.TestAccPermissionsInstancePool (14.08s)
  • access.TestAccPermissionsJobs (16.38s)
  • access.TestAccPermissionsNotebooks (16.66s)
  • access.TestAccPermissionsTokens (14.25s)
  • access/acceptance.TestAccDatabricksPermissionsResourceFullLifecycle (49.77s)
  • access/acceptance.TestAccInitialManagePrincipals (1.97s)
  • access/acceptance.TestAccInitialManagePrincipalsGroup (2.16s)
  • access/acceptance.TestAccSecretAclResource (16.33s)
  • access/acceptance.TestAccSecretAclResourceDefaultPrincipal (8.55s)
  • access/acceptance.TestAccSecretResource (6.50s)
  • access/acceptance.TestAccSecretScopeResource (8.78s)
  • access/acceptance.TestAccTableACL (904.17s)
  • compute.TestAccContext (110.26s)
  • compute.TestAccInstancePools (4.28s)
  • compute.TestAccLibraryCreate (142.89s)
  • compute.TestAccListClustersIntegration (209.27s)
  • compute.TestAwsAccSmallestNodeType (0.21s)
  • compute/acceptance.TestAccClusterPolicyResourceFullLifecycle (12.67s)
  • compute/acceptance.TestAccJobResource (3.33s)
  • compute/acceptance.TestAwsAccJobResource_NoInstancePool (3.41s)
  • compute/acceptance.TestAwsAccJobsCreate (2.46s)
  • identity/acceptance.TestAccComplexValueResource (25.24s)
  • identity/acceptance.TestAccGroupResource (22.36s)
  • identity/acceptance.TestAccGroupResource_verify_entitlements (13.71s)
  • identity/acceptance.TestAccTokenResource (4.00s)
  • identity/acceptance.TestAwsAccGroupInstanceProfileResource (329.34s)
  • internal/sanity.TestAccMissingResourcesInWorkspace (5.32s)
  • internal/sanity.TestAccMissingResourcesInWorkspace/Cluster_Policies (0.30s)
  • internal/sanity.TestAccMissingResourcesInWorkspace/Cluster_Policies_Delete (0.49s)
  • internal/sanity.TestAccMissingResourcesInWorkspace/Clusters (0.39s)
  • internal/sanity.TestAccMissingResourcesInWorkspace/DBFS_Files (0.94s)
  • internal/sanity.TestAccMissingResourcesInWorkspace/Groups (0.52s)
  • internal/sanity.TestAccMissingResourcesInWorkspace/Instance_Pools (0.15s)
  • internal/sanity.TestAccMissingResourcesInWorkspace/Instance_Profiles (0.40s)
  • internal/sanity.TestAccMissingResourcesInWorkspace/Jobs (0.15s)
  • internal/sanity.TestAccMissingResourcesInWorkspace/Notebooks (0.31s)
  • internal/sanity.TestAccMissingResourcesInWorkspace/Secret_ACLs (0.21s)
  • internal/sanity.TestAccMissingResourcesInWorkspace/Secret_Scopes (0.20s)
  • internal/sanity.TestAccMissingResourcesInWorkspace/Secrets (0.07s)
  • internal/sanity.TestAccMissingResourcesInWorkspace/Tokens (1.18s)
  • internal/sanity.TestAccMutiworkspaceUsedFromNormalMode (2.85s)
  • storage.TestAccCreateFile (4.74s)
  • storage.TestAccDeleteInvalidMountFails (4.00s)
  • storage.TestAccInvalidSecretScopeFails (3.73s)
  • storage.TestAccSourceOnInvalidMountFails (31.54s)
  • storage.TestAwsAccS3Mount (339.95s)
  • storage/acceptance.TestAccDatabricksDBFSFile_CreateViaContent (5.24s)
  • storage/acceptance.TestAccDatabricksDBFSFile_CreateViaSource (2.84s)
  • storage/acceptance.TestAwsAccS3IamMount_NoClusterGiven (578.04s)
  • workspace/acceptance.TestAccGlobalInitScriptResource_Create (5.07s)
  • workspace/acceptance.TestAccNotebookResourceScalability (6.27s)
  • workspace/acceptance.TestAccWorkspaceConfFullLifecycle (3.64s)

azsp

  • TestAccGroupResource (18.99s)
  • TestAccTableACL (690.91s)
  • TestAzureAccADLSv2Mount (41.74s)
  • TestAzureAccAdlsGen2Mount_correctly_mounts (15.64s)
  • access.TestAccIPACL (2.86s)
  • access.TestAccPermissionsClusterPolicy (12.25s)
  • access.TestAccPermissionsClusters (230.34s)
  • access.TestAccPermissionsInstancePool (11.96s)
  • access.TestAccPermissionsJobs (13.26s)
  • access.TestAccPermissionsNotebooks (14.19s)
  • access.TestAccPermissionsTokens (10.95s)
  • access/acceptance.TestAccDatabricksPermissionsResourceFullLifecycle (46.37s)
  • access/acceptance.TestAccInitialManagePrincipals (2.05s)
  • access/acceptance.TestAccInitialManagePrincipalsGroup (1.24s)
  • access/acceptance.TestAccSecretAclResource (10.87s)
  • access/acceptance.TestAccSecretAclResourceDefaultPrincipal (7.73s)
  • access/acceptance.TestAccSecretResource (9.26s)
  • access/acceptance.TestAccSecretScopeResource (9.17s)
  • compute.TestAccContext (34.05s)
  • compute.TestAccInstancePools (2.71s)
  • compute.TestAccLibraryCreate (58.08s)
  • compute.TestAccListClustersIntegration (225.99s)
  • compute.TestAzureAccNodeTypes (0.52s)
  • compute/acceptance.TestAccClusterPolicyResourceFullLifecycle (13.07s)
  • compute/acceptance.TestAccJobResource (5.76s)
  • identity.TestAccCreateToken (1.17s)
  • identity.TestAccCreateToken_NoExpiration (1.17s)
  • identity.TestAccCreateUser (7.43s)
  • identity.TestAccFilterGroup (1.61s)
  • identity.TestAccGroup (17.35s)
  • identity.TestAccReadUser (1.43s)
  • identity.TestAzureAccSP (5.44s)
  • identity/acceptance.TestAccComplexValueResource (19.08s)
  • identity/acceptance.TestAccGroupResource_verify_entitlements (11.64s)
  • identity/acceptance.TestAccTokenResource (7.60s)
  • identity/acceptance.TestAccUserResource (9.76s)
  • identity/acceptance.TestAzureAccServicePrincipalResource (6.67s)
  • internal/sanity.TestAccMissingResourcesInWorkspace (4.94s)
  • internal/sanity.TestAccMissingResourcesInWorkspace/Cluster_Policies (0.43s)
  • internal/sanity.TestAccMissingResourcesInWorkspace/Cluster_Policies_Delete (0.46s)
  • internal/sanity.TestAccMissingResourcesInWorkspace/Clusters (0.29s)
  • internal/sanity.TestAccMissingResourcesInWorkspace/DBFS_Files (0.70s)
  • internal/sanity.TestAccMissingResourcesInWorkspace/Groups (0.38s)
  • internal/sanity.TestAccMissingResourcesInWorkspace/Instance_Pools (0.21s)
  • internal/sanity.TestAccMissingResourcesInWorkspace/Jobs (0.21s)
  • internal/sanity.TestAccMissingResourcesInWorkspace/Notebooks (0.27s)
  • internal/sanity.TestAccMissingResourcesInWorkspace/Secret_ACLs (0.68s)
  • internal/sanity.TestAccMissingResourcesInWorkspace/Secret_Scopes (0.81s)
  • internal/sanity.TestAccMissingResourcesInWorkspace/Secrets (0.14s)
  • internal/sanity.TestAccMissingResourcesInWorkspace/Tokens (0.37s)
  • internal/sanity.TestAccMutiworkspaceUsedFromNormalMode (6.96s)
  • storage.TestAccCreateFile (6.24s)
  • storage.TestAccDeleteInvalidMountFails (5.76s)
  • storage.TestAccInvalidSecretScopeFails (4.87s)
  • storage.TestAccSourceOnInvalidMountFails (27.48s)
  • storage.TestAzureAccADLSv1Mount (358.65s)
  • storage.TestAzureAccBlobMount (121.12s)
  • storage/acceptance.TestAccDatabricksDBFSFile_CreateViaContent (8.13s)
  • storage/acceptance.TestAccDatabricksDBFSFile_CreateViaSource (3.98s)
  • storage/acceptance.TestAzureAccAdlsGen1Mount_correctly_mounts (358.36s)
  • storage/acceptance.TestAzureAccBlobMount_correctly_mounts (379.24s)
  • workspace/acceptance.TestAccGlobalInitScriptResource_Create (6.19s)
  • workspace/acceptance.TestAccNotebookResourceScalability (10.27s)
  • workspace/acceptance.TestAccWorkspaceConfFullLifecycle (5.19s)

mws

  • mws.TestMwsAccCreds (2.38s)
  • mws.TestMwsAccCustomerManagedKeys (3.09s)
  • mws.TestMwsAccLogDelivery (6.19s)
  • mws.TestMwsAccMissingResources (3.39s)
  • mws.TestMwsAccMissingResources/Credential (1.14s)
  • mws.TestMwsAccMissingResources/Customer_Managed_Key (0.54s)
  • mws.TestMwsAccMissingResources/Network (0.53s)
  • mws.TestMwsAccMissingResources/Storage (0.60s)
  • mws.TestMwsAccMissingResources/Workspace (0.59s)
  • mws.TestMwsAccPAS (2.24s)
  • mws.TestMwsAccStorageConfigurations (1.97s)
  • mws.TestMwsAccVPCEndpointIntegration (118.36s)
  • mws.TestMwsAccWorkspace (0.53s)
  • mws/acceptance.TestMwsAccCredentials (4.82s)
  • mws/acceptance.TestMwsAccCustomerManagedKeys (10.44s)
  • mws/acceptance.TestMwsAccLogDelivery (10.35s)
  • mws/acceptance.TestMwsAccNetworks (4.65s)
  • mws/acceptance.TestMwsAccPrivateAccessSettings (4.80s)
  • mws/acceptance.TestMwsAccStorageConfigurations (4.63s)
  • mws/acceptance.TestMwsAccVpcEndpoint (105.50s)
  • mws/acceptance.TestMwsAccWorkspaces (133.30s)

preview

azcli

  • TestAccTableACL (509.09s)
  • access.TestAccIPACL (19.32s)
  • access.TestAccPermissionsClusterPolicy (14.25s)
  • access.TestAccPermissionsClusters (384.10s)
  • access.TestAccPermissionsInstancePool (16.71s)
  • access.TestAccPermissionsJobs (14.48s)
  • access.TestAccPermissionsNotebooks (14.91s)
  • access.TestAccPermissionsTokens (12.38s)
  • access/acceptance.TestAccDatabricksPermissionsResourceFullLifecycle (80.44s)
  • access/acceptance.TestAccInitialManagePrincipals (3.51s)
  • access/acceptance.TestAccInitialManagePrincipalsGroup (2.33s)
  • access/acceptance.TestAccSecretAclResource (18.62s)
  • access/acceptance.TestAccSecretAclResourceDefaultPrincipal (14.19s)
  • access/acceptance.TestAccSecretResource (16.97s)
  • access/acceptance.TestAccSecretScopeResource (20.90s)
  • access/acceptance.TestAzureAccKeyVaultSimple (4.18s)
  • compute.TestAccContext (31.09s)
  • compute.TestAccInstancePools (4.23s)
  • compute.TestAccLibraryCreate (129.77s)
  • compute.TestAccListClustersIntegration (316.69s)
  • compute.TestAzureAccNodeTypes (0.57s)
  • compute/acceptance.TestAccClusterPolicyResourceFullLifecycle (36.98s)
  • compute/acceptance.TestAccJobResource (11.96s)
  • identity.TestAccCreateToken (4.27s)
  • identity.TestAccCreateToken_NoExpiration (2.87s)
  • identity.TestAccCreateUser (7.48s)
  • identity.TestAccFilterGroup (3.41s)
  • identity.TestAccGroup (33.99s)
  • identity.TestAccReadUser (3.86s)
  • identity.TestAzureAccSP (7.10s)
  • identity/acceptance.TestAccComplexValueResource (27.80s)
  • identity/acceptance.TestAccGroupResource (33.71s)
  • identity/acceptance.TestAccGroupResource_verify_entitlements (19.86s)
  • identity/acceptance.TestAccTokenResource (13.36s)
  • identity/acceptance.TestAccUserResource (18.91s)
  • identity/acceptance.TestAzureAccServicePrincipalResource (12.82s)
  • internal/sanity.TestAccMissingResourcesInWorkspace (6.10s)
  • internal/sanity.TestAccMissingResourcesInWorkspace/Cluster_Policies (0.73s)
  • internal/sanity.TestAccMissingResourcesInWorkspace/Cluster_Policies_Delete (0.82s)
  • internal/sanity.TestAccMissingResourcesInWorkspace/Clusters (0.29s)
  • internal/sanity.TestAccMissingResourcesInWorkspace/DBFS_Files (0.71s)
  • internal/sanity.TestAccMissingResourcesInWorkspace/Groups (0.20s)
  • internal/sanity.TestAccMissingResourcesInWorkspace/Instance_Pools (0.48s)
  • internal/sanity.TestAccMissingResourcesInWorkspace/Jobs (0.28s)
  • internal/sanity.TestAccMissingResourcesInWorkspace/Notebooks (0.52s)
  • internal/sanity.TestAccMissingResourcesInWorkspace/Secret_ACLs (0.52s)
  • internal/sanity.TestAccMissingResourcesInWorkspace/Secret_Scopes (0.35s)
  • internal/sanity.TestAccMissingResourcesInWorkspace/Secrets (0.46s)
  • internal/sanity.TestAccMissingResourcesInWorkspace/Tokens (0.74s)
  • internal/sanity.TestAccMutiworkspaceUsedFromNormalMode (18.53s)
  • storage.TestAccCreateFile (6.63s)
  • storage.TestAccInvalidSecretScopeFails (5.55s)
  • storage.TestAccSourceOnInvalidMountFails (26.87s)
  • storage.TestAzureAccBlobMount (189.61s)
  • storage/acceptance.TestAccDatabricksDBFSFile_CreateViaContent (18.57s)
  • storage/acceptance.TestAccDatabricksDBFSFile_CreateViaSource (8.76s)
  • storage/acceptance.TestAzureAccBlobMount_correctly_mounts (642.00s)
  • workspace/acceptance.TestAccGlobalInitScriptResource_Create (19.33s)
  • workspace/acceptance.TestAccNotebookResourceScalability (22.35s)
  • workspace/acceptance.TestAccWorkspaceConfFullLifecycle (10.56s)

@codecov
Copy link

codecov bot commented Jul 14, 2021 •
edited
Loading

Codecov Report

Merging #726 (a710ad8) into master (5cc6874) will decrease coverage by 0.00%.
The diff coverage is 86.20%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #726      +/-   ##
==========================================
- Coverage   83.58%   83.57%   -0.01%     
==========================================
  Files          87       87              
  Lines        8053     8062       +9     
==========================================
+ Hits         6731     6738       +7     
- Misses        840      841       +1     
- Partials      482      483       +1
Impacted Files Coverage Δ
compute/model.go 76.31% <ø> (ø)
identity/groups.go 100.00% <ø> (ø)
identity/resource_service_principal.go 84.61% <0.00%> (-2.57%) ⬇️
common/azure_auth.go 79.20% <77.77%> (-0.21%) ⬇️
access/resource_sql_permissions.go 84.68% <100.00%> (+0.14%) ⬆️
identity/resource_group_instance_profile.go 100.00% <100.00%> (ø)
identity/resource_group_member.go 100.00% <100.00%> (ø)
identity/scim.go 92.59% <100.00%> (+0.28%) ⬆️
sqlanalytics/resource_sql_endpoint.go 87.65% <100.00%> (+0.15%) ⬆️
storage/mounts.go 79.61% <100.00%> (+0.95%) ⬆️

@alexott
Copy link
Contributor

alexott commented Jul 14, 2021

“Added support for hybrid instance pools” is two times in changelog

@nfx nfx added this to the v0.3.6 milestone Jul 16, 2021
@nfx nfx requested a review from alexott July 16, 2021 15:18
@nfx nfx linked an issue Jul 16, 2021 that may be closed by this pull request
[ISSUE] databricks_aws_s3_mount destory failed #693
Closed
@nfx nfx merged commit 1e3ad71 into master Jul 19, 2021
@nfx nfx deleted the prepare/0.3.6 branch July 19, 2021 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexott alexott alexott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.3.6
Development

Successfully merging this pull request may close these issues.

[ISSUE] databricks_aws_s3_mount destory failed
2 participants
@nfx @alexott