Fix the HTTP request rate limiter #577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rate limiter was initialized with a maximum of 1 request per second with a burst size of `RateLimitPerSecond`. Because we only use the `limiter.Wait()` API, we can fix the burst at 1.
nfx
approved these changes
Mar 26, 2021
Codecov Report
@@ Coverage Diff @@
## master #577 +/- ##
=======================================
Coverage 81.65% 81.65%
=======================================
Files 77 77
Lines 6678 6678
=======================================
Hits 5453 5453
Misses 815 815
Partials 410 410
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rate limiter was initialized with a maximum of 1 request per second with a
burst size of
RateLimitPerSecond. Because we only use thelimiter.Wait()API, we can fix the burst at 1.