Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support for job to have pause_status #575

Merged
merged 6 commits into from
Mar 26, 2021
Merged

Conversation

stikkireddy
Copy link
Contributor

Changed pause_status from the schedule config block in jobs to a optional+computed field rather than a computed field (least amount of disruption to existing state).
(Users can choose to omit it if the do not want terraform to nitpick that it has changed. Changing it to just optional will give the behavior of always tracking state and always must be managed by terraform.)

@stikkireddy stikkireddy requested review from alexott and nfx March 24, 2021 22:56
@codecov
Copy link

codecov bot commented Mar 24, 2021

Codecov Report

Merging #575 (a35eed9) into master (6669a94) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #575   +/-   ##
=======================================
  Coverage   81.65%   81.66%           
=======================================
  Files          77       77           
  Lines        6678     6680    +2     
=======================================
+ Hits         5453     5455    +2     
  Misses        815      815           
  Partials      410      410           
Impacted Files Coverage Δ
compute/resource_job.go 81.95% <100.00%> (+0.27%) ⬆️

Copy link
Contributor

@nfx nfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor edits required

CHANGELOG.md Outdated Show resolved Hide resolved
compute/model.go Outdated Show resolved Hide resolved
compute/resource_job.go Outdated Show resolved Hide resolved
compute/resource_job.go Outdated Show resolved Hide resolved
compute/resource_job.go Outdated Show resolved Hide resolved
compute/resource_job.go Outdated Show resolved Hide resolved
@stikkireddy stikkireddy requested a review from nfx March 25, 2021 00:11
Copy link
Contributor

@alexott alexott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just minor comment

docs/resources/job.md Outdated Show resolved Hide resolved
@nfx nfx merged commit abe1997 into master Mar 26, 2021
@nfx nfx deleted the support-job-schedule-pause branch March 26, 2021 15:23
@nfx nfx mentioned this pull request Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants