Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preparations for GCP support #558

Merged
merged 1 commit into from
Mar 11, 2021
Merged

Preparations for GCP support #558

merged 1 commit into from
Mar 11, 2021

Conversation

alexott
Copy link
Contributor

@alexott alexott commented Mar 10, 2021

Added IsGcp & IsAws functions, changed relevant places when we have AWS specific functionality, etc.

@alexott alexott requested a review from nfx March 10, 2021 17:49
@nfx
Copy link
Contributor

nfx commented Mar 10, 2021

Same build failure reason as in #559

@codecov
Copy link

codecov bot commented Mar 11, 2021

Codecov Report

Merging #558 (4dd1317) into master (245efa6) will decrease coverage by 0.03%.
The diff coverage is 30.76%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #558      +/-   ##
==========================================
- Coverage   81.62%   81.58%   -0.04%     
==========================================
  Files          77       77              
  Lines        6639     6642       +3     
==========================================
  Hits         5419     5419              
- Misses        811      814       +3     
  Partials      409      409              
Impacted Files Coverage Δ
compute/clusters.go 76.56% <12.50%> (-0.33%) ⬇️
common/client.go 82.67% <33.33%> (-1.33%) ⬇️
compute/common_instances.go 76.47% <100.00%> (ø)
exporter/util.go 59.45% <100.00%> (ø)

@nfx nfx merged commit 49b6eb8 into master Mar 11, 2021
@nfx nfx deleted the gcp-support branch March 11, 2021 20:13
@alexott alexott added this to the v0.3.2 milestone Mar 23, 2021
@nfx nfx mentioned this pull request Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants