Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update data_aws_policies.go #311

Merged
merged 4 commits into from
Sep 10, 2020
Merged

Update data_aws_policies.go #311

merged 4 commits into from
Sep 10, 2020

Conversation

stikkireddy
Copy link
Contributor

@stikkireddy stikkireddy commented Sep 10, 2020 •
edited
Loading

The new default for E2 is to support NPIP for when not bringing your own VPC. For this, there is a requirement to support creation of

  1. NatGateway
  2. RouteTables
  3. AllocatingAddress to allocate the EIP for Natgateway
  4. VPC endpoints
  5. DHCP options

This additions was created using the information provided in the docs and existing policy in the code and performing
set() - set() =

 "ec2:ReleaseAddress",
"ec2:CreateRouteTable",
"ec2:CreateNatGateway",
"ec2:DeleteNatGateway",
"ec2:DeleteDhcpOptions",
"ec2:DescribeNatGateways",
"ec2:DeleteVpcEndpoints",
"ec2:CreateVpcEndpoint",
"ec2:DisassociateRouteTable",
"ec2:AllocateAddress",

I also noticed that two items were removed that are required for BYOVPC:

"ec2:DescribeVpcAttribute",
"ec2:DescribeNetworkAcls",

I did not remove them to keep the superset between both BYOVPC and Databricks Managed VPC

I also added the field to allow the policy to be a superset of the BYOVPC:

"ec2:DetachVolume",

@nfx
Copy link
Contributor

nfx commented Sep 10, 2020

@stikkireddy in next release we should add "byovpc" attributes to data

@TravisBuddy
Copy link

Travis tests have failed

Hey @stikkireddy,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

1st Build

View build log

curl -sSL "https://github.com/gotestyourself/gotestsum/releases/download/v0.4.2/gotestsum_0.4.2_linux_amd64.tar.gz" | sudo tar -xz -C /usr/local/bin gotestsum 
The command "curl -sSL "https://github.com/gotestyourself/gotestsum/releases/download/v0.4.2/gotestsum_0.4.2_linux_amd64.tar.gz" | sudo tar -xz -C /usr/local/bin gotestsum" exited with 0.
$ curl -sSfL https://github.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.25.0
golangci/golangci-lint info checking GitHub for tag 'v1.25.0'
golangci/golangci-lint info found version: 1.25.0 for v1.25.0/linux/amd64
golangci/golangci-lint info installed /home/travis/gopath/bin/golangci-lint
The command "curl -sSfL https://github.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.25.0" exited with 0.
$ time make lint
✓ Linting source code with golangci-lint make sure you run make fmt ...
level=warning msg="[runner] Can't run linter unused: buildssa: analysis skipped: errors in package: [/home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:92:33: missing ',' before newline in composite literal /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:93:31: missing ',' before newline in composite literal /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:94:30: missing ',' before newline in composite literal /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:95:31: missing ',' before newline in composite literal /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:96:29: missing ',' before newline in composite literal /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:97:32: missing ',' before newline in composite literal /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:98:31: missing ',' before newline in composite literal /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:99:32: missing ',' before newline in composite literal /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:100:37: missing ',' before newline in composite literal /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:101:34: missing ',' before newline in composite literal]"
level=warning msg="[runner] Can't run linter goanalysis_metalinter: SA1013: failed prerequisites: [inspect@github.com/databrickslabs/databricks-terraform: analysis skipped: errors in package: [/home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/main.go:7:2: could not import github.com/databrickslabs/databricks-terraform/provider (/home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/provider/provider.go:12:2: could not import github.com/databrickslabs/databricks-terraform/access (/home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:92:33: missing ',' before newline in composite literal))]]"
level=error msg="Running error: SA1013: failed prerequisites: [inspect@github.com/databrickslabs/databricks-terraform: analysis skipped: errors in package: [/home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/main.go:7:2: could not import github.com/databrickslabs/databricks-terraform/provider (/home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/provider/provider.go:12:2: could not import github.com/databrickslabs/databricks-terraform/access (/home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:92:33: missing ',' before newline in composite literal))]]"
Makefile:10: recipe for target 'lint' failed
make: *** [lint] Error 3

real	0m22.361s
user	0m38.120s
sys	0m1.150s
The command "time make lint" exited with 2.
$ time make test
✓ Running tests...
# github.com/databrickslabs/databricks-terraform/access
access/data_aws_policies.go:92:33: syntax error: unexpected newline, expecting comma or }
# cover github.com/databrickslabs/databricks-terraform/access
2020/09/10 09:12:43 cover: /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go: /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:92:33: missing ',' before newline in composite literal (and 9 more errors)
time="2020-09-10T09:12:43Z" level=warning msg="FAIL\tgithub.51.al/databrickslabs/databricks-terraform/access [build failed]"
bad output from test2json: FAIL	github.com/databrickslabs/databricks-terraform/access [build failed]
time="2020-09-10T09:12:43Z" level=warning msg="FAIL\tgithub.51.al/databrickslabs/databricks-terraform/access/acceptance [build failed]"
bad output from test2json: FAIL	github.com/databrickslabs/databricks-terraform/access/acceptance [build failed]
✓  common (39ms) (coverage: 68.2% of statements)
✓  compute (634ms) (coverage: 68.6% of statements)
time="2020-09-10T09:12:50Z" level=warning msg="FAIL\tgithub.51.al/databrickslabs/databricks-terraform/compute/acceptance [build failed]"
bad output from test2json: FAIL	github.com/databrickslabs/databricks-terraform/compute/acceptance [build failed]
✓  identity (61ms) (coverage: 42.4% of statements)
time="2020-09-10T09:12:53Z" level=warning msg="FAIL\tgithub.51.al/databrickslabs/databricks-terraform/identity/acceptance [build failed]"
bad output from test2json: FAIL	github.com/databrickslabs/databricks-terraform/identity/acceptance [build failed]
✓  internal (23ms) (coverage: 67.5% of statements)
✓  internal/qa (11ms) (coverage: 54.3% of statements)
time="2020-09-10T09:12:54Z" level=warning msg="FAIL\tgithub.51.al/databrickslabs/databricks-terraform/internal/sanity [build failed]"
bad output from test2json: FAIL	github.com/databrickslabs/databricks-terraform/internal/sanity [build failed]
✓  mws (1.07s) (coverage: 70.5% of statements)
time="2020-09-10T09:12:57Z" level=warning msg="FAIL\tgithub.51.al/databrickslabs/databricks-terraform/mws/acceptance [build failed]"
bad output from test2json: FAIL	github.com/databrickslabs/databricks-terraform/mws/acceptance [build failed]
time="2020-09-10T09:12:57Z" level=warning msg="FAIL\tgithub.51.al/databrickslabs/databricks-terraform/provider [build failed]"
bad output from test2json: FAIL	github.com/databrickslabs/databricks-terraform/provider [build failed]
time="2020-09-10T09:12:57Z" level=warning msg="FAIL\tgithub.51.al/databrickslabs/databricks-terraform/storage [build failed]"
bad output from test2json: FAIL	github.com/databrickslabs/databricks-terraform/storage [build failed]
time="2020-09-10T09:12:57Z" level=warning msg="FAIL\tgithub.51.al/databrickslabs/databricks-terraform/storage/acceptance [build failed]"
bad output from test2json: FAIL	github.com/databrickslabs/databricks-terraform/storage/acceptance [build failed]
✓  workspace (10.045s) (coverage: 62.9% of statements)
time="2020-09-10T09:13:06Z" level=warning msg="FAIL\tgithub.51.al/databrickslabs/databricks-terraform/workspace/acceptance [build failed]"
bad output from test2json: FAIL	github.com/databrickslabs/databricks-terraform/workspace/acceptance [build failed]

=== Errors
access/data_aws_policies.go:92:33: syntax error: unexpected newline, expecting comma or }
2020/09/10 09:12:43 cover: /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go: /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:92:33: missing ',' before newline in composite literal (and 9 more errors)

DONE 357 tests, 21 skipped, 2 errors in 25.511s
Makefile:14: recipe for target 'test' failed
make: *** [test] Error 2

real	0m25.519s
user	0m12.028s
sys	0m1.667s
The command "time make test" exited with 2.
$ time make build
✓ Building source code with go build...
github.com/databrickslabs/databricks-terraform/access
# github.com/databrickslabs/databricks-terraform/access
access/data_aws_policies.go:92:33: syntax error: unexpected newline, expecting comma or }
Makefile:22: recipe for target 'build' failed
make: *** [build] Error 2

real	0m0.542s
user	0m0.814s
sys	0m0.186s
The command "time make build" exited with 2.
store build cache
changes detected (content changed, file is created, or file is deleted):\n/home/travis/.cache/go-build/00/00e1b2177eb904693d4dfff271b81c23b3a862fc056d3737e5b22c8abaec0b9e-a
/home/travis/.cache/go-build/01/010f37c92df4f6f04577214a674feb42bd8c44312b04775f012acbf99119d95e-a
/home/travis/.cache/go-build/01/0176b78421fa067ca6317b7bd53d6d871b0527ba8612da195870836a0eea7699-a
/home/travis/.cache/go-build/01/018133b69dbbfa88f755e9936202e2160b329aaed217ea3a84321afccc8b72ee-a
/home/travis/.cache/go-build/04/0432cf5932f3837785f56251e9091f5132de6731d6f70dcdd8ce61b402b8837c-a
/home/travis/.cache/go-build/04/0478f11e1920f64f2164f53b3e177952f92c0b49f15d8c3fea853cc62bc8b065-a
/home/travis/.cache/go-build/07/07bac66bc949882bec52a443ae896e3a3c23595786f3e4cd5e7ed188e7db0275-a
/home/travis/.cache/go-build/0d/0ddb3fcc3f582f67ac4f3cd97298cd1ec8fc35b12b77176c3301673c1cf8749d-a
/home/travis/.cache/go-build/0e/0ef0205994b8bf64ba6a39b6ad73c1c229726d03ab98274606d95e95ccb73266-d
/home/travis/.cache/go-build/0f/0f7aedc5898b861123ba7d9935c60b091a5bc19d9ed74c2fe379bdbf305a548f-a
/home/trav\n...
changes detected, packing new archive
uploading PR.311/cache--linux-xenial-e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855--go-1.13.x.tgz
cache uploaded


Done. Your build exited with 1.
curl -sSfL https://github.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.25.0 
golangci/golangci-lint info checking GitHub for tag 'v1.25.0'
golangci/golangci-lint info found version: 1.25.0 for v1.25.0/linux/amd64
golangci/golangci-lint info installed /home/travis/gopath/bin/golangci-lint
time make lint 
✓ Linting source code with golangci-lint make sure you run make fmt ...
level=warning msg="[runner] Can't run linter unused: buildssa: analysis skipped: errors in package: [/home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:92:33: missing ',' before newline in composite literal /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:93:31: missing ',' before newline in composite literal /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:94:30: missing ',' before newline in composite literal /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:95:31: missing ',' before newline in composite literal /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:96:29: missing ',' before newline in composite literal /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:97:32: missing ',' before newline in composite literal /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:98:31: missing ',' before newline in composite literal /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:99:32: missing ',' before newline in composite literal /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:100:37: missing ',' before newline in composite literal /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:101:34: missing ',' before newline in composite literal]"
level=warning msg="[runner] Can't run linter goanalysis_metalinter: SA1013: failed prerequisites: [inspect@github.com/databrickslabs/databricks-terraform: analysis skipped: errors in package: [/home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/main.go:7:2: could not import github.com/databrickslabs/databricks-terraform/provider (/home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/provider/provider.go:12:2: could not import github.com/databrickslabs/databricks-terraform/access (/home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:92:33: missing ',' before newline in composite literal))]]"
level=error msg="Running error: SA1013: failed prerequisites: [inspect@github.com/databrickslabs/databricks-terraform: analysis skipped: errors in package: [/home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/main.go:7:2: could not import github.com/databrickslabs/databricks-terraform/provider (/home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/provider/provider.go:12:2: could not import github.com/databrickslabs/databricks-terraform/access (/home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:92:33: missing ',' before newline in composite literal))]]"
Makefile:10: recipe for target 'lint' failed
make: *** [lint] Error 3

real	0m22.361s
user	0m38.120s
sys	0m1.150s
time make test 
✓ Running tests...
# github.com/databrickslabs/databricks-terraform/access
access/data_aws_policies.go:92:33: syntax error: unexpected newline, expecting comma or }
# cover github.com/databrickslabs/databricks-terraform/access
2020/09/10 09:12:43 cover: /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go: /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:92:33: missing ',' before newline in composite literal (and 9 more errors)
time="2020-09-10T09:12:43Z" level=warning msg="FAIL\tgithub.51.al/databrickslabs/databricks-terraform/access [build failed]"
bad output from test2json: FAIL	github.com/databrickslabs/databricks-terraform/access [build failed]
time="2020-09-10T09:12:43Z" level=warning msg="FAIL\tgithub.51.al/databrickslabs/databricks-terraform/access/acceptance [build failed]"
bad output from test2json: FAIL	github.com/databrickslabs/databricks-terraform/access/acceptance [build failed]
✓  common (39ms) (coverage: 68.2% of statements)
✓  compute (634ms) (coverage: 68.6% of statements)
time="2020-09-10T09:12:50Z" level=warning msg="FAIL\tgithub.51.al/databrickslabs/databricks-terraform/compute/acceptance [build failed]"
bad output from test2json: FAIL	github.com/databrickslabs/databricks-terraform/compute/acceptance [build failed]
✓  identity (61ms) (coverage: 42.4% of statements)
time="2020-09-10T09:12:53Z" level=warning msg="FAIL\tgithub.51.al/databrickslabs/databricks-terraform/identity/acceptance [build failed]"
bad output from test2json: FAIL	github.com/databrickslabs/databricks-terraform/identity/acceptance [build failed]
✓  internal (23ms) (coverage: 67.5% of statements)
✓  internal/qa (11ms) (coverage: 54.3% of statements)
time="2020-09-10T09:12:54Z" level=warning msg="FAIL\tgithub.51.al/databrickslabs/databricks-terraform/internal/sanity [build failed]"
bad output from test2json: FAIL	github.com/databrickslabs/databricks-terraform/internal/sanity [build failed]
✓  mws (1.07s) (coverage: 70.5% of statements)
time="2020-09-10T09:12:57Z" level=warning msg="FAIL\tgithub.51.al/databrickslabs/databricks-terraform/mws/acceptance [build failed]"
bad output from test2json: FAIL	github.com/databrickslabs/databricks-terraform/mws/acceptance [build failed]
time="2020-09-10T09:12:57Z" level=warning msg="FAIL\tgithub.51.al/databrickslabs/databricks-terraform/provider [build failed]"
bad output from test2json: FAIL	github.com/databrickslabs/databricks-terraform/provider [build failed]
time="2020-09-10T09:12:57Z" level=warning msg="FAIL\tgithub.51.al/databrickslabs/databricks-terraform/storage [build failed]"
bad output from test2json: FAIL	github.com/databrickslabs/databricks-terraform/storage [build failed]
time="2020-09-10T09:12:57Z" level=warning msg="FAIL\tgithub.51.al/databrickslabs/databricks-terraform/storage/acceptance [build failed]"
bad output from test2json: FAIL	github.com/databrickslabs/databricks-terraform/storage/acceptance [build failed]
✓  workspace (10.045s) (coverage: 62.9% of statements)
time="2020-09-10T09:13:06Z" level=warning msg="FAIL\tgithub.51.al/databrickslabs/databricks-terraform/workspace/acceptance [build failed]"
bad output from test2json: FAIL	github.com/databrickslabs/databricks-terraform/workspace/acceptance [build failed]

=== Errors
access/data_aws_policies.go:92:33: syntax error: unexpected newline, expecting comma or }
2020/09/10 09:12:43 cover: /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go: /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:92:33: missing ',' before newline in composite literal (and 9 more errors)

DONE 357 tests, 21 skipped, 2 errors in 25.511s
Makefile:14: recipe for target 'test' failed
make: *** [test] Error 2

real	0m25.519s
user	0m12.028s
sys	0m1.667s
time make build 
✓ Building source code with go build...
github.com/databrickslabs/databricks-terraform/access
# github.com/databrickslabs/databricks-terraform/access
access/data_aws_policies.go:92:33: syntax error: unexpected newline, expecting comma or }
Makefile:22: recipe for target 'build' failed
make: *** [build] Error 2

real	0m0.542s
user	0m0.814s
sys	0m0.186s

2nd Build

View build log

curl -sSL "https://github.com/gotestyourself/gotestsum/releases/download/v0.4.2/gotestsum_0.4.2_linux_amd64.tar.gz" | sudo tar -xz -C /usr/local/bin gotestsum 
The command "curl -sSL "https://github.com/gotestyourself/gotestsum/releases/download/v0.4.2/gotestsum_0.4.2_linux_amd64.tar.gz" | sudo tar -xz -C /usr/local/bin gotestsum" exited with 0.
$ curl -sSfL https://github.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.25.0
golangci/golangci-lint info checking GitHub for tag 'v1.25.0'
golangci/golangci-lint info found version: 1.25.0 for v1.25.0/linux/amd64
golangci/golangci-lint info installed /home/travis/gopath/bin/golangci-lint
The command "curl -sSfL https://github.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.25.0" exited with 0.
$ time make lint
✓ Linting source code with golangci-lint make sure you run make fmt ...
level=warning msg="[runner] Can't run linter goanalysis_metalinter: interfacer: failed prerequisites: [buildssa@github.com/databrickslabs/databricks-terraform: analysis skipped: errors in package: [/home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/main.go:7:2: could not import github.com/databrickslabs/databricks-terraform/provider (/home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/provider/provider.go:12:2: could not import github.com/databrickslabs/databricks-terraform/access (/home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:92:33: missing ',' before newline in composite literal))]]"
level=warning msg="[runner] Can't run linter unused: buildssa: analysis skipped: errors in package: [/home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:92:33: missing ',' before newline in composite literal /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:93:31: missing ',' before newline in composite literal /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:94:30: missing ',' before newline in composite literal /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:95:31: missing ',' before newline in composite literal /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:96:29: missing ',' before newline in composite literal /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:97:32: missing ',' before newline in composite literal /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:98:31: missing ',' before newline in composite literal /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:99:32: missing ',' before newline in composite literal /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:100:37: missing ',' before newline in composite literal /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:101:34: missing ',' before newline in composite literal -: could not load export data: no export data for \"github.com/databrickslabs/databricks-terraform/access\" /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:92:33: missing ',' before newline in composite literal /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:93:31: missing ',' before newline in composite literal /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:94:30: missing ',' before newline in composite literal /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:95:31: missing ',' before newline in composite literal /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:96:29: missing ',' before newline in composite literal /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:97:32: missing ',' before newline in composite literal /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:98:31: missing ',' before newline in composite literal /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:99:32: missing ',' before newline in composite literal /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:100:37: missing ',' before newline in composite literal /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:101:34: missing ',' before newline in composite literal]"
level=error msg="Running error: buildssa: analysis skipped: errors in package: [/home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:92:33: missing ',' before newline in composite literal /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:93:31: missing ',' before newline in composite literal /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:94:30: missing ',' before newline in composite literal /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:95:31: missing ',' before newline in composite literal /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:96:29: missing ',' before newline in composite literal /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:97:32: missing ',' before newline in composite literal /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:98:31: missing ',' before newline in composite literal /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:99:32: missing ',' before newline in composite literal /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:100:37: missing ',' before newline in composite literal /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:101:34: missing ',' before newline in composite literal -: could not load export data: no export data for \"github.com/databrickslabs/databricks-terraform/access\" /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:92:33: missing ',' before newline in composite literal /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:93:31: missing ',' before newline in composite literal /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:94:30: missing ',' before newline in composite literal /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:95:31: missing ',' before newline in composite literal /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:96:29: missing ',' before newline in composite literal /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:97:32: missing ',' before newline in composite literal /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:98:31: missing ',' before newline in composite literal /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:99:32: missing ',' before newline in composite literal /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:100:37: missing ',' before newline in composite literal /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:101:34: missing ',' before newline in composite literal]"
Makefile:10: recipe for target 'lint' failed
make: *** [lint] Error 3

real	0m53.814s
user	1m29.598s
sys	0m5.801s
The command "time make lint" exited with 2.
$ time make test
✓ Running tests...
# github.com/databrickslabs/databricks-terraform/access
access/data_aws_policies.go:92:33: syntax error: unexpected newline, expecting comma or }
# cover github.com/databrickslabs/databricks-terraform/access
2020/09/10 09:14:03 cover: /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go: /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:92:33: missing ',' before newline in composite literal (and 9 more errors)
time="2020-09-10T09:14:03Z" level=warning msg="FAIL\tgithub.51.al/databrickslabs/databricks-terraform/access [build failed]"
bad output from test2json: FAIL	github.com/databrickslabs/databricks-terraform/access [build failed]
time="2020-09-10T09:14:03Z" level=warning msg="FAIL\tgithub.51.al/databrickslabs/databricks-terraform/access/acceptance [build failed]"
bad output from test2json: FAIL	github.com/databrickslabs/databricks-terraform/access/acceptance [build failed]
✓  common (61ms) (coverage: 68.2% of statements)
✓  identity (63ms) (coverage: 42.4% of statements)
✓  compute (716ms) (coverage: 68.6% of statements)
time="2020-09-10T09:14:08Z" level=warning msg="FAIL\tgithub.51.al/databrickslabs/databricks-terraform/compute/acceptance [build failed]"
bad output from test2json: FAIL	github.com/databrickslabs/databricks-terraform/compute/acceptance [build failed]
time="2020-09-10T09:14:08Z" level=warning msg="FAIL\tgithub.51.al/databrickslabs/databricks-terraform/identity/acceptance [build failed]"
bad output from test2json: FAIL	github.com/databrickslabs/databricks-terraform/identity/acceptance [build failed]
✓  internal (10ms) (coverage: 67.5% of statements)
✓  internal/qa (11ms) (coverage: 54.3% of statements)
time="2020-09-10T09:14:09Z" level=warning msg="FAIL\tgithub.51.al/databrickslabs/databricks-terraform/internal/sanity [build failed]"
bad output from test2json: FAIL	github.com/databrickslabs/databricks-terraform/internal/sanity [build failed]
✓  mws (1.093s) (coverage: 70.5% of statements)
time="2020-09-10T09:14:12Z" level=warning msg="FAIL\tgithub.51.al/databrickslabs/databricks-terraform/mws/acceptance [build failed]"
bad output from test2json: FAIL	github.com/databrickslabs/databricks-terraform/mws/acceptance [build failed]
time="2020-09-10T09:14:12Z" level=warning msg="FAIL\tgithub.51.al/databrickslabs/databricks-terraform/provider [build failed]"
bad output from test2json: FAIL	github.com/databrickslabs/databricks-terraform/provider [build failed]
time="2020-09-10T09:14:12Z" level=warning msg="FAIL\tgithub.51.al/databrickslabs/databricks-terraform/storage [build failed]"
bad output from test2json: FAIL	github.com/databrickslabs/databricks-terraform/storage [build failed]
time="2020-09-10T09:14:12Z" level=warning msg="FAIL\tgithub.51.al/databrickslabs/databricks-terraform/storage/acceptance [build failed]"
bad output from test2json: FAIL	github.com/databrickslabs/databricks-terraform/storage/acceptance [build failed]
✓  workspace (10.046s) (coverage: 62.9% of statements)
time="2020-09-10T09:14:22Z" level=warning msg="FAIL\tgithub.51.al/databrickslabs/databricks-terraform/workspace/acceptance [build failed]"
bad output from test2json: FAIL	github.com/databrickslabs/databricks-terraform/workspace/acceptance [build failed]

=== Errors
access/data_aws_policies.go:92:33: syntax error: unexpected newline, expecting comma or }
2020/09/10 09:14:03 cover: /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go: /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:92:33: missing ',' before newline in composite literal (and 9 more errors)

DONE 357 tests, 21 skipped, 2 errors in 60.899s
Makefile:14: recipe for target 'test' failed
make: *** [test] Error 2

real	1m0.931s
user	1m26.684s
sys	0m9.170s
The command "time make test" exited with 2.
$ time make build
✓ Building source code with go build...
github.com/databrickslabs/databricks-terraform/access
# github.com/databrickslabs/databricks-terraform/access
access/data_aws_policies.go:92:33: syntax error: unexpected newline, expecting comma or }
Makefile:22: recipe for target 'build' failed
make: *** [build] Error 2

real	0m0.504s
user	0m0.793s
sys	0m0.158s
The command "time make build" exited with 2.
store build cache
changes detected (content changed, file is created, or file is deleted):\n/home/travis/.cache/go-build/00/0008603b55fec659983ba1a944e89e0585ff3812ec4ce7bc8a1c7833988d59da-a
/home/travis/.cache/go-build/00/00239a23c8f1f796acbc9d123aeebf125cbf2a3ce551a996c82916419c3a9a47-a
/home/travis/.cache/go-build/00/0035db352b49e2e57d0027e20dcdbe4a28730484dc668edcdc4d0db981adb9cc-a
/home/travis/.cache/go-build/00/0050b21b7194592b7e4c95e477060edc32214b9a834c113379785fe0235dab35-a
/home/travis/.cache/go-build/00/005616fc12873fc3f681f4c541ea6b1e6365822cafe940fe019021b2853deb0d-a
/home/travis/.cache/go-build/00/00618e5ba338ae26434b6f3f43373315ebe9c156d9f878e458168743fb6779f9-d
/home/travis/.cache/go-build/00/00791c46ae5d7d8fcc17a21f93d56939f110d7dd6a19fe0538302a1a11d5c243-a
/home/travis/.cache/go-build/00/007a9f7cf4b2338a7a0628685c7f736310d7033f1c565e3195684746fb91d6b7-d
/home/travis/.cache/go-build/00/00864763dc7680e59115113022a0f03f7ade7e68618f8a4d1207ad0638babe4c-d
/home/travis/.cache/go-build/00/008dda5d28d9e95da046aea04971baf500f0a455b77ceb23f28ccc7e8428329a-d
/home/trav\n...
changes detected, packing new archive
uploading PR.311/cache--linux-xenial-e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855--go-1.14.x.tgz
cache uploaded


Done. Your build exited with 1.
curl -sSfL https://github.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.25.0 
golangci/golangci-lint info checking GitHub for tag 'v1.25.0'
golangci/golangci-lint info found version: 1.25.0 for v1.25.0/linux/amd64
golangci/golangci-lint info installed /home/travis/gopath/bin/golangci-lint
time make lint 
✓ Linting source code with golangci-lint make sure you run make fmt ...
level=warning msg="[runner] Can't run linter goanalysis_metalinter: interfacer: failed prerequisites: [buildssa@github.com/databrickslabs/databricks-terraform: analysis skipped: errors in package: [/home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/main.go:7:2: could not import github.com/databrickslabs/databricks-terraform/provider (/home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/provider/provider.go:12:2: could not import github.com/databrickslabs/databricks-terraform/access (/home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:92:33: missing ',' before newline in composite literal))]]"
level=warning msg="[runner] Can't run linter unused: buildssa: analysis skipped: errors in package: [/home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:92:33: missing ',' before newline in composite literal /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:93:31: missing ',' before newline in composite literal /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:94:30: missing ',' before newline in composite literal /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:95:31: missing ',' before newline in composite literal /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:96:29: missing ',' before newline in composite literal /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:97:32: missing ',' before newline in composite literal /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:98:31: missing ',' before newline in composite literal /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:99:32: missing ',' before newline in composite literal /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:100:37: missing ',' before newline in composite literal /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:101:34: missing ',' before newline in composite literal -: could not load export data: no export data for \"github.com/databrickslabs/databricks-terraform/access\" /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:92:33: missing ',' before newline in composite literal /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:93:31: missing ',' before newline in composite literal /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:94:30: missing ',' before newline in composite literal /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:95:31: missing ',' before newline in composite literal /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:96:29: missing ',' before newline in composite literal /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:97:32: missing ',' before newline in composite literal /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:98:31: missing ',' before newline in composite literal /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:99:32: missing ',' before newline in composite literal /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:100:37: missing ',' before newline in composite literal /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:101:34: missing ',' before newline in composite literal]"
level=error msg="Running error: buildssa: analysis skipped: errors in package: [/home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:92:33: missing ',' before newline in composite literal /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:93:31: missing ',' before newline in composite literal /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:94:30: missing ',' before newline in composite literal /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:95:31: missing ',' before newline in composite literal /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:96:29: missing ',' before newline in composite literal /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:97:32: missing ',' before newline in composite literal /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:98:31: missing ',' before newline in composite literal /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:99:32: missing ',' before newline in composite literal /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:100:37: missing ',' before newline in composite literal /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:101:34: missing ',' before newline in composite literal -: could not load export data: no export data for \"github.com/databrickslabs/databricks-terraform/access\" /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:92:33: missing ',' before newline in composite literal /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:93:31: missing ',' before newline in composite literal /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:94:30: missing ',' before newline in composite literal /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:95:31: missing ',' before newline in composite literal /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:96:29: missing ',' before newline in composite literal /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:97:32: missing ',' before newline in composite literal /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:98:31: missing ',' before newline in composite literal /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:99:32: missing ',' before newline in composite literal /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:100:37: missing ',' before newline in composite literal /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:101:34: missing ',' before newline in composite literal]"
Makefile:10: recipe for target 'lint' failed
make: *** [lint] Error 3

real	0m53.814s
user	1m29.598s
sys	0m5.801s
time make test 
✓ Running tests...
# github.com/databrickslabs/databricks-terraform/access
access/data_aws_policies.go:92:33: syntax error: unexpected newline, expecting comma or }
# cover github.com/databrickslabs/databricks-terraform/access
2020/09/10 09:14:03 cover: /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go: /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:92:33: missing ',' before newline in composite literal (and 9 more errors)
time="2020-09-10T09:14:03Z" level=warning msg="FAIL\tgithub.51.al/databrickslabs/databricks-terraform/access [build failed]"
bad output from test2json: FAIL	github.com/databrickslabs/databricks-terraform/access [build failed]
time="2020-09-10T09:14:03Z" level=warning msg="FAIL\tgithub.51.al/databrickslabs/databricks-terraform/access/acceptance [build failed]"
bad output from test2json: FAIL	github.com/databrickslabs/databricks-terraform/access/acceptance [build failed]
✓  common (61ms) (coverage: 68.2% of statements)
✓  identity (63ms) (coverage: 42.4% of statements)
✓  compute (716ms) (coverage: 68.6% of statements)
time="2020-09-10T09:14:08Z" level=warning msg="FAIL\tgithub.51.al/databrickslabs/databricks-terraform/compute/acceptance [build failed]"
bad output from test2json: FAIL	github.com/databrickslabs/databricks-terraform/compute/acceptance [build failed]
time="2020-09-10T09:14:08Z" level=warning msg="FAIL\tgithub.51.al/databrickslabs/databricks-terraform/identity/acceptance [build failed]"
bad output from test2json: FAIL	github.com/databrickslabs/databricks-terraform/identity/acceptance [build failed]
✓  internal (10ms) (coverage: 67.5% of statements)
✓  internal/qa (11ms) (coverage: 54.3% of statements)
time="2020-09-10T09:14:09Z" level=warning msg="FAIL\tgithub.51.al/databrickslabs/databricks-terraform/internal/sanity [build failed]"
bad output from test2json: FAIL	github.com/databrickslabs/databricks-terraform/internal/sanity [build failed]
✓  mws (1.093s) (coverage: 70.5% of statements)
time="2020-09-10T09:14:12Z" level=warning msg="FAIL\tgithub.51.al/databrickslabs/databricks-terraform/mws/acceptance [build failed]"
bad output from test2json: FAIL	github.com/databrickslabs/databricks-terraform/mws/acceptance [build failed]
time="2020-09-10T09:14:12Z" level=warning msg="FAIL\tgithub.51.al/databrickslabs/databricks-terraform/provider [build failed]"
bad output from test2json: FAIL	github.com/databrickslabs/databricks-terraform/provider [build failed]
time="2020-09-10T09:14:12Z" level=warning msg="FAIL\tgithub.51.al/databrickslabs/databricks-terraform/storage [build failed]"
bad output from test2json: FAIL	github.com/databrickslabs/databricks-terraform/storage [build failed]
time="2020-09-10T09:14:12Z" level=warning msg="FAIL\tgithub.51.al/databrickslabs/databricks-terraform/storage/acceptance [build failed]"
bad output from test2json: FAIL	github.com/databrickslabs/databricks-terraform/storage/acceptance [build failed]
✓  workspace (10.046s) (coverage: 62.9% of statements)
time="2020-09-10T09:14:22Z" level=warning msg="FAIL\tgithub.51.al/databrickslabs/databricks-terraform/workspace/acceptance [build failed]"
bad output from test2json: FAIL	github.com/databrickslabs/databricks-terraform/workspace/acceptance [build failed]

=== Errors
access/data_aws_policies.go:92:33: syntax error: unexpected newline, expecting comma or }
2020/09/10 09:14:03 cover: /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go: /home/travis/gopath/src/github.com/databrickslabs/terraform-provider-databricks/access/data_aws_policies.go:92:33: missing ',' before newline in composite literal (and 9 more errors)

DONE 357 tests, 21 skipped, 2 errors in 60.899s
Makefile:14: recipe for target 'test' failed
make: *** [test] Error 2

real	1m0.931s
user	1m26.684s
sys	0m9.170s
time make build 
✓ Building source code with go build...
github.com/databrickslabs/databricks-terraform/access
# github.com/databrickslabs/databricks-terraform/access
access/data_aws_policies.go:92:33: syntax error: unexpected newline, expecting comma or }
Makefile:22: recipe for target 'build' failed
make: *** [build] Error 2

real	0m0.504s
user	0m0.793s
sys	0m0.158s
TravisBuddy Request Identifier: 1d6e7560-f346-11ea-addc-35ae975c2fab

@TravisBuddy
Copy link

Travis tests have failed

Hey @stikkireddy,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

2nd Build

View build log

curl -sSL "https://github.com/gotestyourself/gotestsum/releases/download/v0.4.2/gotestsum_0.4.2_linux_amd64.tar.gz" | sudo tar -xz -C /usr/local/bin gotestsum 
The command "curl -sSL "https://github.com/gotestyourself/gotestsum/releases/download/v0.4.2/gotestsum_0.4.2_linux_amd64.tar.gz" | sudo tar -xz -C /usr/local/bin gotestsum" exited with 0.
$ curl -sSfL https://github.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.25.0
golangci/golangci-lint info checking GitHub for tag 'v1.25.0'
golangci/golangci-lint info found version: 1.25.0 for v1.25.0/linux/amd64
golangci/golangci-lint info installed /home/travis/gopath/bin/golangci-lint
The command "curl -sSfL https://github.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.25.0" exited with 0.
$ time make lint
✓ Linting source code with golangci-lint make sure you run make fmt ...

real	1m0.589s
user	1m36.832s
sys	0m6.256s
The command "time make lint" exited with 0.
$ time make test
✓ Running tests...
∅  .
✓  access/acceptance (19ms)
=== RUN   TestDataAwsCrossAccountRolicy
    data_aws_policies_test.go:19: 
        	Error Trace:	data_aws_policies_test.go:19
        	Error:      	"{
        	            	  "Version": "2008-10-17",
        	            	  "Statement": [
        	            	    {
        	            	      "Effect": "Allow",
        	            	      "Action": [
        	            	        "ec2:AssociateDhcpOptions",
        	            	        "ec2:AssociateIamInstanceProfile",
        	            	        "ec2:AssociateRouteTable",
        	            	        "ec2:AttachInternetGateway",
        	            	        "ec2:AttachVolume",
        	            	        "ec2:AuthorizeSecurityGroupEgress",
        	            	        "ec2:AuthorizeSecurityGroupIngress",
        	            	        "ec2:CancelSpotInstanceRequests",
        	            	        "ec2:CreateDhcpOptions",
        	            	        "ec2:CreateInternetGateway",
        	            	        "ec2:CreateKeyPair",
        	            	        "ec2:CreateRoute",
        	            	        "ec2:CreateSecurityGroup",
        	            	        "ec2:CreateSubnet",
        	            	        "ec2:CreateTags",
        	            	        "ec2:CreateVolume",
        	            	        "ec2:CreateVpc",
        	            	        "ec2:DeleteInternetGateway",
        	            	        "ec2:DeleteKeyPair",
        	            	        "ec2:DeleteRoute",
        	            	        "ec2:DeleteRouteTable",
        	            	        "ec2:DeleteSecurityGroup",
        	            	        "ec2:DeleteSubnet",
        	            	        "ec2:DeleteTags",
        	            	        "ec2:DeleteVolume",
        	            	        "ec2:DeleteVpc",
        	            	        "ec2:DescribeAvailabilityZones",
        	            	        "ec2:DescribeNetworkAcls",
        	            	        "ec2:DescribeInternetGateways",
        	            	        "ec2:DescribeVpcAttribute",
        	            	        "ec2:DescribeIamInstanceProfileAssociations",
        	            	        "ec2:DescribeInstanceStatus",
        	            	        "ec2:DescribeInstances",
        	            	        "ec2:DescribePrefixLists",
        	            	        "ec2:DescribeReservedInstancesOfferings",
        	            	        "ec2:DescribeRouteTables",
        	            	        "ec2:DescribeSecurityGroups",
        	            	        "ec2:DescribeSpotInstanceRequests",
        	            	        "ec2:DescribeSpotPriceHistory",
        	            	        "ec2:DescribeSubnets",
        	            	        "ec2:DescribeVolumes",
        	            	        "ec2:DescribeVpcs",
        	            	        "ec2:DetachInternetGateway",
        	            	        "ec2:DisassociateIamInstanceProfile",
        	            	        "ec2:ModifyVpcAttribute",
        	            	        "ec2:ReplaceIamInstanceProfileAssociation",
        	            	        "ec2:RequestSpotInstances",
        	            	        "ec2:RevokeSecurityGroupEgress",
        	            	        "ec2:RevokeSecurityGroupIngress",
        	            	        "ec2:RunInstances",
        	            	        "ec2:TerminateInstances",
        	            	        "ec2:CreatePlacementGroup",
        	            	        "ec2:DeletePlacementGroup",
        	            	        "ec2:DescribePlacementGroups",
        	            	        "ec2:AllocateAddress",
        	            	        "ec2:CreateNatGateway",
        	            	        "ec2:CreateRouteTable",
        	            	        "ec2:CreateVpcEndpoint",
        	            	        "ec2:DeleteDhcpOptions",
        	            	        "ec2:DeleteNatGateway",
        	            	        "ec2:DeleteVpcEndpoints",
        	            	        "ec2:DescribeNatGateways",
        	            	        "ec2:DisassociateRouteTable",
        	            	        "ec2:ReleaseAddress"
        	            	      ],
        	            	      "Resource": "*"
        	            	    },
        	            	    {
        	            	      "Effect": "Allow",
        	            	      "Action": [
        	            	        "iam:CreateServiceLinkedRole",
        	            	        "iam:PutRolePolicy"
        	            	      ],
        	            	      "Resource": "arn:aws:iam::*:role/aws-service-role/spot.amazonaws.com/AWSServiceRoleForEC2Spot",
        	            	      "Condition": {
        	            	        "StringLike": {
        	            	          "iam:AWSServiceName": "spot.amazonaws.com"
        	            	        }
        	            	      }
        	            	    }
        	            	  ]
        	            	}" should have 2401 item(s), but has 2731
        	Test:       	TestDataAwsCrossAccountRolicy
        	Messages:   	Strange length for policy: {
        	            	  "Version": "2008-10-17",
        	            	  "Statement": [
        	            	    {
        	            	      "Effect": "Allow",
        	            	      "Action": [
        	            	        "ec2:AssociateDhcpOptions",
        	            	        "ec2:AssociateIamInstanceProfile",
        	            	        "ec2:AssociateRouteTable",
        	            	        "ec2:AttachInternetGateway",
        	            	        "ec2:AttachVolume",
        	            	        "ec2:AuthorizeSecurityGroupEgress",
        	            	        "ec2:AuthorizeSecurityGroupIngress",
        	            	        "ec2:CancelSpotInstanceRequests",
        	            	        "ec2:CreateDhcpOptions",
        	            	        "ec2:CreateInternetGateway",
        	            	        "ec2:CreateKeyPair",
        	            	        "ec2:CreateRoute",
        	            	        "ec2:CreateSecurityGroup",
        	            	        "ec2:CreateSubnet",
        	            	        "ec2:CreateTags",
        	            	        "ec2:CreateVolume",
        	            	        "ec2:CreateVpc",
        	            	        "ec2:DeleteInternetGateway",
        	            	        "ec2:DeleteKeyPair",
        	            	        "ec2:DeleteRoute",
        	            	        "ec2:DeleteRouteTable",
        	            	        "ec2:DeleteSecurityGroup",
        	            	        "ec2:DeleteSubnet",
        	            	        "ec2:DeleteTags",
        	            	        "ec2:DeleteVolume",
        	            	        "ec2:DeleteVpc",
        	            	        "ec2:DescribeAvailabilityZones",
        	            	        "ec2:DescribeNetworkAcls",
        	            	        "ec2:DescribeInternetGateways",
        	            	        "ec2:DescribeVpcAttribute",
        	            	        "ec2:DescribeIamInstanceProfileAssociations",
        	            	        "ec2:DescribeInstanceStatus",
        	            	        "ec2:DescribeInstances",
        	            	        "ec2:DescribePrefixLists",
        	            	        "ec2:DescribeReservedInstancesOfferings",
        	            	        "ec2:DescribeRouteTables",
        	            	        "ec2:DescribeSecurityGroups",
        	            	        "ec2:DescribeSpotInstanceRequests",
        	            	        "ec2:DescribeSpotPriceHistory",
        	            	        "ec2:DescribeSubnets",
        	            	        "ec2:DescribeVolumes",
        	            	        "ec2:DescribeVpcs",
        	            	        "ec2:DetachInternetGateway",
        	            	        "ec2:DisassociateIamInstanceProfile",
        	            	        "ec2:ModifyVpcAttribute",
        	            	        "ec2:ReplaceIamInstanceProfileAssociation",
        	            	        "ec2:RequestSpotInstances",
        	            	        "ec2:RevokeSecurityGroupEgress",
        	            	        "ec2:RevokeSecurityGroupIngress",
        	            	        "ec2:RunInstances",
        	            	        "ec2:TerminateInstances",
        	            	        "ec2:CreatePlacementGroup",
        	            	        "ec2:DeletePlacementGroup",
        	            	        "ec2:DescribePlacementGroups",
        	            	        "ec2:AllocateAddress",
        	            	        "ec2:CreateNatGateway",
        	            	        "ec2:CreateRouteTable",
        	            	        "ec2:CreateVpcEndpoint",
        	            	        "ec2:DeleteDhcpOptions",
        	            	        "ec2:DeleteNatGateway",
        	            	        "ec2:DeleteVpcEndpoints",
        	            	        "ec2:DescribeNatGateways",
        	            	        "ec2:DisassociateRouteTable",
        	            	        "ec2:ReleaseAddress"
        	            	      ],
        	            	      "Resource": "*"
        	            	    },
        	            	    {
        	            	      "Effect": "Allow",
        	            	      "Action": [
        	            	        "iam:CreateServiceLinkedRole",
        	            	        "iam:PutRolePolicy"
        	            	      ],
        	            	      "Resource": "arn:aws:iam::*:role/aws-service-role/spot.amazonaws.com/AWSServiceRoleForEC2Spot",
        	            	      "Condition": {
        	            	        "StringLike": {
        	            	          "iam:AWSServiceName": "spot.amazonaws.com"
        	            	        }
        	            	      }
        	            	    }
        	            	  ]
        	            	}
--- FAIL: TestDataAwsCrossAccountRolicy (0.01s)
=== RUN   TestDataAwsCrossAccountRolicy_WithPassRoles
    data_aws_policies_test.go:32: 
        	Error Trace:	data_aws_policies_test.go:32
        	Error:      	"{
        	            	  "Version": "2008-10-17",
        	            	  "Statement": [
        	            	    {
        	            	      "Effect": "Allow",
        	            	      "Action": [
        	            	        "ec2:AssociateDhcpOptions",
        	            	        "ec2:AssociateIamInstanceProfile",
        	            	        "ec2:AssociateRouteTable",
        	            	        "ec2:AttachInternetGateway",
        	            	        "ec2:AttachVolume",
        	            	        "ec2:AuthorizeSecurityGroupEgress",
        	            	        "ec2:AuthorizeSecurityGroupIngress",
        	            	        "ec2:CancelSpotInstanceRequests",
        	            	        "ec2:CreateDhcpOptions",
        	            	        "ec2:CreateInternetGateway",
        	            	        "ec2:CreateKeyPair",
        	            	        "ec2:CreateRoute",
        	            	        "ec2:CreateSecurityGroup",
        	            	        "ec2:CreateSubnet",
        	            	        "ec2:CreateTags",
        	            	        "ec2:CreateVolume",
        	            	        "ec2:CreateVpc",
        	            	        "ec2:DeleteInternetGateway",
        	            	        "ec2:DeleteKeyPair",
        	            	        "ec2:DeleteRoute",
        	            	        "ec2:DeleteRouteTable",
        	            	        "ec2:DeleteSecurityGroup",
        	            	        "ec2:DeleteSubnet",
        	            	        "ec2:DeleteTags",
        	            	        "ec2:DeleteVolume",
        	            	        "ec2:DeleteVpc",
        	            	        "ec2:DescribeAvailabilityZones",
        	            	        "ec2:DescribeNetworkAcls",
        	            	        "ec2:DescribeInternetGateways",
        	            	        "ec2:DescribeVpcAttribute",
        	            	        "ec2:DescribeIamInstanceProfileAssociations",
        	            	        "ec2:DescribeInstanceStatus",
        	            	        "ec2:DescribeInstances",
        	            	        "ec2:DescribePrefixLists",
        	            	        "ec2:DescribeReservedInstancesOfferings",
        	            	        "ec2:DescribeRouteTables",
        	            	        "ec2:DescribeSecurityGroups",
        	            	        "ec2:DescribeSpotInstanceRequests",
        	            	        "ec2:DescribeSpotPriceHistory",
        	            	        "ec2:DescribeSubnets",
        	            	        "ec2:DescribeVolumes",
        	            	        "ec2:DescribeVpcs",
        	            	        "ec2:DetachInternetGateway",
        	            	        "ec2:DisassociateIamInstanceProfile",
        	            	        "ec2:ModifyVpcAttribute",
        	            	        "ec2:ReplaceIamInstanceProfileAssociation",
        	            	        "ec2:RequestSpotInstances",
        	            	        "ec2:RevokeSecurityGroupEgress",
        	            	        "ec2:RevokeSecurityGroupIngress",
        	            	        "ec2:RunInstances",
        	            	        "ec2:TerminateInstances",
        	            	        "ec2:CreatePlacementGroup",
        	            	        "ec2:DeletePlacementGroup",
        	            	        "ec2:DescribePlacementGroups",
        	            	        "ec2:AllocateAddress",
        	            	        "ec2:CreateNatGateway",
        	            	        "ec2:CreateRouteTable",
        	            	        "ec2:CreateVpcEndpoint",
        	            	        "ec2:DeleteDhcpOptions",
        	            	        "ec2:DeleteNatGateway",
        	            	        "ec2:DeleteVpcEndpoints",
        	            	        "ec2:DescribeNatGateways",
        	            	        "ec2:DisassociateRouteTable",
        	            	        "ec2:ReleaseAddress"
        	            	      ],
        	            	      "Resource": "*"
        	            	    },
        	            	    {
        	            	      "Effect": "Allow",
        	            	      "Action": [
        	            	        "iam:CreateServiceLinkedRole",
        	            	        "iam:PutRolePolicy"
        	            	      ],
        	            	      "Resource": "arn:aws:iam::*:role/aws-service-role/spot.amazonaws.com/AWSServiceRoleForEC2Spot",
        	            	      "Condition": {
        	            	        "StringLike": {
        	            	          "iam:AWSServiceName": "spot.amazonaws.com"
        	            	        }
        	            	      }
        	            	    },
        	            	    {
        	            	      "Effect": "Allow",
        	            	      "Action": "iam:PassRole",
        	            	      "Resource": [
        	            	        "a",
        	            	        "b",
        	            	        "c"
        	            	      ]
        	            	    }
        	            	  ]
        	            	}" should have 2537 item(s), but has 2867
        	Test:       	TestDataAwsCrossAccountRolicy_WithPassRoles
        	Messages:   	Strange length for policy: {
        	            	  "Version": "2008-10-17",
        	            	  "Statement": [
        	            	    {
        	            	      "Effect": "Allow",
        	            	      "Action": [
        	            	        "ec2:AssociateDhcpOptions",
        	            	        "ec2:AssociateIamInstanceProfile",
        	            	        "ec2:AssociateRouteTable",
        	            	        "ec2:AttachInternetGateway",
        	            	        "ec2:AttachVolume",
        	            	        "ec2:AuthorizeSecurityGroupEgress",
        	            	        "ec2:AuthorizeSecurityGroupIngress",
        	            	        "ec2:CancelSpotInstanceRequests",
        	            	        "ec2:CreateDhcpOptions",
        	            	        "ec2:CreateInternetGateway",
        	            	        "ec2:CreateKeyPair",
        	            	        "ec2:CreateRoute",
        	            	        "ec2:CreateSecurityGroup",
        	            	        "ec2:CreateSubnet",
        	            	        "ec2:CreateTags",
        	            	        "ec2:CreateVolume",
        	            	        "ec2:CreateVpc",
        	            	        "ec2:DeleteInternetGateway",
        	            	        "ec2:DeleteKeyPair",
        	            	        "ec2:DeleteRoute",
        	            	        "ec2:DeleteRouteTable",
        	            	        "ec2:DeleteSecurityGroup",
        	            	        "ec2:DeleteSubnet",
        	            	        "ec2:DeleteTags",
        	            	        "ec2:DeleteVolume",
        	            	        "ec2:DeleteVpc",
        	            	        "ec2:DescribeAvailabilityZones",
        	            	        "ec2:DescribeNetworkAcls",
        	            	        "ec2:DescribeInternetGateways",
        	            	        "ec2:DescribeVpcAttribute",
        	            	        "ec2:DescribeIamInstanceProfileAssociations",
        	            	        "ec2:DescribeInstanceStatus",
        	            	        "ec2:DescribeInstances",
        	            	        "ec2:DescribePrefixLists",
        	            	        "ec2:DescribeReservedInstancesOfferings",
        	            	        "ec2:DescribeRouteTables",
        	            	        "ec2:DescribeSecurityGroups",
        	            	        "ec2:DescribeSpotInstanceRequests",
        	            	        "ec2:DescribeSpotPriceHistory",
        	            	        "ec2:DescribeSubnets",
        	            	        "ec2:DescribeVolumes",
        	            	        "ec2:DescribeVpcs",
        	            	        "ec2:DetachInternetGateway",
        	            	        "ec2:DisassociateIamInstanceProfile",
        	            	        "ec2:ModifyVpcAttribute",
        	            	        "ec2:ReplaceIamInstanceProfileAssociation",
        	            	        "ec2:RequestSpotInstances",
        	            	        "ec2:RevokeSecurityGroupEgress",
        	            	        "ec2:RevokeSecurityGroupIngress",
        	            	        "ec2:RunInstances",
        	            	        "ec2:TerminateInstances",
        	            	        "ec2:CreatePlacementGroup",
        	            	        "ec2:DeletePlacementGroup",
        	            	        "ec2:DescribePlacementGroups",
        	            	        "ec2:AllocateAddress",
        	            	        "ec2:CreateNatGateway",
        	            	        "ec2:CreateRouteTable",
        	            	        "ec2:CreateVpcEndpoint",
        	            	        "ec2:DeleteDhcpOptions",
        	            	        "ec2:DeleteNatGateway",
        	            	        "ec2:DeleteVpcEndpoints",
        	            	        "ec2:DescribeNatGateways",
        	            	        "ec2:DisassociateRouteTable",
        	            	        "ec2:ReleaseAddress"
        	            	      ],
        	            	      "Resource": "*"
        	            	    },
        	            	    {
        	            	      "Effect": "Allow",
        	            	      "Action": [
        	            	        "iam:CreateServiceLinkedRole",
        	            	        "iam:PutRolePolicy"
        	            	      ],
        	            	      "Resource": "arn:aws:iam::*:role/aws-service-role/spot.amazonaws.com/AWSServiceRoleForEC2Spot",
        	            	      "Condition": {
        	            	        "StringLike": {
        	            	          "iam:AWSServiceName": "spot.amazonaws.com"
        	            	        }
        	            	      }
        	            	    },
        	            	    {
        	            	      "Effect": "Allow",
        	            	      "Action": "iam:PassRole",
        	            	      "Resource": [
        	            	        "a",
        	            	        "b",
        	            	        "c"
        	            	      ]
        	            	    }
        	            	  ]
        	            	}
--- FAIL: TestDataAwsCrossAccountRolicy_WithPassRoles (0.00s)
✖  access (135ms) (coverage: 83.5% of statements)
✓  common (60ms) (coverage: 68.2% of statements)
✓  compute/acceptance (21ms)
✓  compute (673ms) (coverage: 68.6% of statements)
✓  identity (118ms) (coverage: 42.4% of statements)
✓  identity/acceptance (22ms)
✓  internal (10ms) (coverage: 67.5% of statements)
∅  internal/acceptance
✓  internal/qa (9ms) (coverage: 54.3% of statements)
✓  internal/sanity (21ms) (coverage: 100.0% of statements)
✓  mws/acceptance (14ms)
✓  mws (1.076s) (coverage: 70.5% of statements)
✓  provider (119ms) (coverage: 63.4% of statements)
✓  storage (117ms) (coverage: 73.5% of statements)
✓  storage/acceptance (38ms)
✓  workspace/acceptance (15ms)
✓  workspace (10.074s) (coverage: 62.9% of statements)

=== Failed
=== FAIL: access TestDataAwsCrossAccountRolicy (0.01s)
    data_aws_policies_test.go:19: 
        	Error Trace:	data_aws_policies_test.go:19
        	Error:      	"{
        	            	  "Version": "2008-10-17",
        	            	  "Statement": [
        	            	    {
        	            	      "Effect": "Allow",
        	            	      "Action": [
        	            	        "ec2:AssociateDhcpOptions",
        	            	        "ec2:AssociateIamInstanceProfile",
        	            	        "ec2:AssociateRouteTable",
        	            	        "ec2:AttachInternetGateway",
        	            	        "ec2:AttachVolume",
        	            	        "ec2:AuthorizeSecurityGroupEgress",
        	            	        "ec2:AuthorizeSecurityGroupIngress",
        	            	        "ec2:CancelSpotInstanceRequests",
        	            	        "ec2:CreateDhcpOptions",
        	            	        "ec2:CreateInternetGateway",
        	            	        "ec2:CreateKeyPair",
        	            	        "ec2:CreateRoute",
        	            	        "ec2:CreateSecurityGroup",
        	            	        "ec2:CreateSubnet",
        	            	        "ec2:CreateTags",
        	            	        "ec2:CreateVolume",
        	            	        "ec2:CreateVpc",
        	            	        "ec2:DeleteInternetGateway",
        	            	        "ec2:DeleteKeyPair",
        	            	        "ec2:DeleteRoute",
        	            	        "ec2:DeleteRouteTable",
        	            	        "ec2:DeleteSecurityGroup",
        	            	        "ec2:DeleteSubnet",
        	            	        "ec2:DeleteTags",
        	            	        "ec2:DeleteVolume",
        	            	        "ec2:DeleteVpc",
        	            	        "ec2:DescribeAvailabilityZones",
        	            	        "ec2:DescribeNetworkAcls",
        	            	        "ec2:DescribeInternetGateways",
        	            	        "ec2:DescribeVpcAttribute",
        	            	        "ec2:DescribeIamInstanceProfileAssociations",
        	            	        "ec2:DescribeInstanceStatus",
        	            	        "ec2:DescribeInstances",
        	            	        "ec2:DescribePrefixLists",
        	            	        "ec2:DescribeReservedInstancesOfferings",
        	            	        "ec2:DescribeRouteTables",
        	            	        "ec2:DescribeSecurityGroups",
        	            	        "ec2:DescribeSpotInstanceRequests",
        	            	        "ec2:DescribeSpotPriceHistory",
        	            	        "ec2:DescribeSubnets",
        	            	        "ec2:DescribeVolumes",
        	            	        "ec2:DescribeVpcs",
        	            	        "ec2:DetachInternetGateway",
        	            	        "ec2:DisassociateIamInstanceProfile",
        	            	        "ec2:ModifyVpcAttribute",
        	            	        "ec2:ReplaceIamInstanceProfileAssociation",
        	            	        "ec2:RequestSpotInstances",
        	            	        "ec2:RevokeSecurityGroupEgress",
        	            	        "ec2:RevokeSecurityGroupIngress",
        	            	        "ec2:RunInstances",
        	            	        "ec2:TerminateInstances",
        	            	        "ec2:CreatePlacementGroup",
        	            	        "ec2:DeletePlacementGroup",
        	            	        "ec2:DescribePlacementGroups",
        	            	        "ec2:AllocateAddress",
        	            	        "ec2:CreateNatGateway",
        	            	        "ec2:CreateRouteTable",
        	            	        "ec2:CreateVpcEndpoint",
        	            	        "ec2:DeleteDhcpOptions",
        	            	        "ec2:DeleteNatGateway",
        	            	        "ec2:DeleteVpcEndpoints",
        	            	        "ec2:DescribeNatGateways",
        	            	        "ec2:DisassociateRouteTable",
        	            	        "ec2:ReleaseAddress"
        	            	      ],
        	            	      "Resource": "*"
        	            	    },
        	            	    {
        	            	      "Effect": "Allow",
        	            	      "Action": [
        	            	        "iam:CreateServiceLinkedRole",
        	            	        "iam:PutRolePolicy"
        	            	      ],
        	            	      "Resource": "arn:aws:iam::*:role/aws-service-role/spot.amazonaws.com/AWSServiceRoleForEC2Spot",
        	            	      "Condition": {
        	            	        "StringLike": {
        	            	          "iam:AWSServiceName": "spot.amazonaws.com"
        	            	        }
        	            	      }
        	            	    }
        	            	  ]
        	            	}" should have 2401 item(s), but has 2731
        	Test:       	TestDataAwsCrossAccountRolicy
        	Messages:   	Strange length for policy: {
        	            	  "Version": "2008-10-17",
        	            	  "Statement": [
        	            	    {
        	            	      "Effect": "Allow",
        	            	      "Action": [
        	            	        "ec2:AssociateDhcpOptions",
        	            	        "ec2:AssociateIamInstanceProfile",
        	            	        "ec2:AssociateRouteTable",
        	            	        "ec2:AttachInternetGateway",
        	            	        "ec2:AttachVolume",
        	            	        "ec2:AuthorizeSecurityGroupEgress",
        	            	        "ec2:AuthorizeSecurityGroupIngress",
        	            	        "ec2:CancelSpotInstanceRequests",
        	            	        "ec2:CreateDhcpOptions",
        	            	        "ec2:CreateInternetGateway",
        	            	        "ec2:CreateKeyPair",
        	            	        "ec2:CreateRoute",
        	            	        "ec2:CreateSecurityGroup",
        	            	        "ec2:CreateSubnet",
        	            	        "ec2:CreateTags",
        	            	        "ec2:CreateVolume",
        	            	        "ec2:CreateVpc",
        	            	        "ec2:DeleteInternetGateway",
        	            	        "ec2:DeleteKeyPair",
        	            	        "ec2:DeleteRoute",
        	            	        "ec2:DeleteRouteTable",
        	            	        "ec2:DeleteSecurityGroup",
        	            	        "ec2:DeleteSubnet",
        	            	        "ec2:DeleteTags",
        	            	        "ec2:DeleteVolume",
        	            	        "ec2:DeleteVpc",
        	            	        "ec2:DescribeAvailabilityZones",
        	            	        "ec2:DescribeNetworkAcls",
        	            	        "ec2:DescribeInternetGateways",
        	            	        "ec2:DescribeVpcAttribute",
        	            	        "ec2:DescribeIamInstanceProfileAssociations",
        	            	        "ec2:DescribeInstanceStatus",
        	            	        "ec2:DescribeInstances",
        	            	        "ec2:DescribePrefixLists",
        	            	        "ec2:DescribeReservedInstancesOfferings",
        	            	        "ec2:DescribeRouteTables",
        	            	        "ec2:DescribeSecurityGroups",
        	            	        "ec2:DescribeSpotInstanceRequests",
        	            	        "ec2:DescribeSpotPriceHistory",
        	            	        "ec2:DescribeSubnets",
        	            	        "ec2:DescribeVolumes",
        	            	        "ec2:DescribeVpcs",
        	            	        "ec2:DetachInternetGateway",
        	            	        "ec2:DisassociateIamInstanceProfile",
        	            	        "ec2:ModifyVpcAttribute",
        	            	        "ec2:ReplaceIamInstanceProfileAssociation",
        	            	        "ec2:RequestSpotInstances",
        	            	        "ec2:RevokeSecurityGroupEgress",
        	            	        "ec2:RevokeSecurityGroupIngress",
        	            	        "ec2:RunInstances",
        	            	        "ec2:TerminateInstances",
        	            	        "ec2:CreatePlacementGroup",
        	            	        "ec2:DeletePlacementGroup",
        	            	        "ec2:DescribePlacementGroups",
        	            	        "ec2:AllocateAddress",
        	            	        "ec2:CreateNatGateway",
        	            	        "ec2:CreateRouteTable",
        	            	        "ec2:CreateVpcEndpoint",
        	            	        "ec2:DeleteDhcpOptions",
        	            	        "ec2:DeleteNatGateway",
        	            	        "ec2:DeleteVpcEndpoints",
        	            	        "ec2:DescribeNatGateways",
        	            	        "ec2:DisassociateRouteTable",
        	            	        "ec2:ReleaseAddress"
        	            	      ],
        	            	      "Resource": "*"
        	            	    },
        	            	    {
        	            	      "Effect": "Allow",
        	            	      "Action": [
        	            	        "iam:CreateServiceLinkedRole",
        	            	        "iam:PutRolePolicy"
        	            	      ],
        	            	      "Resource": "arn:aws:iam::*:role/aws-service-role/spot.amazonaws.com/AWSServiceRoleForEC2Spot",
        	            	      "Condition": {
        	            	        "StringLike": {
        	            	          "iam:AWSServiceName": "spot.amazonaws.com"
        	            	        }
        	            	      }
        	            	    }
        	            	  ]
        	            	}

=== FAIL: access TestDataAwsCrossAccountRolicy_WithPassRoles (0.00s)
    data_aws_policies_test.go:32: 
        	Error Trace:	data_aws_policies_test.go:32
        	Error:      	"{
        	            	  "Version": "2008-10-17",
        	            	  "Statement": [
        	            	    {
        	            	      "Effect": "Allow",
        	            	      "Action": [
        	            	        "ec2:AssociateDhcpOptions",
        	            	        "ec2:AssociateIamInstanceProfile",
        	            	        "ec2:AssociateRouteTable",
        	            	        "ec2:AttachInternetGateway",
        	            	        "ec2:AttachVolume",
        	            	        "ec2:AuthorizeSecurityGroupEgress",
        	            	        "ec2:AuthorizeSecurityGroupIngress",
        	            	        "ec2:CancelSpotInstanceRequests",
        	            	        "ec2:CreateDhcpOptions",
        	            	        "ec2:CreateInternetGateway",
        	            	        "ec2:CreateKeyPair",
        	            	        "ec2:CreateRoute",
        	            	        "ec2:CreateSecurityGroup",
        	            	        "ec2:CreateSubnet",
        	            	        "ec2:CreateTags",
        	            	        "ec2:CreateVolume",
        	            	        "ec2:CreateVpc",
        	            	        "ec2:DeleteInternetGateway",
        	            	        "ec2:DeleteKeyPair",
        	            	        "ec2:DeleteRoute",
        	            	        "ec2:DeleteRouteTable",
        	            	        "ec2:DeleteSecurityGroup",
        	            	        "ec2:DeleteSubnet",
        	            	        "ec2:DeleteTags",
        	            	        "ec2:DeleteVolume",
        	            	        "ec2:DeleteVpc",
        	            	        "ec2:DescribeAvailabilityZones",
        	            	        "ec2:DescribeNetworkAcls",
        	            	        "ec2:DescribeInternetGateways",
        	            	        "ec2:DescribeVpcAttribute",
        	            	        "ec2:DescribeIamInstanceProfileAssociations",
        	            	        "ec2:DescribeInstanceStatus",
        	            	        "ec2:DescribeInstances",
        	            	        "ec2:DescribePrefixLists",
        	            	        "ec2:DescribeReservedInstancesOfferings",
        	            	        "ec2:DescribeRouteTables",
        	            	        "ec2:DescribeSecurityGroups",
        	            	        "ec2:DescribeSpotInstanceRequests",
        	            	        "ec2:DescribeSpotPriceHistory",
        	            	        "ec2:DescribeSubnets",
        	            	        "ec2:DescribeVolumes",
        	            	        "ec2:DescribeVpcs",
        	            	        "ec2:DetachInternetGateway",
        	            	        "ec2:DisassociateIamInstanceProfile",
        	            	        "ec2:ModifyVpcAttribute",
        	            	        "ec2:ReplaceIamInstanceProfileAssociation",
        	            	        "ec2:RequestSpotInstances",
        	            	        "ec2:RevokeSecurityGroupEgress",
        	            	        "ec2:RevokeSecurityGroupIngress",
        	            	        "ec2:RunInstances",
        	            	        "ec2:TerminateInstances",
        	            	        "ec2:CreatePlacementGroup",
        	            	        "ec2:DeletePlacementGroup",
        	            	        "ec2:DescribePlacementGroups",
        	            	        "ec2:AllocateAddress",
        	            	        "ec2:CreateNatGateway",
        	            	        "ec2:CreateRouteTable",
        	            	        "ec2:CreateVpcEndpoint",
        	            	        "ec2:DeleteDhcpOptions",
        	            	        "ec2:DeleteNatGateway",
        	            	        "ec2:DeleteVpcEndpoints",
        	            	        "ec2:DescribeNatGateways",
        	            	        "ec2:DisassociateRouteTable",
        	            	        "ec2:ReleaseAddress"
        	            	      ],
        	            	      "Resource": "*"
        	            	    },
        	            	    {
        	            	      "Effect": "Allow",
        	            	      "Action": [
        	            	        "iam:CreateServiceLinkedRole",
        	            	        "iam:PutRolePolicy"
        	            	      ],
        	            	      "Resource": "arn:aws:iam::*:role/aws-service-role/spot.amazonaws.com/AWSServiceRoleForEC2Spot",
        	            	      "Condition": {
        	            	        "StringLike": {
        	            	          "iam:AWSServiceName": "spot.amazonaws.com"
        	            	        }
        	            	      }
        	            	    },
        	            	    {
        	            	      "Effect": "Allow",
        	            	      "Action": "iam:PassRole",
        	            	      "Resource": [
        	            	        "a",
        	            	        "b",
        	            	        "c"
        	            	      ]
        	            	    }
        	            	  ]
        	            	}" should have 2537 item(s), but has 2867
        	Test:       	TestDataAwsCrossAccountRolicy_WithPassRoles
        	Messages:   	Strange length for policy: {
        	            	  "Version": "2008-10-17",
        	            	  "Statement": [
        	            	    {
        	            	      "Effect": "Allow",
        	            	      "Action": [
        	            	        "ec2:AssociateDhcpOptions",
        	            	        "ec2:AssociateIamInstanceProfile",
        	            	        "ec2:AssociateRouteTable",
        	            	        "ec2:AttachInternetGateway",
        	            	        "ec2:AttachVolume",
        	            	        "ec2:AuthorizeSecurityGroupEgress",
        	            	        "ec2:AuthorizeSecurityGroupIngress",
        	            	        "ec2:CancelSpotInstanceRequests",
        	            	        "ec2:CreateDhcpOptions",
        	            	        "ec2:CreateInternetGateway",
        	            	        "ec2:CreateKeyPair",
        	            	        "ec2:CreateRoute",
        	            	        "ec2:CreateSecurityGroup",
        	            	        "ec2:CreateSubnet",
        	            	        "ec2:CreateTags",
        	            	        "ec2:CreateVolume",
        	            	        "ec2:CreateVpc",
        	            	        "ec2:DeleteInternetGateway",
        	            	        "ec2:DeleteKeyPair",
        	            	        "ec2:DeleteRoute",
        	            	        "ec2:DeleteRouteTable",
        	            	        "ec2:DeleteSecurityGroup",
        	            	        "ec2:DeleteSubnet",
        	            	        "ec2:DeleteTags",
        	            	        "ec2:DeleteVolume",
        	            	        "ec2:DeleteVpc",
        	            	        "ec2:DescribeAvailabilityZones",
        	            	        "ec2:DescribeNetworkAcls",
        	            	        "ec2:DescribeInternetGateways",
        	            	        "ec2:DescribeVpcAttribute",
        	            	        "ec2:DescribeIamInstanceProfileAssociations",
        	            	        "ec2:DescribeInstanceStatus",
        	            	        "ec2:DescribeInstances",
        	            	        "ec2:DescribePrefixLists",
        	            	        "ec2:DescribeReservedInstancesOfferings",
        	            	        "ec2:DescribeRouteTables",
        	            	        "ec2:DescribeSecurityGroups",
        	            	        "ec2:DescribeSpotInstanceRequests",
        	            	        "ec2:DescribeSpotPriceHistory",
        	            	        "ec2:DescribeSubnets",
        	            	        "ec2:DescribeVolumes",
        	            	        "ec2:DescribeVpcs",
        	            	        "ec2:DetachInternetGateway",
        	            	        "ec2:DisassociateIamInstanceProfile",
        	            	        "ec2:ModifyVpcAttribute",
        	            	        "ec2:ReplaceIamInstanceProfileAssociation",
        	            	        "ec2:RequestSpotInstances",
        	            	        "ec2:RevokeSecurityGroupEgress",
        	            	        "ec2:RevokeSecurityGroupIngress",
        	            	        "ec2:RunInstances",
        	            	        "ec2:TerminateInstances",
        	            	        "ec2:CreatePlacementGroup",
        	            	        "ec2:DeletePlacementGroup",
        	            	        "ec2:DescribePlacementGroups",
        	            	        "ec2:AllocateAddress",
        	            	        "ec2:CreateNatGateway",
        	            	        "ec2:CreateRouteTable",
        	            	        "ec2:CreateVpcEndpoint",
        	            	        "ec2:DeleteDhcpOptions",
        	            	        "ec2:DeleteNatGateway",
        	            	        "ec2:DeleteVpcEndpoints",
        	            	        "ec2:DescribeNatGateways",
        	            	        "ec2:DisassociateRouteTable",
        	            	        "ec2:ReleaseAddress"
        	            	      ],
        	            	      "Resource": "*"
        	            	    },
        	            	    {
        	            	      "Effect": "Allow",
        	            	      "Action": [
        	            	        "iam:CreateServiceLinkedRole",
        	            	        "iam:PutRolePolicy"
        	            	      ],
        	            	      "Resource": "arn:aws:iam::*:role/aws-service-role/spot.amazonaws.com/AWSServiceRoleForEC2Spot",
        	            	      "Condition": {
        	            	        "StringLike": {
        	            	          "iam:AWSServiceName": "spot.amazonaws.com"
        	            	        }
        	            	      }
        	            	    },
        	            	    {
        	            	      "Effect": "Allow",
        	            	      "Action": "iam:PassRole",
        	            	      "Resource": [
        	            	        "a",
        	            	        "b",
        	            	        "c"
        	            	      ]
        	            	    }
        	            	  ]
        	            	}


DONE 552 tests, 66 skipped, 2 failures in 75.630s
Makefile:14: recipe for target 'test' failed
make: *** [test] Error 1

real	1m15.637s
user	1m51.719s
sys	0m12.391s
The command "time make test" exited with 2.
$ time make build
✓ Building source code with go build...

real	0m3.337s
user	0m3.554s
sys	0m0.430s
The command "time make build" exited with 0.
store build cache
changes detected (content changed, file is created, or file is deleted):\n/home/travis/.cache/go-build/00/0008603b55fec659983ba1a944e89e0585ff3812ec4ce7bc8a1c7833988d59da-a
/home/travis/.cache/go-build/00/00239a23c8f1f796acbc9d123aeebf125cbf2a3ce551a996c82916419c3a9a47-a
/home/travis/.cache/go-build/00/0035db352b49e2e57d0027e20dcdbe4a28730484dc668edcdc4d0db981adb9cc-a
/home/travis/.cache/go-build/00/0050b21b7194592b7e4c95e477060edc32214b9a834c113379785fe0235dab35-a
/home/travis/.cache/go-build/00/005616fc12873fc3f681f4c541ea6b1e6365822cafe940fe019021b2853deb0d-a
/home/travis/.cache/go-build/00/00618e5ba338ae26434b6f3f43373315ebe9c156d9f878e458168743fb6779f9-d
/home/travis/.cache/go-build/00/00791c46ae5d7d8fcc17a21f93d56939f110d7dd6a19fe0538302a1a11d5c243-a
/home/travis/.cache/go-build/00/007a9f7cf4b2338a7a0628685c7f736310d7033f1c565e3195684746fb91d6b7-d
/home/travis/.cache/go-build/00/00864763dc7680e59115113022a0f03f7ade7e68618f8a4d1207ad0638babe4c-d
/home/travis/.cache/go-build/00/008dda5d28d9e95da046aea04971baf500f0a455b77ceb23f28ccc7e8428329a-d
/home/trav\n...
changes detected, packing new archive
uploading PR.311/cache--linux-xenial-e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855--go-1.14.x.tgz
cache uploaded


Done. Your build exited with 1.
curl -sSfL https://github.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.25.0 
golangci/golangci-lint info checking GitHub for tag 'v1.25.0'
golangci/golangci-lint info found version: 1.25.0 for v1.25.0/linux/amd64
golangci/golangci-lint info installed /home/travis/gopath/bin/golangci-lint
time make test 
✓ Running tests...
∅  .
✓  access/acceptance (19ms)
=== RUN   TestDataAwsCrossAccountRolicy
    data_aws_policies_test.go:19: 
        	Error Trace:	data_aws_policies_test.go:19
        	Error:      	"{
        	            	  "Version": "2008-10-17",
        	            	  "Statement": [
        	            	    {
        	            	      "Effect": "Allow",
        	            	      "Action": [
        	            	        "ec2:AssociateDhcpOptions",
        	            	        "ec2:AssociateIamInstanceProfile",
        	            	        "ec2:AssociateRouteTable",
        	            	        "ec2:AttachInternetGateway",
        	            	        "ec2:AttachVolume",
        	            	        "ec2:AuthorizeSecurityGroupEgress",
        	            	        "ec2:AuthorizeSecurityGroupIngress",
        	            	        "ec2:CancelSpotInstanceRequests",
        	            	        "ec2:CreateDhcpOptions",
        	            	        "ec2:CreateInternetGateway",
        	            	        "ec2:CreateKeyPair",
        	            	        "ec2:CreateRoute",
        	            	        "ec2:CreateSecurityGroup",
        	            	        "ec2:CreateSubnet",
        	            	        "ec2:CreateTags",
        	            	        "ec2:CreateVolume",
        	            	        "ec2:CreateVpc",
        	            	        "ec2:DeleteInternetGateway",
        	            	        "ec2:DeleteKeyPair",
        	            	        "ec2:DeleteRoute",
        	            	        "ec2:DeleteRouteTable",
        	            	        "ec2:DeleteSecurityGroup",
        	            	        "ec2:DeleteSubnet",
        	            	        "ec2:DeleteTags",
        	            	        "ec2:DeleteVolume",
        	            	        "ec2:DeleteVpc",
        	            	        "ec2:DescribeAvailabilityZones",
        	            	        "ec2:DescribeNetworkAcls",
        	            	        "ec2:DescribeInternetGateways",
        	            	        "ec2:DescribeVpcAttribute",
        	            	        "ec2:DescribeIamInstanceProfileAssociations",
        	            	        "ec2:DescribeInstanceStatus",
        	            	        "ec2:DescribeInstances",
        	            	        "ec2:DescribePrefixLists",
        	            	        "ec2:DescribeReservedInstancesOfferings",
        	            	        "ec2:DescribeRouteTables",
        	            	        "ec2:DescribeSecurityGroups",
        	            	        "ec2:DescribeSpotInstanceRequests",
        	            	        "ec2:DescribeSpotPriceHistory",
        	            	        "ec2:DescribeSubnets",
        	            	        "ec2:DescribeVolumes",
        	            	        "ec2:DescribeVpcs",
        	            	        "ec2:DetachInternetGateway",
        	            	        "ec2:DisassociateIamInstanceProfile",
        	            	        "ec2:ModifyVpcAttribute",
        	            	        "ec2:ReplaceIamInstanceProfileAssociation",
        	            	        "ec2:RequestSpotInstances",
        	            	        "ec2:RevokeSecurityGroupEgress",
        	            	        "ec2:RevokeSecurityGroupIngress",
        	            	        "ec2:RunInstances",
        	            	        "ec2:TerminateInstances",
        	            	        "ec2:CreatePlacementGroup",
        	            	        "ec2:DeletePlacementGroup",
        	            	        "ec2:DescribePlacementGroups",
        	            	        "ec2:AllocateAddress",
        	            	        "ec2:CreateNatGateway",
        	            	        "ec2:CreateRouteTable",
        	            	        "ec2:CreateVpcEndpoint",
        	            	        "ec2:DeleteDhcpOptions",
        	            	        "ec2:DeleteNatGateway",
        	            	        "ec2:DeleteVpcEndpoints",
        	            	        "ec2:DescribeNatGateways",
        	            	        "ec2:DisassociateRouteTable",
        	            	        "ec2:ReleaseAddress"
        	            	      ],
        	            	      "Resource": "*"
        	            	    },
        	            	    {
        	            	      "Effect": "Allow",
        	            	      "Action": [
        	            	        "iam:CreateServiceLinkedRole",
        	            	        "iam:PutRolePolicy"
        	            	      ],
        	            	      "Resource": "arn:aws:iam::*:role/aws-service-role/spot.amazonaws.com/AWSServiceRoleForEC2Spot",
        	            	      "Condition": {
        	            	        "StringLike": {
        	            	          "iam:AWSServiceName": "spot.amazonaws.com"
        	            	        }
        	            	      }
        	            	    }
        	            	  ]
        	            	}" should have 2401 item(s), but has 2731
        	Test:       	TestDataAwsCrossAccountRolicy
        	Messages:   	Strange length for policy: {
        	            	  "Version": "2008-10-17",
        	            	  "Statement": [
        	            	    {
        	            	      "Effect": "Allow",
        	            	      "Action": [
        	            	        "ec2:AssociateDhcpOptions",
        	            	        "ec2:AssociateIamInstanceProfile",
        	            	        "ec2:AssociateRouteTable",
        	            	        "ec2:AttachInternetGateway",
        	            	        "ec2:AttachVolume",
        	            	        "ec2:AuthorizeSecurityGroupEgress",
        	            	        "ec2:AuthorizeSecurityGroupIngress",
        	            	        "ec2:CancelSpotInstanceRequests",
        	            	        "ec2:CreateDhcpOptions",
        	            	        "ec2:CreateInternetGateway",
        	            	        "ec2:CreateKeyPair",
        	            	        "ec2:CreateRoute",
        	            	        "ec2:CreateSecurityGroup",
        	            	        "ec2:CreateSubnet",
        	            	        "ec2:CreateTags",
        	            	        "ec2:CreateVolume",
        	            	        "ec2:CreateVpc",
        	            	        "ec2:DeleteInternetGateway",
        	            	        "ec2:DeleteKeyPair",
        	            	        "ec2:DeleteRoute",
        	            	        "ec2:DeleteRouteTable",
        	            	        "ec2:DeleteSecurityGroup",
        	            	        "ec2:DeleteSubnet",
        	            	        "ec2:DeleteTags",
        	            	        "ec2:DeleteVolume",
        	            	        "ec2:DeleteVpc",
        	            	        "ec2:DescribeAvailabilityZones",
        	            	        "ec2:DescribeNetworkAcls",
        	            	        "ec2:DescribeInternetGateways",
        	            	        "ec2:DescribeVpcAttribute",
        	            	        "ec2:DescribeIamInstanceProfileAssociations",
        	            	        "ec2:DescribeInstanceStatus",
        	            	        "ec2:DescribeInstances",
        	            	        "ec2:DescribePrefixLists",
        	            	        "ec2:DescribeReservedInstancesOfferings",
        	            	        "ec2:DescribeRouteTables",
        	            	        "ec2:DescribeSecurityGroups",
        	            	        "ec2:DescribeSpotInstanceRequests",
        	            	        "ec2:DescribeSpotPriceHistory",
        	            	        "ec2:DescribeSubnets",
        	            	        "ec2:DescribeVolumes",
        	            	        "ec2:DescribeVpcs",
        	            	        "ec2:DetachInternetGateway",
        	            	        "ec2:DisassociateIamInstanceProfile",
        	            	        "ec2:ModifyVpcAttribute",
        	            	        "ec2:ReplaceIamInstanceProfileAssociation",
        	            	        "ec2:RequestSpotInstances",
        	            	        "ec2:RevokeSecurityGroupEgress",
        	            	        "ec2:RevokeSecurityGroupIngress",
        	            	        "ec2:RunInstances",
        	            	        "ec2:TerminateInstances",
        	            	        "ec2:CreatePlacementGroup",
        	            	        "ec2:DeletePlacementGroup",
        	            	        "ec2:DescribePlacementGroups",
        	            	        "ec2:AllocateAddress",
        	            	        "ec2:CreateNatGateway",
        	            	        "ec2:CreateRouteTable",
        	            	        "ec2:CreateVpcEndpoint",
        	            	        "ec2:DeleteDhcpOptions",
        	            	        "ec2:DeleteNatGateway",
        	            	        "ec2:DeleteVpcEndpoints",
        	            	        "ec2:DescribeNatGateways",
        	            	        "ec2:DisassociateRouteTable",
        	            	        "ec2:ReleaseAddress"
        	            	      ],
        	            	      "Resource": "*"
        	            	    },
        	            	    {
        	            	      "Effect": "Allow",
        	            	      "Action": [
        	            	        "iam:CreateServiceLinkedRole",
        	            	        "iam:PutRolePolicy"
        	            	      ],
        	            	      "Resource": "arn:aws:iam::*:role/aws-service-role/spot.amazonaws.com/AWSServiceRoleForEC2Spot",
        	            	      "Condition": {
        	            	        "StringLike": {
        	            	          "iam:AWSServiceName": "spot.amazonaws.com"
        	            	        }
        	            	      }
        	            	    }
        	            	  ]
        	            	}
--- FAIL: TestDataAwsCrossAccountRolicy (0.01s)
=== RUN   TestDataAwsCrossAccountRolicy_WithPassRoles
    data_aws_policies_test.go:32: 
        	Error Trace:	data_aws_policies_test.go:32
        	Error:      	"{
        	            	  "Version": "2008-10-17",
        	            	  "Statement": [
        	            	    {
        	            	      "Effect": "Allow",
        	            	      "Action": [
        	            	        "ec2:AssociateDhcpOptions",
        	            	        "ec2:AssociateIamInstanceProfile",
        	            	        "ec2:AssociateRouteTable",
        	            	        "ec2:AttachInternetGateway",
        	            	        "ec2:AttachVolume",
        	            	        "ec2:AuthorizeSecurityGroupEgress",
        	            	        "ec2:AuthorizeSecurityGroupIngress",
        	            	        "ec2:CancelSpotInstanceRequests",
        	            	        "ec2:CreateDhcpOptions",
        	            	        "ec2:CreateInternetGateway",
        	            	        "ec2:CreateKeyPair",
        	            	        "ec2:CreateRoute",
        	            	        "ec2:CreateSecurityGroup",
        	            	        "ec2:CreateSubnet",
        	            	        "ec2:CreateTags",
        	            	        "ec2:CreateVolume",
        	            	        "ec2:CreateVpc",
        	            	        "ec2:DeleteInternetGateway",
        	            	        "ec2:DeleteKeyPair",
        	            	        "ec2:DeleteRoute",
        	            	        "ec2:DeleteRouteTable",
        	            	        "ec2:DeleteSecurityGroup",
        	            	        "ec2:DeleteSubnet",
        	            	        "ec2:DeleteTags",
        	            	        "ec2:DeleteVolume",
        	            	        "ec2:DeleteVpc",
        	            	        "ec2:DescribeAvailabilityZones",
        	            	        "ec2:DescribeNetworkAcls",
        	            	        "ec2:DescribeInternetGateways",
        	            	        "ec2:DescribeVpcAttribute",
        	            	        "ec2:DescribeIamInstanceProfileAssociations",
        	            	        "ec2:DescribeInstanceStatus",
        	            	        "ec2:DescribeInstances",
        	            	        "ec2:DescribePrefixLists",
        	            	        "ec2:DescribeReservedInstancesOfferings",
        	            	        "ec2:DescribeRouteTables",
        	            	        "ec2:DescribeSecurityGroups",
        	            	        "ec2:DescribeSpotInstanceRequests",
        	            	        "ec2:DescribeSpotPriceHistory",
        	            	        "ec2:DescribeSubnets",
        	            	        "ec2:DescribeVolumes",
        	            	        "ec2:DescribeVpcs",
        	            	        "ec2:DetachInternetGateway",
        	            	        "ec2:DisassociateIamInstanceProfile",
        	            	        "ec2:ModifyVpcAttribute",
        	            	        "ec2:ReplaceIamInstanceProfileAssociation",
        	            	        "ec2:RequestSpotInstances",
        	            	        "ec2:RevokeSecurityGroupEgress",
        	            	        "ec2:RevokeSecurityGroupIngress",
        	            	        "ec2:RunInstances",
        	            	        "ec2:TerminateInstances",
        	            	        "ec2:CreatePlacementGroup",
        	            	        "ec2:DeletePlacementGroup",
        	            	        "ec2:DescribePlacementGroups",
        	            	        "ec2:AllocateAddress",
        	            	        "ec2:CreateNatGateway",
        	            	        "ec2:CreateRouteTable",
        	            	        "ec2:CreateVpcEndpoint",
        	            	        "ec2:DeleteDhcpOptions",
        	            	        "ec2:DeleteNatGateway",
        	            	        "ec2:DeleteVpcEndpoints",
        	            	        "ec2:DescribeNatGateways",
        	            	        "ec2:DisassociateRouteTable",
        	            	        "ec2:ReleaseAddress"
        	            	      ],
        	            	      "Resource": "*"
        	            	    },
        	            	    {
        	            	      "Effect": "Allow",
        	            	      "Action": [
        	            	        "iam:CreateServiceLinkedRole",
        	            	        "iam:PutRolePolicy"
        	            	      ],
        	            	      "Resource": "arn:aws:iam::*:role/aws-service-role/spot.amazonaws.com/AWSServiceRoleForEC2Spot",
        	            	      "Condition": {
        	            	        "StringLike": {
        	            	          "iam:AWSServiceName": "spot.amazonaws.com"
        	            	        }
        	            	      }
        	            	    },
        	            	    {
        	            	      "Effect": "Allow",
        	            	      "Action": "iam:PassRole",
        	            	      "Resource": [
        	            	        "a",
        	            	        "b",
        	            	        "c"
        	            	      ]
        	            	    }
        	            	  ]
        	            	}" should have 2537 item(s), but has 2867
        	Test:       	TestDataAwsCrossAccountRolicy_WithPassRoles
        	Messages:   	Strange length for policy: {
        	            	  "Version": "2008-10-17",
        	            	  "Statement": [
        	            	    {
        	            	      "Effect": "Allow",
        	            	      "Action": [
        	            	        "ec2:AssociateDhcpOptions",
        	            	        "ec2:AssociateIamInstanceProfile",
        	            	        "ec2:AssociateRouteTable",
        	            	        "ec2:AttachInternetGateway",
        	            	        "ec2:AttachVolume",
        	            	        "ec2:AuthorizeSecurityGroupEgress",
        	            	        "ec2:AuthorizeSecurityGroupIngress",
        	            	        "ec2:CancelSpotInstanceRequests",
        	            	        "ec2:CreateDhcpOptions",
        	            	        "ec2:CreateInternetGateway",
        	            	        "ec2:CreateKeyPair",
        	            	        "ec2:CreateRoute",
        	            	        "ec2:CreateSecurityGroup",
        	            	        "ec2:CreateSubnet",
        	            	        "ec2:CreateTags",
        	            	        "ec2:CreateVolume",
        	            	        "ec2:CreateVpc",
        	            	        "ec2:DeleteInternetGateway",
        	            	        "ec2:DeleteKeyPair",
        	            	        "ec2:DeleteRoute",
        	            	        "ec2:DeleteRouteTable",
        	            	        "ec2:DeleteSecurityGroup",
        	            	        "ec2:DeleteSubnet",
        	            	        "ec2:DeleteTags",
        	            	        "ec2:DeleteVolume",
        	            	        "ec2:DeleteVpc",
        	            	        "ec2:DescribeAvailabilityZones",
        	            	        "ec2:DescribeNetworkAcls",
        	            	        "ec2:DescribeInternetGateways",
        	            	        "ec2:DescribeVpcAttribute",
        	            	        "ec2:DescribeIamInstanceProfileAssociations",
        	            	        "ec2:DescribeInstanceStatus",
        	            	        "ec2:DescribeInstances",
        	            	        "ec2:DescribePrefixLists",
        	            	        "ec2:DescribeReservedInstancesOfferings",
        	            	        "ec2:DescribeRouteTables",
        	            	        "ec2:DescribeSecurityGroups",
        	            	        "ec2:DescribeSpotInstanceRequests",
        	            	        "ec2:DescribeSpotPriceHistory",
        	            	        "ec2:DescribeSubnets",
        	            	        "ec2:DescribeVolumes",
        	            	        "ec2:DescribeVpcs",
        	            	        "ec2:DetachInternetGateway",
        	            	        "ec2:DisassociateIamInstanceProfile",
        	            	        "ec2:ModifyVpcAttribute",
        	            	        "ec2:ReplaceIamInstanceProfileAssociation",
        	            	        "ec2:RequestSpotInstances",
        	            	        "ec2:RevokeSecurityGroupEgress",
        	            	        "ec2:RevokeSecurityGroupIngress",
        	            	        "ec2:RunInstances",
        	            	        "ec2:TerminateInstances",
        	            	        "ec2:CreatePlacementGroup",
        	            	        "ec2:DeletePlacementGroup",
        	            	        "ec2:DescribePlacementGroups",
        	            	        "ec2:AllocateAddress",
        	            	        "ec2:CreateNatGateway",
        	            	        "ec2:CreateRouteTable",
        	            	        "ec2:CreateVpcEndpoint",
        	            	        "ec2:DeleteDhcpOptions",
        	            	        "ec2:DeleteNatGateway",
        	            	        "ec2:DeleteVpcEndpoints",
        	            	        "ec2:DescribeNatGateways",
        	            	        "ec2:DisassociateRouteTable",
        	            	        "ec2:ReleaseAddress"
        	            	      ],
        	            	      "Resource": "*"
        	            	    },
        	            	    {
        	            	      "Effect": "Allow",
        	            	      "Action": [
        	            	        "iam:CreateServiceLinkedRole",
        	            	        "iam:PutRolePolicy"
        	            	      ],
        	            	      "Resource": "arn:aws:iam::*:role/aws-service-role/spot.amazonaws.com/AWSServiceRoleForEC2Spot",
        	            	      "Condition": {
        	            	        "StringLike": {
        	            	          "iam:AWSServiceName": "spot.amazonaws.com"
        	            	        }
        	            	      }
        	            	    },
        	            	    {
        	            	      "Effect": "Allow",
        	            	      "Action": "iam:PassRole",
        	            	      "Resource": [
        	            	        "a",
        	            	        "b",
        	            	        "c"
        	            	      ]
        	            	    }
        	            	  ]
        	            	}
--- FAIL: TestDataAwsCrossAccountRolicy_WithPassRoles (0.00s)
✖  access (135ms) (coverage: 83.5% of statements)
✓  common (60ms) (coverage: 68.2% of statements)
✓  compute/acceptance (21ms)
✓  compute (673ms) (coverage: 68.6% of statements)
✓  identity (118ms) (coverage: 42.4% of statements)
✓  identity/acceptance (22ms)
✓  internal (10ms) (coverage: 67.5% of statements)
∅  internal/acceptance
✓  internal/qa (9ms) (coverage: 54.3% of statements)
✓  internal/sanity (21ms) (coverage: 100.0% of statements)
✓  mws/acceptance (14ms)
✓  mws (1.076s) (coverage: 70.5% of statements)
✓  provider (119ms) (coverage: 63.4% of statements)
✓  storage (117ms) (coverage: 73.5% of statements)
✓  storage/acceptance (38ms)
✓  workspace/acceptance (15ms)
✓  workspace (10.074s) (coverage: 62.9% of statements)

=== Failed
=== FAIL: access TestDataAwsCrossAccountRolicy (0.01s)
    data_aws_policies_test.go:19: 
        	Error Trace:	data_aws_policies_test.go:19
        	Error:      	"{
        	            	  "Version": "2008-10-17",
        	            	  "Statement": [
        	            	    {
        	            	      "Effect": "Allow",
        	            	      "Action": [
        	            	        "ec2:AssociateDhcpOptions",
        	            	        "ec2:AssociateIamInstanceProfile",
        	            	        "ec2:AssociateRouteTable",
        	            	        "ec2:AttachInternetGateway",
        	            	        "ec2:AttachVolume",
        	            	        "ec2:AuthorizeSecurityGroupEgress",
        	            	        "ec2:AuthorizeSecurityGroupIngress",
        	            	        "ec2:CancelSpotInstanceRequests",
        	            	        "ec2:CreateDhcpOptions",
        	            	        "ec2:CreateInternetGateway",
        	            	        "ec2:CreateKeyPair",
        	            	        "ec2:CreateRoute",
        	            	        "ec2:CreateSecurityGroup",
        	            	        "ec2:CreateSubnet",
        	            	        "ec2:CreateTags",
        	            	        "ec2:CreateVolume",
        	            	        "ec2:CreateVpc",
        	            	        "ec2:DeleteInternetGateway",
        	            	        "ec2:DeleteKeyPair",
        	            	        "ec2:DeleteRoute",
        	            	        "ec2:DeleteRouteTable",
        	            	        "ec2:DeleteSecurityGroup",
        	            	        "ec2:DeleteSubnet",
        	            	        "ec2:DeleteTags",
        	            	        "ec2:DeleteVolume",
        	            	        "ec2:DeleteVpc",
        	            	        "ec2:DescribeAvailabilityZones",
        	            	        "ec2:DescribeNetworkAcls",
        	            	        "ec2:DescribeInternetGateways",
        	            	        "ec2:DescribeVpcAttribute",
        	            	        "ec2:DescribeIamInstanceProfileAssociations",
        	            	        "ec2:DescribeInstanceStatus",
        	            	        "ec2:DescribeInstances",
        	            	        "ec2:DescribePrefixLists",
        	            	        "ec2:DescribeReservedInstancesOfferings",
        	            	        "ec2:DescribeRouteTables",
        	            	        "ec2:DescribeSecurityGroups",
        	            	        "ec2:DescribeSpotInstanceRequests",
        	            	        "ec2:DescribeSpotPriceHistory",
        	            	        "ec2:DescribeSubnets",
        	            	        "ec2:DescribeVolumes",
        	            	        "ec2:DescribeVpcs",
        	            	        "ec2:DetachInternetGateway",
        	            	        "ec2:DisassociateIamInstanceProfile",
        	            	        "ec2:ModifyVpcAttribute",
        	            	        "ec2:ReplaceIamInstanceProfileAssociation",
        	            	        "ec2:RequestSpotInstances",
        	            	        "ec2:RevokeSecurityGroupEgress",
        	            	        "ec2:RevokeSecurityGroupIngress",
        	            	        "ec2:RunInstances",
        	            	        "ec2:TerminateInstances",
        	            	        "ec2:CreatePlacementGroup",
        	            	        "ec2:DeletePlacementGroup",
        	            	        "ec2:DescribePlacementGroups",
        	            	        "ec2:AllocateAddress",
        	            	        "ec2:CreateNatGateway",
        	            	        "ec2:CreateRouteTable",
        	            	        "ec2:CreateVpcEndpoint",
        	            	        "ec2:DeleteDhcpOptions",
        	            	        "ec2:DeleteNatGateway",
        	            	        "ec2:DeleteVpcEndpoints",
        	            	        "ec2:DescribeNatGateways",
        	            	        "ec2:DisassociateRouteTable",
        	            	        "ec2:ReleaseAddress"
        	            	      ],
        	            	      "Resource": "*"
        	            	    },
        	            	    {
        	            	      "Effect": "Allow",
        	            	      "Action": [
        	            	        "iam:CreateServiceLinkedRole",
        	            	        "iam:PutRolePolicy"
        	            	      ],
        	            	      "Resource": "arn:aws:iam::*:role/aws-service-role/spot.amazonaws.com/AWSServiceRoleForEC2Spot",
        	            	      "Condition": {
        	            	        "StringLike": {
        	            	          "iam:AWSServiceName": "spot.amazonaws.com"
        	            	        }
        	            	      }
        	            	    }
        	            	  ]
        	            	}" should have 2401 item(s), but has 2731
        	Test:       	TestDataAwsCrossAccountRolicy
        	Messages:   	Strange length for policy: {
        	            	  "Version": "2008-10-17",
        	            	  "Statement": [
        	            	    {
        	            	      "Effect": "Allow",
        	            	      "Action": [
        	            	        "ec2:AssociateDhcpOptions",
        	            	        "ec2:AssociateIamInstanceProfile",
        	            	        "ec2:AssociateRouteTable",
        	            	        "ec2:AttachInternetGateway",
        	            	        "ec2:AttachVolume",
        	            	        "ec2:AuthorizeSecurityGroupEgress",
        	            	        "ec2:AuthorizeSecurityGroupIngress",
        	            	        "ec2:CancelSpotInstanceRequests",
        	            	        "ec2:CreateDhcpOptions",
        	            	        "ec2:CreateInternetGateway",
        	            	        "ec2:CreateKeyPair",
        	            	        "ec2:CreateRoute",
        	            	        "ec2:CreateSecurityGroup",
        	            	        "ec2:CreateSubnet",
        	            	        "ec2:CreateTags",
        	            	        "ec2:CreateVolume",
        	            	        "ec2:CreateVpc",
        	            	        "ec2:DeleteInternetGateway",
        	            	        "ec2:DeleteKeyPair",
        	            	        "ec2:DeleteRoute",
        	            	        "ec2:DeleteRouteTable",
        	            	        "ec2:DeleteSecurityGroup",
        	            	        "ec2:DeleteSubnet",
        	            	        "ec2:DeleteTags",
        	            	        "ec2:DeleteVolume",
        	            	        "ec2:DeleteVpc",
        	            	        "ec2:DescribeAvailabilityZones",
        	            	        "ec2:DescribeNetworkAcls",
        	            	        "ec2:DescribeInternetGateways",
        	            	        "ec2:DescribeVpcAttribute",
        	            	        "ec2:DescribeIamInstanceProfileAssociations",
        	            	        "ec2:DescribeInstanceStatus",
        	            	        "ec2:DescribeInstances",
        	            	        "ec2:DescribePrefixLists",
        	            	        "ec2:DescribeReservedInstancesOfferings",
        	            	        "ec2:DescribeRouteTables",
        	            	        "ec2:DescribeSecurityGroups",
        	            	        "ec2:DescribeSpotInstanceRequests",
        	            	        "ec2:DescribeSpotPriceHistory",
        	            	        "ec2:DescribeSubnets",
        	            	        "ec2:DescribeVolumes",
        	            	        "ec2:DescribeVpcs",
        	            	        "ec2:DetachInternetGateway",
        	            	        "ec2:DisassociateIamInstanceProfile",
        	            	        "ec2:ModifyVpcAttribute",
        	            	        "ec2:ReplaceIamInstanceProfileAssociation",
        	            	        "ec2:RequestSpotInstances",
        	            	        "ec2:RevokeSecurityGroupEgress",
        	            	        "ec2:RevokeSecurityGroupIngress",
        	            	        "ec2:RunInstances",
        	            	        "ec2:TerminateInstances",
        	            	        "ec2:CreatePlacementGroup",
        	            	        "ec2:DeletePlacementGroup",
        	            	        "ec2:DescribePlacementGroups",
        	            	        "ec2:AllocateAddress",
        	            	        "ec2:CreateNatGateway",
        	            	        "ec2:CreateRouteTable",
        	            	        "ec2:CreateVpcEndpoint",
        	            	        "ec2:DeleteDhcpOptions",
        	            	        "ec2:DeleteNatGateway",
        	            	        "ec2:DeleteVpcEndpoints",
        	            	        "ec2:DescribeNatGateways",
        	            	        "ec2:DisassociateRouteTable",
        	            	        "ec2:ReleaseAddress"
        	            	      ],
        	            	      "Resource": "*"
        	            	    },
        	            	    {
        	            	      "Effect": "Allow",
        	            	      "Action": [
        	            	        "iam:CreateServiceLinkedRole",
        	            	        "iam:PutRolePolicy"
        	            	      ],
        	            	      "Resource": "arn:aws:iam::*:role/aws-service-role/spot.amazonaws.com/AWSServiceRoleForEC2Spot",
        	            	      "Condition": {
        	            	        "StringLike": {
        	            	          "iam:AWSServiceName": "spot.amazonaws.com"
        	            	        }
        	            	      }
        	            	    }
        	            	  ]
        	            	}

=== FAIL: access TestDataAwsCrossAccountRolicy_WithPassRoles (0.00s)
    data_aws_policies_test.go:32: 
        	Error Trace:	data_aws_policies_test.go:32
        	Error:      	"{
        	            	  "Version": "2008-10-17",
        	            	  "Statement": [
        	            	    {
        	            	      "Effect": "Allow",
        	            	      "Action": [
        	            	        "ec2:AssociateDhcpOptions",
        	            	        "ec2:AssociateIamInstanceProfile",
        	            	        "ec2:AssociateRouteTable",
        	            	        "ec2:AttachInternetGateway",
        	            	        "ec2:AttachVolume",
        	            	        "ec2:AuthorizeSecurityGroupEgress",
        	            	        "ec2:AuthorizeSecurityGroupIngress",
        	            	        "ec2:CancelSpotInstanceRequests",
        	            	        "ec2:CreateDhcpOptions",
        	            	        "ec2:CreateInternetGateway",
        	            	        "ec2:CreateKeyPair",
        	            	        "ec2:CreateRoute",
        	            	        "ec2:CreateSecurityGroup",
        	            	        "ec2:CreateSubnet",
        	            	        "ec2:CreateTags",
        	            	        "ec2:CreateVolume",
        	            	        "ec2:CreateVpc",
        	            	        "ec2:DeleteInternetGateway",
        	            	        "ec2:DeleteKeyPair",
        	            	        "ec2:DeleteRoute",
        	            	        "ec2:DeleteRouteTable",
        	            	        "ec2:DeleteSecurityGroup",
        	            	        "ec2:DeleteSubnet",
        	            	        "ec2:DeleteTags",
        	            	        "ec2:DeleteVolume",
        	            	        "ec2:DeleteVpc",
        	            	        "ec2:DescribeAvailabilityZones",
        	            	        "ec2:DescribeNetworkAcls",
        	            	        "ec2:DescribeInternetGateways",
        	            	        "ec2:DescribeVpcAttribute",
        	            	        "ec2:DescribeIamInstanceProfileAssociations",
        	            	        "ec2:DescribeInstanceStatus",
        	            	        "ec2:DescribeInstances",
        	            	        "ec2:DescribePrefixLists",
        	            	        "ec2:DescribeReservedInstancesOfferings",
        	            	        "ec2:DescribeRouteTables",
        	            	        "ec2:DescribeSecurityGroups",
        	            	        "ec2:DescribeSpotInstanceRequests",
        	            	        "ec2:DescribeSpotPriceHistory",
        	            	        "ec2:DescribeSubnets",
        	            	        "ec2:DescribeVolumes",
        	            	        "ec2:DescribeVpcs",
        	            	        "ec2:DetachInternetGateway",
        	            	        "ec2:DisassociateIamInstanceProfile",
        	            	        "ec2:ModifyVpcAttribute",
        	            	        "ec2:ReplaceIamInstanceProfileAssociation",
        	            	        "ec2:RequestSpotInstances",
        	            	        "ec2:RevokeSecurityGroupEgress",
        	            	        "ec2:RevokeSecurityGroupIngress",
        	            	        "ec2:RunInstances",
        	            	        "ec2:TerminateInstances",
        	            	        "ec2:CreatePlacementGroup",
        	            	        "ec2:DeletePlacementGroup",
        	            	        "ec2:DescribePlacementGroups",
        	            	        "ec2:AllocateAddress",
        	            	        "ec2:CreateNatGateway",
        	            	        "ec2:CreateRouteTable",
        	            	        "ec2:CreateVpcEndpoint",
        	            	        "ec2:DeleteDhcpOptions",
        	            	        "ec2:DeleteNatGateway",
        	            	        "ec2:DeleteVpcEndpoints",
        	            	        "ec2:DescribeNatGateways",
        	            	        "ec2:DisassociateRouteTable",
        	            	        "ec2:ReleaseAddress"
        	            	      ],
        	            	      "Resource": "*"
        	            	    },
        	            	    {
        	            	      "Effect": "Allow",
        	            	      "Action": [
        	            	        "iam:CreateServiceLinkedRole",
        	            	        "iam:PutRolePolicy"
        	            	      ],
        	            	      "Resource": "arn:aws:iam::*:role/aws-service-role/spot.amazonaws.com/AWSServiceRoleForEC2Spot",
        	            	      "Condition": {
        	            	        "StringLike": {
        	            	          "iam:AWSServiceName": "spot.amazonaws.com"
        	            	        }
        	            	      }
        	            	    },
        	            	    {
        	            	      "Effect": "Allow",
        	            	      "Action": "iam:PassRole",
        	            	      "Resource": [
        	            	        "a",
        	            	        "b",
        	            	        "c"
        	            	      ]
        	            	    }
        	            	  ]
        	            	}" should have 2537 item(s), but has 2867
        	Test:       	TestDataAwsCrossAccountRolicy_WithPassRoles
        	Messages:   	Strange length for policy: {
        	            	  "Version": "2008-10-17",
        	            	  "Statement": [
        	            	    {
        	            	      "Effect": "Allow",
        	            	      "Action": [
        	            	        "ec2:AssociateDhcpOptions",
        	            	        "ec2:AssociateIamInstanceProfile",
        	            	        "ec2:AssociateRouteTable",
        	            	        "ec2:AttachInternetGateway",
        	            	        "ec2:AttachVolume",
        	            	        "ec2:AuthorizeSecurityGroupEgress",
        	            	        "ec2:AuthorizeSecurityGroupIngress",
        	            	        "ec2:CancelSpotInstanceRequests",
        	            	        "ec2:CreateDhcpOptions",
        	            	        "ec2:CreateInternetGateway",
        	            	        "ec2:CreateKeyPair",
        	            	        "ec2:CreateRoute",
        	            	        "ec2:CreateSecurityGroup",
        	            	        "ec2:CreateSubnet",
        	            	        "ec2:CreateTags",
        	            	        "ec2:CreateVolume",
        	            	        "ec2:CreateVpc",
        	            	        "ec2:DeleteInternetGateway",
        	            	        "ec2:DeleteKeyPair",
        	            	        "ec2:DeleteRoute",
        	            	        "ec2:DeleteRouteTable",
        	            	        "ec2:DeleteSecurityGroup",
        	            	        "ec2:DeleteSubnet",
        	            	        "ec2:DeleteTags",
        	            	        "ec2:DeleteVolume",
        	            	        "ec2:DeleteVpc",
        	            	        "ec2:DescribeAvailabilityZones",
        	            	        "ec2:DescribeNetworkAcls",
        	            	        "ec2:DescribeInternetGateways",
        	            	        "ec2:DescribeVpcAttribute",
        	            	        "ec2:DescribeIamInstanceProfileAssociations",
        	            	        "ec2:DescribeInstanceStatus",
        	            	        "ec2:DescribeInstances",
        	            	        "ec2:DescribePrefixLists",
        	            	        "ec2:DescribeReservedInstancesOfferings",
        	            	        "ec2:DescribeRouteTables",
        	            	        "ec2:DescribeSecurityGroups",
        	            	        "ec2:DescribeSpotInstanceRequests",
        	            	        "ec2:DescribeSpotPriceHistory",
        	            	        "ec2:DescribeSubnets",
        	            	        "ec2:DescribeVolumes",
        	            	        "ec2:DescribeVpcs",
        	            	        "ec2:DetachInternetGateway",
        	            	        "ec2:DisassociateIamInstanceProfile",
        	            	        "ec2:ModifyVpcAttribute",
        	            	        "ec2:ReplaceIamInstanceProfileAssociation",
        	            	        "ec2:RequestSpotInstances",
        	            	        "ec2:RevokeSecurityGroupEgress",
        	            	        "ec2:RevokeSecurityGroupIngress",
        	            	        "ec2:RunInstances",
        	            	        "ec2:TerminateInstances",
        	            	        "ec2:CreatePlacementGroup",
        	            	        "ec2:DeletePlacementGroup",
        	            	        "ec2:DescribePlacementGroups",
        	            	        "ec2:AllocateAddress",
        	            	        "ec2:CreateNatGateway",
        	            	        "ec2:CreateRouteTable",
        	            	        "ec2:CreateVpcEndpoint",
        	            	        "ec2:DeleteDhcpOptions",
        	            	        "ec2:DeleteNatGateway",
        	            	        "ec2:DeleteVpcEndpoints",
        	            	        "ec2:DescribeNatGateways",
        	            	        "ec2:DisassociateRouteTable",
        	            	        "ec2:ReleaseAddress"
        	            	      ],
        	            	      "Resource": "*"
        	            	    },
        	            	    {
        	            	      "Effect": "Allow",
        	            	      "Action": [
        	            	        "iam:CreateServiceLinkedRole",
        	            	        "iam:PutRolePolicy"
        	            	      ],
        	            	      "Resource": "arn:aws:iam::*:role/aws-service-role/spot.amazonaws.com/AWSServiceRoleForEC2Spot",
        	            	      "Condition": {
        	            	        "StringLike": {
        	            	          "iam:AWSServiceName": "spot.amazonaws.com"
        	            	        }
        	            	      }
        	            	    },
        	            	    {
        	            	      "Effect": "Allow",
        	            	      "Action": "iam:PassRole",
        	            	      "Resource": [
        	            	        "a",
        	            	        "b",
        	            	        "c"
        	            	      ]
        	            	    }
        	            	  ]
        	            	}


DONE 552 tests, 66 skipped, 2 failures in 75.630s
Makefile:14: recipe for target 'test' failed
make: *** [test] Error 1

real	1m15.637s
user	1m51.719s
sys	0m12.391s
TravisBuddy Request Identifier: a701e140-f346-11ea-addc-35ae975c2fab

@TravisBuddy
Copy link

Hey @stikkireddy,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 3dcd0530-f349-11ea-addc-35ae975c2fab

@codecov-commenter
Copy link

codecov-commenter commented Sep 10, 2020 •
edited
Loading

Codecov Report

Merging #311 into master will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #311      +/-   ##
==========================================
+ Coverage   64.13%   64.18%   +0.05%     
==========================================
  Files          55       55              
  Lines        6730     6741      +11     
==========================================
+ Hits         4316     4327      +11     
  Misses       2044     2044              
  Partials      370      370
Impacted Files Coverage Δ
access/data_aws_policies.go 96.15% <100.00%> (+0.29%) ⬆️

@nfx nfx merged commit 5f882dd into master Sep 10, 2020
@nfx nfx deleted the patch-data-cross-acct-iam-role-1 branch September 10, 2020 09:41
@nfx nfx mentioned this pull request Sep 10, 2020
Closed
@nfx nfx linked an issue Sep 10, 2020 that may be closed by this pull request
[ISSUE] Modifications to data source: databricks_aws_crossaccount_policy may be required. #287
Closed
@nfx nfx mentioned this pull request Sep 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nfx nfx nfx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ISSUE] Modifications to data source: databricks_aws_crossaccount_policy may be required.
4 participants
@stikkireddy @nfx @TravisBuddy @codecov-commenter