Add warehouse_type parameter to sql_endpoint to support DBSQL PRO SKU
#1728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexott
force-pushed
the
sql-warehouse-new-fields
branch
from
7b1ff43
to
9c1008c
Compare
binfeng-db
reviewed
Nov 4, 2022
nfx
approved these changes
Nov 4, 2022
alexott
force-pushed
the
sql-warehouse-new-fields
branch
from
9c1008c
to
3ce49e2
Compare
alexott
changed the title
sql_endpoint: warehouse type & disable UCwarehouse_type parameter to sql_endpoint to support PRO SKU
alexott
changed the title
warehouse_type parameter to sql_endpoint to support PRO SKUwarehouse_type parameter to sql_endpoint to support DBSQL PRO SKU
|
@nfx I reworked the change according to decision by dev team |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1728 +/- ##
=======================================
Coverage 90.00% 90.00%
=======================================
Files 141 141
Lines 11096 11098 +2
=======================================
+ Hits 9987 9989 +2
Misses 707 707
Partials 402 402
|
binfeng-db
approved these changes
Nov 4, 2022
| @@ -39,6 +39,7 @@ The following arguments are supported: | |||
| * `enable_serverless_compute` - Whether this SQL endpoint is a Serverless endpoint. To use a Serverless SQL endpoint, you must enable Serverless SQL endpoints for the workspace. | |||
| * `channel` block, consisting of following fields: | |||
| * `name` - Name of the Databricks SQL release channel. Possible values are: `CHANNEL_NAME_PREVIEW` and `CHANNEL_NAME_CURRENT`. Default is `CHANNEL_NAME_CURRENT`. | |||
| * `warehouse_type` - [SQL Warehouse Type](https://docs.databricks.com/sql/admin/sql-endpoints.html#switch-the-sql-warehouse-type-pro-classic-or-serverless): `PRO` (default) or `CLASSIC`. If Serverless SQL is enabled, you can only specify `PRO`. | |||
There was a problem hiding this comment.
If serverless SQL is enabled, you can only specify PRO.
There was a problem hiding this comment.
we don't know if serverless is enabled or not from the terraform execution, especially for non-admin
|
@carlrabelerDB it was discussed and decided not to do |
Merged
michael-berk
pushed a commit
to michael-berk/terraform-provider-databricks
that referenced
this pull request
Feb 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.