Fix Azure authentication for dev and staging workspaces #1607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfx
requested changes
Sep 16, 2022
mehdikit-db
force-pushed
the
azure-staging-dev
branch
from
021b661
to
a971a23
Compare
use env variable
mehdikit-db
force-pushed
the
azure-staging-dev
branch
from
a971a23
to
429949b
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1607 +/- ##
==========================================
+ Coverage 89.57% 90.05% +0.47%
==========================================
Files 135 135
Lines 10825 10833 +8
==========================================
+ Hits 9697 9756 +59
+ Misses 737 688 -49
+ Partials 391 389 -2
|
nfx
requested changes
Sep 21, 2022
common/azure_auth.go
Outdated
| const azureDatabricksProdLoginAppID string = "2ff814a6-3304-4ab8-85cb-cd0e6f879c1d" | ||
|
|
||
| func (aa *DatabricksClient) GetAzureDatabricksLoginAppId() string { | ||
| res := azureDatabricksProdLoginAppID |
There was a problem hiding this comment.
- make this method "unexported" - make it start with lowecase letter (
getAzure...) strings.Contains(aa.Host, ".staging.")is unnecessary and it leaks internal infra references. simplify it to
if aa.AzureDatabricksLoginAppId != "" {
return aa.AzureDatabricksLoginAppId
}
return azureDatabricksProdLoginAppID
There was a problem hiding this comment.
1 - This method is being used in common/azure_cli_auth.go.
2 - Good point, Fixed it.
nfx
approved these changes
Sep 23, 2022
nkvuong
pushed a commit
that referenced
this pull request
Oct 6, 2022
* Fix Azure authentication for dev and staging workspaces * use env variable * Fix client attributes tests * Rename AzureDatabricksResourceId to AzureDatabricksLoginAppId * Simplify GetAzureDatabricksLoginAppId
nkvuong
pushed a commit
that referenced
this pull request
Oct 7, 2022
author Serge Smertin <259697+nfx@users.noreply.github.com> 1664570116 -0700 committer Vuong Nguyen <vuong.nguyen@databricks.com> 1665140905 +0100 parent 06af47b author Serge Smertin <259697+nfx@users.noreply.github.com> 1664570116 -0700 committer Vuong Nguyen <vuong.nguyen@databricks.com> 1665140865 +0100 parent 06af47b author Serge Smertin <259697+nfx@users.noreply.github.com> 1664570116 -0700 committer Vuong Nguyen <vuong.nguyen@databricks.com> 1665140826 +0100 parent 06af47b author Serge Smertin <259697+nfx@users.noreply.github.com> 1664570116 -0700 committer Vuong Nguyen <vuong.nguyen@databricks.com> 1665140786 +0100 Release 1.4.0 (#1650) remove databricks_table resource from doc fix following suggestions update docs to match new privilege model Fix dashboard acceptance test (#1618) DBSQL resources are organized in a workspace structure as of recently. As such it is no longer possible to use the same name for different assets. This acceptance test used to use the same name for both the dashboard and the query and started failing. The solution here is to use a different suffix for the different resources. Fix unity catalog docs to use correct metastore (#1620) aws_iam_policy.unity_metastore is referencing aws_s3_bucket.unity_metastore.arn, which is non-existent. Fix to use aws_s3_bucket.metastore.arn instead. This also matches with the online tutorial. https://docs.databricks.com/data-governance/unity-catalog/automate.html fix `secret` field name in `databricks_mlflow_webhook` resource (#1625) fixes #1621 Fixed `gcp_availability` field in `databricks_insance_pool` resource (#1610) Co-authored-by: Alex Ott <alexey.ott@databricks.com> Add autoscale `mode` configuration to `databricks_pipeline` resource (#1600) Fix Azure authentication for dev and staging workspaces (#1607) * Fix Azure authentication for dev and staging workspaces * use env variable * Fix client attributes tests * Rename AzureDatabricksResourceId to AzureDatabricksLoginAppId * Simplify GetAzureDatabricksLoginAppId Fixed minor errors in Unity Catalog docs (#1626) * Fixed errors in docs * Fixed Azure SPOT and elastic disk * Added fallback on SPOT_AZURE configuration Bump github.com/hashicorp/hcl/v2 from 2.14.0 to 2.14.1 (#1634) Bumps [github.com/hashicorp/hcl/v2](https://github.com/hashicorp/hcl) from 2.14.0 to 2.14.1. - [Release notes](https://github.com/hashicorp/hcl/releases) - [Changelog](https://github.com/hashicorp/hcl/blob/main/CHANGELOG.md) - [Commits](hashicorp/hcl@v2.14.0...v2.14.1) --- updated-dependencies: - dependency-name: github.com/hashicorp/hcl/v2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Bump google.golang.org/api from 0.96.0 to 0.97.0 (#1633) Bumps [google.golang.org/api](https://github.com/googleapis/google-api-go-client) from 0.96.0 to 0.97.0. - [Release notes](https://github.com/googleapis/google-api-go-client/releases) - [Changelog](https://github.com/googleapis/google-api-go-client/blob/main/CHANGES.md) - [Commits](googleapis/google-api-go-client@v0.96.0...v0.97.0) --- updated-dependencies: - dependency-name: google.golang.org/api dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Correct handling of references in `databricks_permissions` resources (#1631) this fixes #1628 expand documentation for `databricks_sql_visualization` resource (#1630) * expand documentation for `options` field in `sql-visualization` resource * add wording for how to restore during issue scenario Prevent stripping of `CAN_MANAGE` permission from caller of `databricks_sql_query` resource (#1644) Make debugging work again (#1560) Fix test for `databricks_job` data source (#1649)
michael-berk
pushed a commit
to michael-berk/terraform-provider-databricks
that referenced
this pull request
Feb 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.