add force_destroy flag to databricks_schema & databricks_catalog
#1578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1578 +/- ##
==========================================
- Coverage 90.15% 90.14% -0.02%
==========================================
Files 132 132
Lines 10629 10655 +26
==========================================
+ Hits 9583 9605 +22
- Misses 667 669 +2
- Partials 379 381 +2
|
nfx
requested changes
Sep 2, 2022
catalog/resource_catalog.go
Outdated
| func (a CatalogsAPI) deleteCatalog(name string) error { | ||
| // TODO: force_destroy attribute | ||
| return a.client.Delete(a.context, "/unity-catalog/catalogs/"+name+"?force=true", nil) | ||
| func (a CatalogsAPI) deleteCatalog(name string, force bool) error { |
There was a problem hiding this comment.
@nkvuong can you create a separate method and call it forceDelete? this will align with future SDK migration
nkvuong
changed the title
force_destroy flag to schema & catalog
nkvuong
changed the title
force_destroy flag to schema & catalogforce_destroy flag to databricks_schema & databricks_catalog
nfx
approved these changes
Sep 2, 2022
Merged
michael-berk
pushed a commit
to michael-berk/terraform-provider-databricks
that referenced
this pull request
Feb 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
force_destroyflag to UC schema & catalog. This achieves the same functionality as thepurgeflag in the cli, which loop through all child schemas & tables and delete them before delete the parent securableCloses #1576