Use resize API to scale running clusters #1541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexott
reviewed
Aug 16, 2022
Codecov Report
@@ Coverage Diff @@
## master #1541 +/- ##
==========================================
- Coverage 90.17% 90.07% -0.10%
==========================================
Files 132 132
Lines 10560 10585 +25
==========================================
+ Hits 9522 9534 +12
- Misses 663 669 +6
- Partials 375 382 +7
|
nfx
requested changes
Aug 17, 2022
… await for resizing clusters)
shreyas-goenka
force-pushed
the
resize-cluster
branch
from
570dd81
to
37144f5
Compare
…tate from PENDING / RESIZING / RESTARTING states
nfx
requested changes
Aug 18, 2022
…d to waitForClusterStatus, now we no longer wait and see whether resize api can be used, only call it if the cluster is in a running state
nfx
requested changes
Aug 22, 2022
|
TODO: Confirm that adding omitempty for num_workers does not cause serialisability issues for single node clusters (ie num_workers = 0) |
shreyas-goenka
changed the title
nfx
requested changes
Aug 22, 2022
nfx
requested changes
Aug 22, 2022
nfx
approved these changes
Aug 24, 2022
Merged
michael-berk
pushed a commit
to michael-berk/terraform-provider-databricks
that referenced
this pull request
Feb 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resize API has the advantage of not restarting the cluster incase of manual scaling (
num_workers) / autoscale parameter change (min_workers,max_workers)Tested using