Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed reads for any_file and anonymous_function in databricks_sql_permissions #1477

Merged
merged 4 commits into from
Jul 20, 2022
Merged

Fixed reads for any_file and anonymous_function in databricks_sql_permissions #1477

merged 4 commits into from
Jul 20, 2022

Conversation

nkvuong
Copy link
Contributor

@nkvuong nkvuong commented Jul 19, 2022

Close #1245

@nkvuong nkvuong requested a review from alexott July 19, 2022 12:14
@codecov-commenter
Copy link

codecov-commenter commented Jul 19, 2022 •
edited
Loading

Codecov Report

Merging #1477 (c3e4cd2) into master (734ef36) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1477   +/-   ##
=======================================
  Coverage   90.11%   90.12%           
=======================================
  Files         126      126           
  Lines       10208    10216    +8     
=======================================
+ Hits         9199     9207    +8     
  Misses        642      642           
  Partials      367      367
Impacted Files Coverage Δ
access/resource_sql_permissions.go 86.04% <100.00%> (+0.53%) ⬆️

nfx
nfx approved these changes Jul 19, 2022
View reviewed changes
Copy link
Contributor

@nfx nfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

alexott
alexott approved these changes Jul 19, 2022
View reviewed changes
Copy link
Contributor

@alexott alexott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nfx nfx changed the title fix reading grants for any file & anon function Fixed reads for any_file and anonymous_function in databricks_sql_permissions Jul 19, 2022
@nfx nfx merged commit c852efd into master Jul 20, 2022
@nfx nfx deleted the fix/any_file_sql_permission branch July 20, 2022 08:26
@nfx nfx mentioned this pull request Jul 21, 2022
Merged
michael-berk pushed a commit to michael-berk/terraform-provider-databricks that referenced this pull request Feb 15, 2023
@nkvuong
Fixed reads for any_file and anonymous_function in `databricks_sq…
5fa1891 
…l_permissions` (databricks#1477)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexott alexott alexott approved these changes

@nfx nfx nfx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ISSUE] databricks_sql_permissions causes perpetual plan changes when using any_file set to true
4 participants
@nkvuong @codecov-commenter @alexott @nfx