Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added databricks_permissions for databricks_pipeline #1361

Merged
merged 1 commit into from
Jun 7, 2022
Merged

Conversation

alexott
Copy link
Contributor

@alexott alexott commented Jun 7, 2022

This fixes #1359

@alexott alexott requested a review from nfx June 7, 2022 10:19
@alexott
Copy link
Contributor Author

alexott commented Jun 7, 2022

oops, one moment - forgot to add docs

@codecov
Copy link

codecov bot commented Jun 7, 2022

Codecov Report

Merging #1361 (a95d762) into master (d15fecb) will decrease coverage by 0.01%.
The diff coverage is 90.00%.

❗ Current head a95d762 differs from pull request most recent head e23b2ac. Consider uploading reports for the commit e23b2ac to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1361      +/-   ##
==========================================
- Coverage   90.11%   90.10%   -0.02%     
==========================================
  Files         122      122              
  Lines       10118    10127       +9     
==========================================
+ Hits         9118     9125       +7     
- Misses        637      638       +1     
- Partials      363      364       +1     
Impacted Files Coverage Δ
permissions/resource_permissions.go 94.00% <80.00%> (-0.71%) ⬇️
pipelines/resource_pipeline.go 92.63% <100.00%> (ø)

Copy link
Contributor

@nfx nfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small changes and checks

docs/resources/permissions.md Outdated Show resolved Hide resolved
docs/resources/permissions.md Outdated Show resolved Hide resolved
permissions/resource_permissions.go Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@alexott alexott changed the title Support permissions for databricks_pipeline Support permissions for databricks_pipeline Jun 7, 2022
@nfx nfx changed the title Support permissions for databricks_pipeline Added databricks_permissions for databricks_pipeline Jun 7, 2022
@nfx nfx merged commit 7bca37b into master Jun 7, 2022
@nfx nfx deleted the dlt-permissions branch June 7, 2022 11:55
nfx added a commit that referenced this pull request Jun 7, 2022
* Added `delta_sharing_*` support to `databricks_metastore` ([#1334](#1334)).
* Added `databricks_git_credentials` pat discovery from common environment variables ([#1353](#1353)).
* Added `databricks_permissions` for `databricks_pipeline` ([#1361](#1361)).
* Added `network_id` to `network` block in `databricks_mws_workspaces` for GCP ([#1360](#1360)).
* Added `azure_managed_identity` block to `databricks_storage_credential` and `databricks_metastore_data_access` resources ([#1354](#1354)).
* Update docs regarding importing of `databricks_sql_*` resources ([#1349](#1349)).
* Apply ownership for UC objects during creation ([#1338](#1338)).
* Re-create purged cluster for `databricks_mount` for Google Storage ([#1333](#1333)).
* Various documentation fixes ([#1350](#1350)).

Updated dependency versions:

* Bump google.golang.org/api from 0.80.0 to 0.81.0
* Bump gopkg.in/ini.v1 from 1.66.4 to 1.66.6
* Bump google.golang.org/api from 0.81.0 to 0.82.0
* Bump github.com/stretchr/testify from 1.7.1 to 1.7.2
* Bump github.com/hashicorp/terraform-plugin-sdk/v2 from 2.16.0 to 2.17.0
@nfx nfx mentioned this pull request Jun 7, 2022
nfx added a commit that referenced this pull request Jun 7, 2022
* Added `delta_sharing_*` support to `databricks_metastore` ([#1334](#1334)).
* Added `databricks_git_credentials` pat discovery from common environment variables ([#1353](#1353)).
* Added `databricks_permissions` for `databricks_pipeline` ([#1361](#1361)).
* Added `network_id` to `network` block in `databricks_mws_workspaces` for GCP ([#1360](#1360)).
* Added `azure_managed_identity` block to `databricks_storage_credential` and `databricks_metastore_data_access` resources ([#1354](#1354)).
* Update docs regarding importing of `databricks_sql_*` resources ([#1349](#1349)).
* Apply ownership for UC objects during creation ([#1338](#1338)).
* Re-create purged cluster for `databricks_mount` for Google Storage ([#1333](#1333)).
* Various documentation fixes ([#1350](#1350)).

Updated dependency versions:

* Bump google.golang.org/api from 0.80.0 to 0.81.0
* Bump gopkg.in/ini.v1 from 1.66.4 to 1.66.6
* Bump google.golang.org/api from 0.81.0 to 0.82.0
* Bump github.com/stretchr/testify from 1.7.1 to 1.7.2
* Bump github.com/hashicorp/terraform-plugin-sdk/v2 from 2.16.0 to 2.17.0
michael-berk pushed a commit to michael-berk/terraform-provider-databricks that referenced this pull request Feb 15, 2023
michael-berk pushed a commit to michael-berk/terraform-provider-databricks that referenced this pull request Feb 15, 2023
* Added `delta_sharing_*` support to `databricks_metastore` ([databricks#1334](databricks#1334)).
* Added `databricks_git_credentials` pat discovery from common environment variables ([databricks#1353](databricks#1353)).
* Added `databricks_permissions` for `databricks_pipeline` ([databricks#1361](databricks#1361)).
* Added `network_id` to `network` block in `databricks_mws_workspaces` for GCP ([databricks#1360](databricks#1360)).
* Added `azure_managed_identity` block to `databricks_storage_credential` and `databricks_metastore_data_access` resources ([databricks#1354](databricks#1354)).
* Update docs regarding importing of `databricks_sql_*` resources ([databricks#1349](databricks#1349)).
* Apply ownership for UC objects during creation ([databricks#1338](databricks#1338)).
* Re-create purged cluster for `databricks_mount` for Google Storage ([databricks#1333](databricks#1333)).
* Various documentation fixes ([databricks#1350](databricks#1350)).

Updated dependency versions:

* Bump google.golang.org/api from 0.80.0 to 0.81.0
* Bump gopkg.in/ini.v1 from 1.66.4 to 1.66.6
* Bump google.golang.org/api from 0.81.0 to 0.82.0
* Bump github.com/stretchr/testify from 1.7.1 to 1.7.2
* Bump github.com/hashicorp/terraform-plugin-sdk/v2 from 2.16.0 to 2.17.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Support permissions for databricks_pipeline
2 participants