Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added exporter for IP Access Lists #1125

Merged
merged 1 commit into from
Feb 16, 2022
Merged

Added exporter for IP Access Lists #1125

merged 1 commit into from
Feb 16, 2022

Conversation

alexott
Copy link
Contributor

@alexott alexott commented Feb 16, 2022

No description provided.

@alexott alexott requested a review from nfx February 16, 2022 15:42
@codecov
Copy link

codecov bot commented Feb 16, 2022

Codecov Report

Merging #1125 (5ff5ae1) into master (c6acf4c) will increase coverage by 0.02%.
The diff coverage is 90.00%.

❗ Current head 5ff5ae1 differs from pull request most recent head 323d169. Consider uploading reports for the commit 323d169 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1125      +/-   ##
==========================================
+ Coverage   91.05%   91.07%   +0.02%     
==========================================
  Files         111      111              
  Lines        9576     9610      +34     
==========================================
+ Hits         8719     8752      +33     
+ Misses        508      507       -1     
- Partials      349      351       +2     
Impacted Files Coverage Δ
exporter/importables.go 97.74% <88.57%> (-0.60%) ⬇️
access/resource_ipaccesslist.go 100.00% <100.00%> (+5.88%) ⬆️
exporter/command.go 85.96% <100.00%> (ø)

Copy link
Contributor

@nfx nfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove custom body for ip acls - we don't need depends_on attribute.

exporter/importables.go Outdated Show resolved Hide resolved
exporter/importables.go Outdated Show resolved Hide resolved
@nfx nfx merged commit 641a3f2 into master Feb 16, 2022
@nfx nfx deleted the ip-access-list-exporter branch February 16, 2022 18:35
@nfx nfx mentioned this pull request Feb 18, 2022
@alexott alexott added the exporter TF configuration generator label Jan 5, 2023
michael-berk pushed a commit to michael-berk/terraform-provider-databricks that referenced this pull request Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exporter TF configuration generator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants