Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix destroy of SQL Global config with instance profile setup #1080

Merged
merged 1 commit into from
Feb 2, 2022
Merged

Conversation

alexott
Copy link
Contributor

@alexott alexott commented Feb 2, 2022

Also added a new parameter sql_config_params

this fixes #1076

@alexott alexott requested a review from nfx February 2, 2022 08:53
@codecov
Copy link

codecov bot commented Feb 2, 2022

Codecov Report

Merging #1080 (dcd97b4) into master (f0b00d8) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1080      +/-   ##
==========================================
- Coverage   90.90%   90.90%   -0.01%     
==========================================
  Files         110      110              
  Lines        9470     9475       +5     
==========================================
+ Hits         8609     8613       +4     
- Misses        511      512       +1     
  Partials      350      350              
Impacted Files Coverage Δ
sqlanalytics/resource_sql_global_config.go 85.18% <100.00%> (+1.51%) ⬆️
sqlanalytics/resource_widget.go 86.76% <0.00%> (-0.74%) ⬇️

Copy link
Contributor

@nfx nfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, please add a changelog entry :)

Also added a new parameter `sql_config_params`

this fixes #1076
@alexott
Copy link
Contributor Author

alexott commented Feb 2, 2022

🤦 done :-)

@nfx nfx merged commit 8640e87 into master Feb 2, 2022
@nfx nfx deleted the issue-1076 branch February 2, 2022 09:46
@nfx nfx mentioned this pull request Feb 3, 2022
100 tasks
michael-berk pushed a commit to michael-berk/terraform-provider-databricks that referenced this pull request Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ISSUE] Unable to delete databricks_sql_global_config resource configured with instance profile
2 participants