Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for release channels configuration for SQL Endpoints #1078

Merged
merged 1 commit into from
Feb 2, 2022
Merged

Add support for release channels configuration for SQL Endpoints #1078

merged 1 commit into from
Feb 2, 2022

Conversation

alexott
Copy link
Contributor

@alexott alexott commented Feb 1, 2022

No description provided.

@alexott alexott requested a review from nfx February 1, 2022 07:44
@alexott
Copy link
Contributor Author

alexott commented Feb 1, 2022

The only one thing could be potentially required - right now, when you change channel, it's applied momentarily, without restart. But I'm not sure that it's correct behavior - checking this with developers

@codecov
Copy link

codecov bot commented Feb 1, 2022 •
edited
Loading

Codecov Report

Merging #1078 (41def1f) into master (8640e87) will increase coverage by 0.03%.
The diff coverage is n/a.

❗ Current head 41def1f differs from pull request most recent head 6a8fcbc. Consider uploading reports for the commit 6a8fcbc to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1078      +/-   ##
==========================================
+ Coverage   90.91%   90.94%   +0.03%     
==========================================
  Files         110      110              
  Lines        9475     9469       -6     
==========================================
- Hits         8614     8612       -2     
+ Misses        511      508       -3     
+ Partials      350      349       -1
Impacted Files Coverage Δ
sqlanalytics/resource_sql_endpoint.go 97.26% <ø> (+4.85%) ⬆️

nfx
nfx reviewed Feb 1, 2022
View reviewed changes
Copy link
Contributor

@nfx nfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a change log entry, otherwise lgtm:)

@alexott
Copy link
Contributor Author

alexott commented Feb 1, 2022

done

nfx
nfx reviewed Feb 1, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@nfx
Copy link
Contributor

nfx commented Feb 1, 2022

there's -0.63% coverage change, even though not directly related to your change. can you also please cover one of the misses to bring coverage back - https://app.codecov.io/gh/databrickslabs/terraform-provider-databricks/blob/master/sqlanalytics/resource_sql_endpoint.go

@alexott alexott force-pushed the sqlendpoint-channels branch 2 times, most recently from 76be8b1 to bb89354 Compare February 1, 2022 11:48
@nfx
Copy link
Contributor

nfx commented Feb 1, 2022

@alexott what about coverage? :)

@alexott
Copy link
Contributor Author

alexott commented Feb 1, 2022

why it decreased at all? Will look later today when get out of meetings

@alexott
Copy link
Contributor Author

alexott commented Feb 1, 2022

ok, it's better now

@nfx nfx merged commit d5015a6 into master Feb 2, 2022
@nfx nfx deleted the sqlendpoint-channels branch February 2, 2022 09:55
@nfx nfx mentioned this pull request Feb 3, 2022
Merged
100 tasks
michael-berk pushed a commit to michael-berk/terraform-provider-databricks that referenced this pull request Feb 15, 2023
@alexott
Add support for release channels configuration for SQL Endpoints (dat…
254f36c 
…abricks#1078)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nfx nfx nfx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexott @nfx