Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow configuring permissions for all MLflow models #1070

Merged
merged 2 commits into from
Jan 28, 2022
Merged

Allow configuring permissions for all MLflow models #1070

merged 2 commits into from
Jan 28, 2022

Conversation

nfx
Copy link
Contributor

@nfx nfx commented Jan 28, 2022

Fixes #1044

@nfx nfx requested a review from alexott January 28, 2022 17:47
@codecov
Copy link

codecov bot commented Jan 28, 2022 •
edited
Loading

Codecov Report

Merging #1070 (45fd9d1) into master (278dde1) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 45fd9d1 differs from pull request most recent head 3196cfa. Consider uploading reports for the commit 3196cfa to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1070   +/-   ##
=======================================
  Coverage   90.85%   90.85%           
=======================================
  Files         110      110           
  Lines        9462     9462           
=======================================
  Hits         8597     8597           
  Misses        513      513           
  Partials      352      352
Impacted Files Coverage Δ
permissions/resource_permissions.go 88.28% <100.00%> (ø)

alexott
alexott approved these changes Jan 28, 2022
View reviewed changes
Copy link
Contributor

@alexott alexott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nfx nfx merged commit 41f4d20 into master Jan 28, 2022
@nfx nfx deleted the issue/1044 branch January 28, 2022 17:59
michael-berk pushed a commit to michael-berk/terraform-provider-databricks that referenced this pull request Feb 15, 2023
@nfx
Allow configuring permissions for all MLflow models (databricks#1070)
d17ff12 
Fixes databricks#1044
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexott alexott alexott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: configure permissions for all MLflow models
2 participants
@nfx @alexott