-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[exporter] interactive cli and notebooks #1010
Conversation
I'm really not sure about interactivity by default... |
@alexott why not interactivity by default? it's too difficult as it is now. breaking change - of course it is, but exporter is experimental, so we can do that. |
I just thought about this PR again. I see two additional issues:
|
4229c73
to
f582a88
Compare
Codecov Report
@@ Coverage Diff @@
## master #1010 +/- ##
==========================================
- Coverage 91.11% 90.83% -0.29%
==========================================
Files 112 113 +1
Lines 9627 9668 +41
==========================================
+ Hits 8772 8782 +10
- Misses 505 523 +18
- Partials 350 363 +13
|
91c8cc6
to
068e9a6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
Exporter has low adoption so far and it's related to the difficulty working with it. it's target use is interactive one-off export of PVC and ST deployments, so admin persona most likely will launch it in interactive mode without any env vars configured upfront. let's cater for this persona to roll out export with minimal SA assistance.