Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter] interactive cli and notebooks #1010

Merged
merged 9 commits into from
Feb 18, 2022
Merged

[exporter] interactive cli and notebooks #1010

merged 9 commits into from
Feb 18, 2022

Conversation

nfx
Copy link
Contributor

@nfx nfx commented Dec 29, 2021

Exporter has low adoption so far and it's related to the difficulty working with it. it's target use is interactive one-off export of PVC and ST deployments, so admin persona most likely will launch it in interactive mode without any env vars configured upfront. let's cater for this persona to roll out export with minimal SA assistance.

asciicast

@nfx nfx requested a review from alexott December 29, 2021 18:46
exporter/importables.go Show resolved Hide resolved
exporter/importables.go Show resolved Hide resolved
@alexott
Copy link
Contributor

alexott commented Dec 30, 2021

I'm really not sure about interactivity by default...

@nfx
Copy link
Contributor Author

nfx commented Dec 30, 2021

@alexott why not interactivity by default? it's too difficult as it is now. breaking change - of course it is, but exporter is experimental, so we can do that.

@nfx nfx added this to the v0.4.4 milestone Dec 30, 2021
@alexott
Copy link
Contributor

alexott commented Jan 5, 2022

I just thought about this PR again. I see two additional issues:

  • Permissions aren't emitted for notebooks
  • We need to export workspace directories as well, and permissions for them. Otherwise, when we import everything back (for example, into new workspace), then permissions for directories will be set to admin

@nfx nfx modified the milestones: v0.4.4, v0.4.5 Jan 5, 2022
@nfx nfx modified the milestones: v0.4.5, v0.4.6 Jan 13, 2022
@nfx nfx modified the milestones: v0.4.6, v0.4.7 Jan 21, 2022
@nfx nfx modified the milestones: v0.4.7, v0.4.8, v0.4.9 Jan 28, 2022
@nfx nfx modified the milestones: v0.4.9, v0.5.0 Feb 11, 2022
@nfx nfx requested a review from pietern February 17, 2022 11:51
@nfx nfx marked this pull request as ready for review February 17, 2022 12:11
@nfx nfx changed the title [wip][exporter] interactive cli and notebooks [exporter] interactive cli and notebooks Feb 17, 2022
@codecov
Copy link

codecov bot commented Feb 17, 2022

Codecov Report

Merging #1010 (8de53e2) into master (d45e827) will decrease coverage by 0.28%.
The diff coverage is 79.43%.

❗ Current head 8de53e2 differs from pull request most recent head bf81f3c. Consider uploading reports for the commit bf81f3c to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1010      +/-   ##
==========================================
- Coverage   91.11%   90.83%   -0.29%     
==========================================
  Files         112      113       +1     
  Lines        9627     9668      +41     
==========================================
+ Hits         8772     8782      +10     
- Misses        505      523      +18     
- Partials      350      363      +13     
Impacted Files Coverage Δ
exporter/model.go 88.88% <ø> (ø)
exporter/command.go 81.33% <68.42%> (-4.64%) ⬇️
exporter/importables.go 94.29% <73.33%> (-3.46%) ⬇️
exporter/ui.go 76.92% <76.92%> (ø)
exporter/context.go 88.36% <90.24%> (+0.19%) ⬆️
common/client.go 99.15% <100.00%> (ø)
exporter/util.go 85.03% <100.00%> (-1.18%) ⬇️
workspace/resource_notebook.go 88.97% <100.00%> (ø)

exporter/command.go Show resolved Hide resolved
docs/guides/experimental-exporter.md Show resolved Hide resolved
exporter/exporter_test.go Outdated Show resolved Hide resolved
exporter/importables.go Outdated Show resolved Hide resolved
exporter/importables.go Outdated Show resolved Hide resolved
exporter/importables.go Outdated Show resolved Hide resolved
Copy link
Contributor

@alexott alexott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@nfx nfx merged commit 1345e03 into master Feb 18, 2022
@nfx nfx deleted the interactive-exporter branch February 18, 2022 15:52
@nfx nfx mentioned this pull request Feb 18, 2022
michael-berk pushed a commit to michael-berk/terraform-provider-databricks that referenced this pull request Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants