Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE] Add arguments for PAS object #590

Closed
renardeinside opened this issue Apr 10, 2021 · 1 comment · Fixed by #604
Closed

[ISSUE] Add arguments for PAS object #590

renardeinside opened this issue Apr 10, 2021 · 1 comment · Fixed by #604

Comments

@renardeinside
Copy link

Hi there,

There is no public_access_enabled argument for databricks_mws_private_access_settings resource. This is a pretty important component for the PrivateLink setup (one of the most important ones).

Following setup won't work:

resource "databricks_mws_private_access_settings" "pas" {
  provider                     = databricks.mws
  account_id                   = var.databricks_account_id
  private_access_settings_name = "Private Access Settings for ${aws_vpc.main.id}"
  region                       = local.region
  public_access_enabled        = true
}

Error log with TF_LOG=DEBUG terraform apply -auto-approve -var-file=.tfvars:

2021-04-10T22:38:07.050+0200 [INFO]  plugin.terraform-provider-aws_v3.36.0_x5: 2021/04/10 22:38:07 [WARN] Truncating attribute path of 0 diagnostics for TypeSet: timestamp=2021-04-10T22:38:07.050+0200
2021-04-10T22:38:07.054+0200 [INFO]  plugin.terraform-provider-aws_v3.36.0_x5: 2021/04/10 22:38:07 [WARN] Truncating attribute path of 0 diagnostics for TypeSet: timestamp=2021-04-10T22:38:07.054+0200
2021-04-10T22:38:07.054+0200 [INFO]  plugin.terraform-provider-aws_v3.36.0_x5: 2021/04/10 22:38:07 [WARN] Truncating attribute path of 0 diagnostics for TypeSet: timestamp=2021-04-10T22:38:07.054+0200
2021-04-10T22:38:07.056+0200 [WARN]  plugin.stdio: received EOF, stopping recv loop: err="rpc error: code = Unavailable desc = transport is closing"
2021-04-10T22:38:07.060+0200 [DEBUG] plugin: plugin process exited: path=.terraform/providers/registry.terraform.io/hashicorp/aws/3.36.0/darwin_amd64/terraform-provider-aws_v3.36.0_x5 pid=8275
2021-04-10T22:38:07.060+0200 [DEBUG] plugin: plugin exited

Error: Unsupported argument

  on main.tf line 332, in resource "databricks_mws_private_access_settings" "pas":
 332:   public_access_enabled        = true

An argument named "public_access_enabled" is not expected here.

2021-04-10T22:38:07.065+0200 [WARN]  plugin.stdio: received EOF, stopping recv loop: err="rpc error: code = Unavailable desc = transport is closing"
2021-04-10T22:38:07.066+0200 [DEBUG] plugin: plugin process exited: path=.terraform/providers/registry.terraform.io/databrickslabs/databricks/0.3.2/darwin_amd64/terraform-provider-databricks_v0.3.2 pid=8274
2021-04-10T22:38:07.066+0200 [DEBUG] plugin: plugin exited
@renardeinside renardeinside changed the title [ISSUE] No [ISSUE] Add arguments for PAS object Apr 10, 2021
@nfx
Copy link
Contributor

nfx commented Apr 10, 2021

@renardeinside this is a simple change - just add new boolean field to the struct and unit test it well. Waiting for your PR :)

nfx added a commit that referenced this issue Apr 22, 2021
@nfx nfx linked a pull request Apr 22, 2021 that will close this issue
@nfx nfx closed this as completed in #604 Apr 22, 2021
nfx added a commit that referenced this issue Apr 22, 2021
michael-berk pushed a commit to michael-berk/terraform-provider-databricks that referenced this issue Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants