handle hex in unicode escapes #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks! |
|
@lihaoyi-databricks Any plans of doing a release that includes this fix? I hit this problem trying to use it with https://github.com/coreos/prometheus-operator (well more specifically https://github.com/coreos/kube-prometheus). I guess I can always build it myself. |
|
I just tried it out and it is 5 times faster than go-jsonnet to build kube-prometheus (not quite the default configuration but close). Down from 11.677s to 2.374s!!! |
|
sure I can publish a release when I get back to my computer later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #37