Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Key functions #40

Merged
merged 18 commits into from
Oct 9, 2019
Merged

Key functions #40

merged 18 commits into from
Oct 9, 2019

Conversation

javaduke
Copy link
Contributor

@javaduke javaduke commented Oct 9, 2019

@lihaoyi-databricks As discussed, this PR fixes the issue #36. I also made a few minor optimizations to the code.

I will have a separate PR which adds regex functions to the sjsonnet but it will require Mill issue #601 fix (which I already have a PR for: com-lihaoyi/mill#706)

@lihaoyi-databricks
Copy link
Contributor

Looks good to me, thanks!

@lihaoyi-databricks lihaoyi-databricks merged commit b277bb6 into databricks:master Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants