Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow adjacent object literals #87

Closed
szeiger opened this issue Aug 24, 2020 · 0 comments · Fixed by #88
Closed

Disallow adjacent object literals #87

szeiger opened this issue Aug 24, 2020 · 0 comments · Fixed by #88
Assignees

Comments

@szeiger
Copy link
Collaborator

szeiger commented Aug 24, 2020

Requested by @iuliand-db:

Forbid syntactic sugar that allows omitting the + to merge to objects when both LHS and RHS are dictionary literals. That’s basically never what you want, and usually indicates a comma between the two literals.

Since Jsonnet allows this, simply making it an error is probably not an option, but we could add a warning or a strict mode (neither of which currently exists in Sjsonnet).

@szeiger szeiger self-assigned this Aug 24, 2020
szeiger added a commit to szeiger/sjsonnet that referenced this issue Aug 25, 2020
This makes adjacent object literals an error. Fixes databricks#87
@szeiger szeiger mentioned this issue Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant