change oauth default scope #776
Merged
+3
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wang-1990
requested review from
andrefurlan-db,
benc-db and
rcypher-databricks
as code owners
benc-db
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #
We have change the default scope for the dbt-databricks app to all-apis, offline_access, we also change the redirect url to https://localhost:8020, https://localhost:8050 in all AWS and GCP and Azure public regions. For Azure GovCloud regions it is still pending.
For Azure in the current python sdk(0.17.0) we will always redirect to Azure endpoint so it does not affect how OAuth U2M works on Azure workspace at all.
This PR remove the hardcoded override for scopes and redirectUrls.
Description
Checklist
CHANGELOG.mdand added information about my change to the "dbt-databricks next" section.