Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(query): Support distributed insert select in new planner. #7527

Merged
merged 13 commits into from
Sep 14, 2022
Merged

feat(query): Support distributed insert select in new planner. #7527

merged 13 commits into from
Sep 14, 2022

Conversation

RinChanNOWWW
Copy link
Contributor

@RinChanNOWWW RinChanNOWWW commented Sep 8, 2022 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Firstly, build the distributed optimized logical select plan into a physical select plan.
And rewrite the physical select plan with an insert-select plan.

Fixes #7501

@vercel
Copy link

vercel bot commented Sep 8, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
databend ⬜️ Ignored (Inspect) Sep 14, 2022 at 2:31AM (UTC)

@RinChanNOWWW RinChanNOWWW changed the title Support distributed insert select in new planner. feat(query): Support distributed insert select in new planner. Sep 8, 2022
@mergify mergify bot added the pr-feature this PR introduces a new feature to the codebase label Sep 8, 2022
@RinChanNOWWW RinChanNOWWW marked this pull request as ready for review September 8, 2022 08:47
@sundy-li
Copy link
Member

sundy-li commented Sep 8, 2022

Need stateless cluster test in exchange.test

@RinChanNOWWW
Copy link
Contributor Author

RinChanNOWWW commented Sep 8, 2022 •
edited
Loading

Need stateless cluster test in exchange.test

I think the tests added in #2945 is enough?

BTW, the pipeline is needed to be modified. It seems that we don't need Exchange. I'll have a try first.

@RinChanNOWWW RinChanNOWWW marked this pull request as draft September 8, 2022 10:28
@RinChanNOWWW RinChanNOWWW marked this pull request as ready for review September 13, 2022 06:43
@RinChanNOWWW
Copy link
Contributor Author

The check task will be fixed in #7577.

@RinChanNOWWW
Copy link
Contributor Author

RinChanNOWWW commented Sep 13, 2022 •
edited
Loading

Data selected from system.one will be duplicated. Trying to fix.

@Xuanwo
Copy link
Member

Xuanwo commented Sep 13, 2022

@RinChanNOWWW Thanks for waiting, #7577 has been merged.

@Xuanwo
Copy link
Member

Xuanwo commented Sep 13, 2022

@mergify update

@mergify
Copy link
Contributor

mergify bot commented Sep 13, 2022

update

✅ Branch has been successfully updated

@RinChanNOWWW
Copy link
Contributor Author

Pipelines for aggregation are also needed to be modified.

@RinChanNOWWW
Copy link
Contributor Author

refactoring some codes, please wait.

@Xuanwo Xuanwo marked this pull request as draft September 13, 2022 12:34
@Xuanwo
Copy link
Member

Xuanwo commented Sep 13, 2022

refactoring some codes, please wait.

Marked this PR as a draft to prevent unintended approvals.

@RinChanNOWWW RinChanNOWWW marked this pull request as ready for review September 13, 2022 13:20
@mergify mergify bot merged commit 0607283 into databendlabs:main Sep 14, 2022
@RinChanNOWWW RinChanNOWWW deleted the distributed_insert branch September 14, 2022 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sundy-li sundy-li sundy-li approved these changes

@zhang2014 zhang2014 zhang2014 approved these changes

@dantengsky dantengsky Awaiting requested review from dantengsky

Assignees
No one assigned
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: distributed insertion in new planner
4 participants
@RinChanNOWWW @sundy-li @Xuanwo @zhang2014