Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(processor): show correctly progress in cluster mode #6253

Merged
merged 9 commits into from
Jul 4, 2022
Merged

fix(processor): show correctly progress in cluster mode #6253

merged 9 commits into from
Jul 4, 2022

Conversation

zhang2014
Copy link
Member

@zhang2014 zhang2014 commented Jun 27, 2022 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

fix(processor): show correctly progress in cluster mode

Changelog

  • Bug Fix

Related Issues

Fixes #6237

@vercel
Copy link

vercel bot commented Jun 27, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
databend ✅ Ready (Inspect) Visit Preview Jul 3, 2022 at 2:09PM (UTC)

@mergify
Copy link
Contributor

mergify bot commented Jun 27, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the pr-bugfix this PR patches a bug in codebase label Jun 27, 2022
@BohuTANG
Copy link
Member

BohuTANG commented Jun 28, 2022 •
edited
Loading

Is this patch also related to #5973?

@mergify

This comment was marked as off-topic.

Sign in to view
@Xuanwo Xuanwo marked this pull request as ready for review June 28, 2022 05:47
@zhang2014
Copy link
Member Author

Is this patch also related to #5973?

unrelated.

@BohuTANG
Copy link
Member

@mergify update

@mergify
Copy link
Contributor

mergify bot commented Jun 28, 2022

update

✅ Branch has been successfully updated

@BohuTANG BohuTANG marked this pull request as draft July 1, 2022 00:54
@BohuTANG
Copy link
Member

BohuTANG commented Jul 1, 2022

I think this PR is not ready for review, so convert it to the draft.

@zhang2014 zhang2014 mentioned this pull request Jul 1, 2022
Closed
@zhang2014 zhang2014 marked this pull request as ready for review July 3, 2022 14:10
@mergify
Copy link
Contributor

mergify bot commented Jul 3, 2022

This pull request's title is not fulfill the requirements. @zhang2014 please update it 🙏.

Valid format:

fix(query): fix group by string bug
  ^--^  ^------------^
  |     |
  |     +-> Summary in present tense.
  |
+-------> Type: feat, fix, refactor, ci, build, docs, website, chore

Valid types:

  • feat: this PR introduces a new feature to the codebase
  • fix: this PR patches a bug in codebase
  • refactor: this PR changes the code base without new features or bugfix
  • ci|build: this PR changes build/testing/ci steps
  • docs|website: this PR changes the documents or websites
  • chore: this PR only has small changes that no need to record

@BohuTANG BohuTANG requested a review from sundy-li July 3, 2022 23:59
@Xuanwo Xuanwo changed the title fixes(processor): show correctly progress in cluster mode fix(processor): show correctly progress in cluster mode Jul 4, 2022
@BohuTANG BohuTANG merged commit 3380242 into databendlabs:main Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sundy-li sundy-li sundy-li approved these changes

Assignees
No one assigned
Labels
need-review pr-bugfix this PR patches a bug in codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: incorrect progress summary in cluster mode
4 participants
@zhang2014 @BohuTANG @sundy-li @databend-bot