-
Notifications
You must be signed in to change notification settings - Fork 735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HEX
, UNHEX
, QUOTE
, LTRIM
, RTRIM
scalar functions.
#3116
Conversation
Thanks for the contribution! Please review the labels and make any necessary changes. |
1 similar comment
Thanks for the contribution! Please review the labels and make any necessary changes. |
Codecov Report
@@ Coverage Diff @@
## main #3116 +/- ##
======================================
- Coverage 68% 67% -1%
======================================
Files 658 667 +9
Lines 34519 34793 +274
======================================
+ Hits 23545 23586 +41
- Misses 10974 11207 +233
Continue to review full report at Codecov.
|
@@ -25,5 +30,10 @@ impl StringFunction { | |||
factory.register("substring", SubstringFunction::desc()); | |||
factory.register("oct", OctFunction::desc()); | |||
factory.register("repeat", RepeatFunction::desc()); | |||
factory.register("ltrim", LTrimFunction::desc()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, I have an idea about these functions.
They have the same return_type and number of arguments and datatypes, the difference between them are X
where string_array.append_option(X)
, so it's better to have a generic function to reduce the code size?
Bumps [tracing-bunyan-formatter](https://github.com/LukeMathWalker/tracing-bunyan-formatter) from 0.3.0 to 0.3.1. - [Release notes](https://github.com/LukeMathWalker/tracing-bunyan-formatter/releases) - [Commits](LukeMathWalker/tracing-bunyan-formatter@v0.3.0...v0.3.1) --- updated-dependencies: - dependency-name: tracing-bunyan-formatter dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
done. 🙂 |
I hereby agree to the terms of the CLA available at: https://databend.rs/policies/cla/
Summary
Add
HEX
,UNHEX
,QUOTE
,LTRIM
,RTRIM
scalar functions.Changelog
Related Issues
fixes #3041 fixes #3036 fixes #3027 fixes #3031 fixes #3073 fixes #3061 fixes #3047
Test Plan
Unit Tests
Stateless Tests