Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: DroppedId for listing db/tables for gc #16542

Merged
merged 1 commit into from
Sep 29, 2024

Conversation

drmingdrmer
Copy link
Member

@drmingdrmer drmingdrmer commented Sep 29, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

refactor: DroppedId for listing db/tables for gc

There is no need to store tables inside DroppedId::Db:
the tables belonging to a DB for gc can still be stored in DroppedId::Table.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Refactoring

Related Issues


This change is Reviewable

@github-actions github-actions bot added the pr-refactor this PR changes the code base without new features or bugfix label Sep 29, 2024
@drmingdrmer drmingdrmer marked this pull request as ready for review September 29, 2024 06:23
There is no need to store tables inside `DroppedId::Db`:
the tables belonging to a DB for gc can still be stored in `DroppedId::Table`.
@SkyFan2002
Copy link
Member

LGTM. Thanks!

@drmingdrmer drmingdrmer merged commit de5a3d6 into databendlabs:main Sep 29, 2024
71 of 72 checks passed
@drmingdrmer drmingdrmer deleted the 149-xx branch September 29, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-refactor this PR changes the code base without new features or bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants