Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use NonEmptyString to access UDFMgr. #14844

Merged
merged 2 commits into from
Mar 5, 2024

Conversation

drmingdrmer
Copy link
Member

@drmingdrmer drmingdrmer commented Mar 5, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

refactor: use NonEmptyString to access UDFMgr.

No need to return TenantIsEmpty error anymore

Changelog

  • Improvement

Related Issues


This change is Reviewable

@github-actions github-actions bot added the pr-refactor this PR changes the code base without new features or bugfix label Mar 5, 2024
@drmingdrmer drmingdrmer marked this pull request as ready for review March 5, 2024 08:48
@drmingdrmer drmingdrmer force-pushed the 25-refactor branch 3 times, most recently from e5122b1 to 3c40953 Compare March 5, 2024 13:19
Copy link
Member

@BohuTANG BohuTANG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

No need to return TenantIsEmpty error anymore
Copy link
Collaborator

@TCeason TCeason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Privilege part LGTM

@BohuTANG BohuTANG merged commit c3c40a2 into databendlabs:main Mar 5, 2024
71 of 72 checks passed
@drmingdrmer drmingdrmer deleted the 25-refactor branch March 5, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-refactor this PR changes the code base without new features or bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants