Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: show create table with location #14778

Merged
merged 1 commit into from
Feb 28, 2024
Merged

chore: show create table with location #14778

merged 1 commit into from
Feb 28, 2024

Conversation

ariesdevil
Copy link
Collaborator

@ariesdevil ariesdevil commented Feb 28, 2024 •
edited by drmingdrmer
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

show create table with location

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Feb 28, 2024
@BohuTANG BohuTANG merged commit 8c13fee into databendlabs:main Feb 28, 2024
70 checks passed
@ariesdevil ariesdevil deleted the show_create_table branch February 28, 2024 14:45
youngsofun
youngsofun reviewed Feb 29, 2024
View reviewed changes
tests/sqllogictests/suites/base/06_show/06_0001_show_create_table.test
query TT
SHOW CREATE TABLE `test`.`d`
----
d CREATE TABLE `d` ( `a` INT NOT NULL ) ENGINE=FUSE CLUSTER BY (a, (a % 3)) COMPRESSION='lz4' STORAGE_FORMAT='parquet' LOCATION = 's3 | bucket=load,root=/files/,endpoint=https://s3.amazonaws.com'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this result sql can not run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youngsofun youngsofun youngsofun left review comments

@BohuTANG BohuTANG BohuTANG approved these changes

Assignees
No one assigned
Labels
pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ariesdevil @BohuTANG @youngsofun