Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Add RoleIdent to define kvapi::Key to access roles in meta-service #14772

Merged
merged 2 commits into from
Feb 28, 2024

Conversation

drmingdrmer
Copy link
Member

@drmingdrmer drmingdrmer commented Feb 28, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

refactor: Add RoleIdent to define kvapi::Key to access roles in meta-service

Add a new trait KeyWithTenant to define behaviors of a kvapi::Key
that contains a Tenant in it. E.g., such a key is able to provide a
key prefix for listing all such keys belonging to a specified tenant.

Changelog

  • Improvement

Related Issues


This change is Reviewable

@github-actions github-actions bot added the pr-refactor this PR changes the code base without new features or bugfix label Feb 28, 2024
@drmingdrmer drmingdrmer force-pushed the 39-role-mgr-key branch 4 times, most recently from 0e708a8 to 980fe4f Compare February 28, 2024 03:11
@drmingdrmer drmingdrmer marked this pull request as ready for review February 28, 2024 03:27
…service

Add a new trait `KeyWithTenant` to define behaviors of a `kvapi::Key`
that contains a `Tenant` in it. E.g., such a key is able to provide a
key prefix for listing all such keys belonging to a specified tenant.

- Fix: databendlabs#14738
@drmingdrmer drmingdrmer merged commit d55904c into databendlabs:main Feb 28, 2024
68 of 71 checks passed
@drmingdrmer drmingdrmer deleted the 39-role-mgr-key branch February 28, 2024 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-refactor this PR changes the code base without new features or bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Define RoleMgr keys with kvapi::Key;
1 participant