refactor: do not upsert copied-files set if both purge and force are enabled #10855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
mergify
bot
added
the
pr-refactor
dantengsky
changed the title
sundy-li
approved these changes
Mar 30, 2023
BohuTANG
reviewed
Mar 30, 2023
youngsofun
reviewed
Mar 30, 2023
|
seems result of https://github.com/datafuselabs/databend/blob/main/tests/suites/1_stateful/00_copy/00_0004_copy_with_max_files.sh should be updated |
thanks for reminding |
youngsofun
reviewed
Mar 30, 2023
rest lgtm as long as the results of this tests is expected |
BohuTANG
approved these changes
Mar 30, 2023
youngsofun
approved these changes
Mar 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/
Summary
during the execution of
copy-into, if both purge and force are enabled, do not upsert the table's copied-files set in meta server.NOTE:
since the table's copied-files set will NOT be upsert in meta service, if both
purgeandforceare enabled.later/parallel executions of
copy-intoare taking the risk of data duplication.Closes #10854