Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update contributing instructions #421

Merged
merged 2 commits into from
Jul 14, 2023
Merged

Conversation

reshamas
Copy link
Contributor

@reshamas reshamas commented Jul 14, 2023

PR Overview

Type of contribution

  • Code
  • Documentation

Reference: Issue or Pull Request (PR)

  • Towards #xxx

Description of Changes

<-- Brief description of the changes you made, files you touched, etc -->

Before and After for UI Updates

<-- You should have 2 images minimum, for desktop, 4 for mobile and desktop combined -->

Before:

After:

For PR Reviewer

  • Does this file change the yarn.lock, package.json or package-lock.json file? If so, why?
  • If this pr contains mobile and desktop changes, did you test on IphoneXr and desktop views?
  • Does this file match the related tickets linked figma file, or does it pass the visual smell test?
  • If this file contains javascript, does the javascript pass the smell test?
  • If you don't feel super confident in your review, did you assign someone more senior to double check?

@reshamas reshamas merged commit a73ffea into data-umbrella:main Jul 14, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant