This repository has been archived by the owner on Feb 10, 2021. It is now read-only.
Allow starting and stopping no workers #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously if `start_workers` was given `n = 0`, it would crash in a cryptic way. This fixes that issue by simply skipping starting any workers if `n = 0`.
jakirkham
commented
Apr 1, 2018
| @@ -198,6 +198,9 @@ def create_job_template(self, **kwargs): | |||
| return jt | |||
|
|
|||
| def start_workers(self, n=1, **kwargs): | |||
| if n == 0: | |||
| return | |||
There was a problem hiding this comment.
Note to self: Might be worth adding a warning as well.
There was a problem hiding this comment.
May revisit this later. For now will leave the warning out.
Previously if `stop_workers` was given `worker_ids = []`, it would crash in a cryptic way. This fixes that issue by simply skipping stopping any workers if `worker_ids = []`.
Now that `stop_workers` guards against closing workers if none are provided, simply always call `stop_workers` in `close`.
jakirkham
force-pushed
the
allow_starting_zero_workers
branch
from
3bbfc14
to
c0fd68d
Compare
jakirkham
changed the title
Add a test to ensure that `start_workers` can be passed `n = 0` without issues. Also ensure this translates into no workers being added. Further test that `stop_workers` can be called with an empty list.
jakirkham
force-pushed
the
allow_starting_zero_workers
branch
from
c0fd68d
to
62b03c0
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes sure that
start_workerscan taken = 0andstop_workerscan takeworker_ids = []. Namely by not starting or stopping any workers. Previously these errored out in a cryptic way. So by simply avoiding erroring out, this is an improvement.