This repository has been archived by the owner on Feb 10, 2021. It is now read-only.
Fix flakiness in test_stop_workers_politely
#49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `test_stop_workers_politely` test has been a bit flaky. Given the test is trying to shutdown a worker and compute results at the same time, this seems like part of the problem. To try and fix this, wait until the worker is shutdown completely before trying to retrieve results. Otherwise it seems to have issues.
|
IDK if this will actually fix the issue and given the test is kind of flaky it is hard to be sure, but this is my best guess on a fix. Would appreciate if someone could review this. |
|
I think this fixes this test issue, but maybe this breaks with the intent of the test. If you could let me know either way @mrocklin, that would be appreciated. |
|
Seems fine to me. If this was breaking then I suspect that it's more dask.distributed's fault than dask-drmaa's |
|
Thanks for checking. Yeah was looking at issue ( dask/distributed#682 ) and wondered if there was a shared underlying cause, but failed to identify it. Maybe you will have a better idea than I. 😉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #42
The
test_stop_workers_politelytest has been a bit flaky. Given the test is trying to shutdown a worker and compute results at the same time, this seems like part of the problem. To try and fix this, wait until the worker is shutdown completely before trying to retrieve results. Otherwise it seems to have issues.