This repository has been archived by the owner on Feb 10, 2021. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 22
Add a basic manifest to aid in packaging #40
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
jakirkham
force-pushed
the
add_manifest
branch
from
November 3, 2017 15:59
c0d2e5e
to
10b14ac
Compare
Make sure the LICENSE and README are included. Also ensure any compiled Python code is not included.
jakirkham
force-pushed
the
add_manifest
branch
from
November 3, 2017 16:08
10b14ac
to
c46f7d5
Compare
Any thoughts on this? |
Fine with me
…On Fri, Nov 3, 2017 at 1:01 PM, jakirkham ***@***.***> wrote:
Any thoughts on this?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#40 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AASszDZW4KKhSYDUWooOhDzkW5n7kfK7ks5sy0bUgaJpZM4QQwD7>
.
|
As an FYI this project is not a high priority for me personally at the
moment, so feedback from me may be brief generally.
On Fri, Nov 3, 2017 at 1:43 PM, Matthew Rocklin <mrocklin@anaconda.com>
wrote:
… Fine with me
On Fri, Nov 3, 2017 at 1:01 PM, jakirkham ***@***.***>
wrote:
> Any thoughts on this?
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <#40 (comment)>, or mute
> the thread
> <https://github.com/notifications/unsubscribe-auth/AASszDZW4KKhSYDUWooOhDzkW5n7kfK7ks5sy0bUgaJpZM4QQwD7>
> .
>
|
Make sense. Is alright if I merge small PRs like this at my own discretion then? |
Definitely :)
…On Fri, Nov 3, 2017 at 1:49 PM, jakirkham ***@***.***> wrote:
Make sense. Is alright if I merge small PRs like this at my own discretion
then?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#40 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AASszDHbvHOs7h26I5ORYag1EQeK4VWzks5sy1IogaJpZM4QQwD7>
.
|
Great, thanks. 😄 |
Would it be possible to disable merging with a merge commit and/or make merge squash the default for this repo? |
Fine with me
…On Fri, Nov 3, 2017 at 2:57 PM, jakirkham ***@***.***> wrote:
Would it be possible to disable merging with a merge commit and/or make
merge squash the default for this repo?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#40 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AASszCwqvK6C7APLh50IMWrr74uiF4Zgks5sy2ItgaJpZM4QQwD7>
.
|
So I lack the permissions to do this myself. Would you be able to change that or could I have permissions to do that? |
I've disabled the merge-commit option. I'm not sure how to fine-tune permissions like this. There's always the option to give everyone admin privileges, which might be reasonable. That would probably require a larger conversation including more of the current core contributors. |
Thanks for doing that. No worries. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure the LICENSE and README are included. Also ensure any compiled Python code is not included.