Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: grouping transactions by date #655

Merged
merged 10 commits into from
Jun 4, 2024

Conversation

Syn-McJ
Copy link
Member

@Syn-McJ Syn-McJ commented Jun 4, 2024

Issue being fixed or feature implemented

We want to group transactions on the Home screen into sections by date.

What was done?

  • Transaction list on HomeView is refactored to SwiftUI
  • Groping into sections by date is implemented
  • Improved MenuItem component to use as TransactionPreview
  • Fixed icons
  • Related refactoring in TransactionDataSource

How Has This Been Tested?

Breaking Changes

UITableView is refactored into SwiftUI LazyVStack

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@Syn-McJ Syn-McJ requested a review from pankcuf June 4, 2024 09:18
@Syn-McJ Syn-McJ self-assigned this Jun 4, 2024
Copy link
Collaborator

@pankcuf pankcuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Syn-McJ Syn-McJ merged commit b2d1b24 into dashpay:develop Jun 4, 2024
1 check passed
@Syn-McJ Syn-McJ deleted the feat/tx-grouping branch June 4, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants