Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: some crashes #654

Merged
merged 2 commits into from
May 28, 2024
Merged

fix: some crashes #654

merged 2 commits into from
May 28, 2024

Conversation

Syn-McJ
Copy link
Member

@Syn-McJ Syn-McJ commented May 23, 2024

Issue being fixed or feature implemented

On a fresh install, there are a couple of crashes:

  • Missing cached rates can cause a crash because of stale rate changes.
  • The onboarding screen can crash because of HomeViewController refactoring.

What was done?

Crashes fixed

How Has This Been Tested?

QA

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@Syn-McJ Syn-McJ requested a review from pankcuf May 23, 2024 08:07
@Syn-McJ Syn-McJ self-assigned this May 23, 2024
pankcuf
pankcuf approved these changes May 28, 2024
View reviewed changes
Copy link
Collaborator

@pankcuf pankcuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Syn-McJ Syn-McJ merged commit 49358e3 into dashpay:develop May 28, 2024
1 check passed
@Syn-McJ Syn-McJ deleted the fix/rate-crashes branch May 28, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pankcuf pankcuf pankcuf approved these changes

Assignees

@Syn-McJ Syn-McJ

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Syn-McJ @pankcuf