Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support CoinATMRadar data #558

Merged
merged 2 commits into from
Jun 30, 2023
Merged

feat: Support CoinATMRadar data #558

merged 2 commits into from
Jun 30, 2023

Conversation

tikhop
Copy link
Collaborator

@tikhop tikhop commented Jun 29, 2023

Issue being fixed or feature implemented

Support CoinATMRadar data

What was done?

  • Expect Null from sqlite for logo column
  • Change generic icon for atms without logo

How Has This Been Tested?

QA/Manually

Breaking Changes

N/A

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@tikhop tikhop requested a review from pankcuf June 29, 2023 17:15
@tikhop tikhop marked this pull request as ready for review June 29, 2023 17:15
@pankcuf pankcuf merged commit 685c307 into develop Jun 30, 2023
1 check passed
@tikhop tikhop deleted the feature/support-coinatmradar branch July 3, 2023 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pankcuf pankcuf Awaiting requested review from pankcuf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tikhop @pankcuf