fix: remove mn_rr fork usage from functional test of EHF #6270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UdjinM6
reviewed
Sep 13, 2024
test/functional/feature_mnehf.py
Outdated
| self.log.info("activate MN_RR also by enabling spork 24") | ||
| assert_equal(get_bip9_details(node, 'mn_rr')['status'], 'defined') | ||
| self.log.info("Test spork 24 (EHF)") | ||
| assert_equal(get_bip9_details(node, 'testdummy')['status'], 'defined') |
There was a problem hiding this comment.
Suggested change
| assert_equal(get_bip9_details(node, 'testdummy')['status'], 'defined') | |
| self.check_fork('defined') |
should also drop
self.log.info(f"bip9: {get_bip9_details(node, 'mn_rr')}")
assert_equal(get_bip9_details(node, 'mn_rr')['status'], 'active')
at the end of the test
knst
changed the title
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Using mn_rr in feature_mnehf.py is a blocker for burying mn_rr fork.
What was done?
Removed useless conditions, uses testdummy fork instead mn_rr in ehf functional test.
How Has This Been Tested?
Run it
test/functional/feature_mnehf.pyBreaking Changes
N/A
Checklist: