Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use PR's HEAD in guix workflow #5416

Merged
merged 1 commit into from
Jun 7, 2023

Conversation

UdjinM6
Copy link

@UdjinM6 UdjinM6 commented Jun 6, 2023

Issue being fixed or feature implemented

Our guix workflow creates a merge commit instead of using HEAD from a PR itself which is why commit hash is different. That's exactly what is described in actions/checkout#27 imo.

related: #5355 (comment)

What was done?

adjust guix workflow

How Has This Been Tested?

see this PR results: the HEAD looks correct now
this PR: https://github.com/dashpay/dash/actions/runs/5191152453/jobs/9358590629?pr=5416#step:2:482
#5355: https://github.com/dashpay/dash/actions/runs/5187698039/jobs/9350381761?pr=5355#step:2:489

Breaking Changes

n/a hopefully

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation
  • I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

@UdjinM6 UdjinM6 marked this pull request as ready for review June 6, 2023 16:49
@UdjinM6 UdjinM6 added this to the 20 milestone Jun 6, 2023
Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK for squash merge

Copy link
Collaborator

@kwvg kwvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@UdjinM6
Copy link
Author

UdjinM6 commented Jun 7, 2023

$ sha256sum guix-build-$(git rev-parse --short=12 HEAD)/distsrc-*/src/dashd{,.exe}
91664fe0a7bf0d8b232888d7f7b7ceaf3c2535f265e8aba195f10d92d03f1197  guix-build-508b8a4fd1c9/distsrc-508b8a4fd1c9-aarch64-linux-gnu/src/dashd
2e9f8435f12e7f5d9cb8cfda307fbc8201e3d65d725d4eb4a1f36cb890de8e43  guix-build-508b8a4fd1c9/distsrc-508b8a4fd1c9-arm-linux-gnueabihf/src/dashd
42231798b143ed36445818179b358560cf27832e5df57d7e5f85c67077367e86  guix-build-508b8a4fd1c9/distsrc-508b8a4fd1c9-riscv64-linux-gnu/src/dashd
df27321522055f9a7ce9f796f24b2ebbcc27b47c3c33d79a5a0d0ef5758d4ea6  guix-build-508b8a4fd1c9/distsrc-508b8a4fd1c9-x86_64-apple-darwin18/src/dashd
f5fe1876fd08d735f803be457a59f746b64c6fb4aaedd9b3f3f668734a3a9a1e  guix-build-508b8a4fd1c9/distsrc-508b8a4fd1c9-x86_64-linux-gnu/src/dashd
1bd814ee1d3d387b8a5311e375199bcbac5fdc356e72918257da85b247ed8af3  guix-build-508b8a4fd1c9/distsrc-508b8a4fd1c9-x86_64-w64-mingw32/src/dashd.exe
$ sha256sum guix-build-$(git rev-parse --short=12 HEAD)/distsrc-*/src/qt/dash-qt{,.exe}
f4c3fd68a4bb3408ea1ae2928546ea0559ea5f99351769e16853e741b967b14e  guix-build-508b8a4fd1c9/distsrc-508b8a4fd1c9-aarch64-linux-gnu/src/qt/dash-qt
5b70dbaff89178a4f0394864934616676a6af1bcaa97c6772fedcf3de7331d89  guix-build-508b8a4fd1c9/distsrc-508b8a4fd1c9-arm-linux-gnueabihf/src/qt/dash-qt
c91d312d59cbed290af5ec5a3424c16c4d13460e7f1eb16eaa7498e095645a55  guix-build-508b8a4fd1c9/distsrc-508b8a4fd1c9-riscv64-linux-gnu/src/qt/dash-qt
997960274c041602fc6a467bcd1799e2adde09aff783dd2d77b61c486c8c20b3  guix-build-508b8a4fd1c9/distsrc-508b8a4fd1c9-x86_64-apple-darwin18/src/qt/dash-qt
2c5d9e9c20e0375aecd44013629617007616c65897d0dbe1bd6ca2b2681ee5fc  guix-build-508b8a4fd1c9/distsrc-508b8a4fd1c9-x86_64-linux-gnu/src/qt/dash-qt
6bebed6b412e1b2ad5bf66e551e696623f5fc14e7423083635708e601887635b  guix-build-508b8a4fd1c9/distsrc-508b8a4fd1c9-x86_64-w64-mingw32/src/qt/dash-qt.exe
$ find guix-build-"$(git rev-parse --short=12 HEAD)"/output -type f | grep -v SHA256 | xargs sha256sum | sort -k 2
8fa1bdb642d58fe1a7758e75f3466af4377683e7fb1f89262c40473929db28d3  guix-build-508b8a4fd1c9/output/aarch64-linux-gnu/dashcore-508b8a4fd1c9-aarch64-linux-gnu-debug.tar.gz
2c83f0976511e5dabf8c899558b63789c9cc69a4ff1e4c13e87ad0edf2160d8c  guix-build-508b8a4fd1c9/output/aarch64-linux-gnu/dashcore-508b8a4fd1c9-aarch64-linux-gnu.tar.gz
41a12165bab2233d5211f2d92602f151c25ed1211f54ae3fbb55c8c7901baae8  guix-build-508b8a4fd1c9/output/arm-linux-gnueabihf/dashcore-508b8a4fd1c9-arm-linux-gnueabihf-debug.tar.gz
1e8bc3841c30d24cd5b65a24d3be2410c30648a2d15dcff284dc135114ba0b59  guix-build-508b8a4fd1c9/output/arm-linux-gnueabihf/dashcore-508b8a4fd1c9-arm-linux-gnueabihf.tar.gz
546570030b759f58dd1659c10453c4b41b9004915c109560f13d869b25ec4452  guix-build-508b8a4fd1c9/output/dist-archive/dashcore-508b8a4fd1c9.tar.gz
777f0f94d04462a459bdbfcea22aa8f425b03cde3f07ec14fb4cdd98b053600a  guix-build-508b8a4fd1c9/output/riscv64-linux-gnu/dashcore-508b8a4fd1c9-riscv64-linux-gnu-debug.tar.gz
2cfa95617e6ca8d190fdb0d17b003c7439f440db33d03971fe3df423b652e239  guix-build-508b8a4fd1c9/output/riscv64-linux-gnu/dashcore-508b8a4fd1c9-riscv64-linux-gnu.tar.gz
911bc02d0d64999171eb37f476603cdc4ccafc78dc789dadc04ca8d6a1edd172  guix-build-508b8a4fd1c9/output/x86_64-apple-darwin18/dashcore-508b8a4fd1c9-osx64.tar.gz
5c31c2036a82c4e9c40dad22117e2e4adae90028de7742d289d09687b40378fd  guix-build-508b8a4fd1c9/output/x86_64-apple-darwin18/dashcore-508b8a4fd1c9-osx-unsigned.dmg
f3d328c84e40f5ebd4d56d9a69c33d9c4e818bf15c06062f66d675ba29d98196  guix-build-508b8a4fd1c9/output/x86_64-apple-darwin18/dashcore-508b8a4fd1c9-osx-unsigned.tar.gz
37d84b394d633a959adcb75635976634294a2f22c54696284af21f3ca9ab776b  guix-build-508b8a4fd1c9/output/x86_64-linux-gnu/dashcore-508b8a4fd1c9-x86_64-linux-gnu-debug.tar.gz
60aeffa9392436f4f1507d5278ba4e08e9485f1943ac309a0129e2654738c90d  guix-build-508b8a4fd1c9/output/x86_64-linux-gnu/dashcore-508b8a4fd1c9-x86_64-linux-gnu.tar.gz
46f582dcdd81b33e916199ddc16e9fc806594775f74b6379f9764e87623f2668  guix-build-508b8a4fd1c9/output/x86_64-w64-mingw32/dashcore-508b8a4fd1c9-win64-debug.zip
024556e3d06d5d0b45ac7e7e59bff057a98ec3a05ed01907ae7f9c98a0e99171  guix-build-508b8a4fd1c9/output/x86_64-w64-mingw32/dashcore-508b8a4fd1c9-win64-setup-unsigned.exe
23bf98423b35ac17971947d11f3850b7d1a10a6e72b77ddcf0b14279253a92d5  guix-build-508b8a4fd1c9/output/x86_64-w64-mingw32/dashcore-508b8a4fd1c9-win64.zip
a14baf9e51bfc16a851bfff28be64b143b3f06d70d9fd4d865d2090b67ecbcde  guix-build-508b8a4fd1c9/output/x86_64-w64-mingw32/dashcore-508b8a4fd1c9-win-unsigned.tar.gz

@UdjinM6 UdjinM6 merged commit 49ca1aa into dashpay:develop Jun 7, 2023
@UdjinM6 UdjinM6 deleted the ci_guix_workflow_hash branch June 7, 2023 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants