feat: upgraded springboot to 3.3.1 and bumped up other dependencies #1044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o latest. docs: Updated read me files to use Java 17 as baseline Signed-off-by: amardeep2006 <amardeep2006@gmail.com>
|
@paulyuk @msfussell Please have a look at the PR once you get chance. I have tested the build via github action in my repo fork as well. |
|
@amardeep2006 - Thanks for this PR. Will take a look. @salaboy - Please also review this. |
salaboy
approved these changes
Jul 12, 2024
There was a problem hiding this comment.
This looks good to me, thanks a lot @amardeep2006 for these changes.
|
@msfussell looks good to me, I've approved this PR |
paulyuk
approved these changes
Jul 14, 2024
| - [Oracle JDK 11](https://www.oracle.com/technetwork/java/javase/downloads/index.html#JDK11) | ||
| - [OpenJDK 11](https://jdk.java.net/11/) | ||
| - Java JDK 17 (or greater): | ||
| - [Microsoft JDK 17](https://learn.microsoft.com/en-us/java/openjdk/download#openjdk-17) |
There was a problem hiding this comment.
I was surprised Java 21 LTS is not the most used, but looking at State of java reports, those agree Java 17 is correct for right now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: bumped up dependencies for Java Quickstarts , Springboot 2 is out of support so i have changes all the projects to use latest springboot 3 version available on the day of raising PR. I have tested all projects locally and github actions as well.
docs: Updated read me files to use Java 17 as baseline
Signed-off-by: amardeep2006 amardeep2006@gmail.com
Description
Please explain the changes you've made
Upgraded Java Quickstarts to latest versions of dependencies.
Issue reference
We strive to have all PRs being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
#1042
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: