-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
seth: non checksum addresses supported in ETH_FROM #796
Conversation
60f8f50
to
da7f49e
Compare
Fixes an issue in #771, where if `ETH_RPC_ACCOUNTS` was set, and `ETH_FROM` was not a checksummed address, the signing request would be incorrectly forwarded to the rpc node, even if `ETH_FROM` was present in a local keystore. The issue is fixed by using a case insensitive grep when checking if `ETH_FROM` is present in a local keystore.
da7f49e
to
d368154
Compare
@@ -49,10 +49,52 @@ dapp_testnet() { | |||
|
|||
# dynamic fee transaction (EIP-1559) | |||
seth send "$A_ADDR" "on()" --gas 0xffff --password /dev/null --from "$ACC" --keystore "$TMPDIR"/8545/keystore --prio-fee 2gwei --gas-price 10gwei | |||
|
|||
# clean up | |||
killall geth |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't you wanna do the same thing thats in the trap?
https://github.com/dapphub/dapptools/pull/796/files#diff-f18f8b69e1e1cfa0cc72e097dec217d074ca723df9a72f22f7c997e39ceb8100R6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Somehow this broke mktemp
in the subsequent tests. Not sure why. I redid the dapp testnet
stuff in #797 anyway.
|
||
dapp testnet --dir "$TMPDIR" & | ||
# give it a few secs to start up | ||
sleep 180 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, you can make this like 3-10 seconds and it still works well enough. Should make CI faster
Description
Fixes an issue in #771, where if
ETH_RPC_ACCOUNTS
was set, andETH_FROM
was not a checksummed address, the signing request would be incorrectly forwarded to the rpc node, even ifETH_FROM
was present in a local keystore.The issue is fixed by using a case insensitive grep when checking if
ETH_FROM
is present in a local keystore.Checklist