Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

seth: add Optimistic Ethereum and Arbitrum Support #781

Merged
merged 5 commits into from
Sep 11, 2021
Merged

seth: add Optimistic Ethereum and Arbitrum Support #781

merged 5 commits into from
Sep 11, 2021

Conversation

rajivpo
Copy link
Contributor

@rajivpo rajivpo commented Sep 10, 2021

provide optimistic ethereum (mainnet and kovan) and arbitrum (mainnet) support for seth and update relevant documentation

How this has been tested

  • set ETH_RPC_URL to an to the relevant infura endpoint
  • check thatseth chain returns the correct chain
  • seth chain-id returns 10 (https://chainid.link/?network=optimism for verification)
  • seth block-number returned the latest block (check relevant explorer to confirm)
  • seth block 0 returns the same info as making the infura call to eth_getBlockByNumber with params ["0x0", true]

Could also add arbitrum rinkeby support, but i'm not aware of whether there is an etherscan api compatible explorer for it.

@rajivpo rajivpo changed the title seth: Add Optimism support seth: add Optimism support Sep 10, 2021
@transmissions11
Copy link
Contributor

Can we get OE Kovan support too 🙏🙏

@rajivpo rajivpo changed the title seth: add Optimism support seth: add Optimistic Ethereum support Sep 10, 2021
@rajivpo
Copy link
Contributor Author

rajivpo commented Sep 10, 2021

Can we get OE Kovan support too 🙏🙏

anything else you would wanna see as part of this PR?

@transmissions11
Copy link
Contributor

transmissions11 commented Sep 10, 2021

anything else you would wanna see as part of this PR?

Arbitrum? xD

@rajivpo rajivpo changed the title seth: add Optimistic Ethereum support seth: add Optimistic Ethereum and Arbitrum Support Sep 10, 2021
@transmissions11
Copy link
Contributor

There's an arbitrum testnet too right?

@rajivpo
Copy link
Contributor Author

rajivpo commented Sep 10, 2021

There's an arbitrum testnet too right?

Yeah I can add Arbitrum rinkeby but not sure what the corresponding etherscan for that is.

@transmissions11
Copy link
Contributor

not sure what the corresponding etherscan for that is.

Oo yeah idk either maybe save for a future PR 😅

@MrChico MrChico merged commit adcc076 into dapphub:master Sep 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants