Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick fix for README updater #942

Merged
merged 5 commits into from
Dec 8, 2023
Merged

Conversation

molangning
Copy link
Contributor

There is an edge case where if the size gets converted to standard form is three digits(for example 969) there will be a . at the end of the string.
This patch fixed this issue by using the decimal library to accurately round and adds some improvements such as improved logging in github actions

@g0tmi1k g0tmi1k merged commit 640cfe2 into danielmiessler:master Dec 8, 2023
@g0tmi1k g0tmi1k self-assigned this Dec 8, 2023
@g0tmi1k g0tmi1k added the bug Bug label Dec 8, 2023
@g0tmi1k
Copy link
Collaborator

g0tmi1k commented Dec 8, 2023

Thanks for the save!

@molangning
Copy link
Contributor Author

You are welcome!

@molangning molangning deleted the patch-2 branch February 14, 2024 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants