Add prefixed enums in addition to pretty ones

[snikch]

Summary

The representation of enums in JSON should not have the prefix removed as implemented in #187. This PR provides one option for fixing JSON representation of enums.

From the linked C# docs in #174 (referenced in the above PR):

This name transformation does not affect the text used within the JSON representation of messages.

This fix is a somewhat naive approach and I'm open to alternatives. It simply adds in the original enum field in addition to the stripped field.

I looked at an alternative where the JSON would render based on a full_name property, however the scope of this started to grow so I figured I'd push up the naive change and start a discussion.

One option would be to replace the value with a tuple of some sort, however it's possible this would create issues with comparisons.

class ArithmeticOperator(betterproto.Enum):
    """
    A "C" like enum with the enum name prefixed onto members, these should be stripped
    """

    NONE = (0, 'ARITHMETIC_OPERATOR_NONE')
    PLUS = (1, 'ARITHMETIC_OPERATOR_PLUS')
    MINUS = (2, 'ARITHMETIC_OPERATOR_MINUS')
    _0_PREFIXED = (3, 'ARITHMETIC_OPERATOR_0_PREFIXED')

Another option I thought of was to add an option as to whether to remove the prefix, however I personally would like to have the best of both words - nice python enums along with correct JSON encoding / decoding.

Thoughts?

Checklist

• If code changes were made then they have been tested.
  • I have updated the documentation to reflect the changes.
• This PR fixes an issue.

[Gobot1234]

The full name version seems desirable. Could conditionally add the dict based on if it's necessary. The other options in my mind don't play nicely with type checking. See https://github.com/Gobot1234/steam.py/blob/main/steam/enums.py#L635 for how I've done it in my own projects might be useful

[snikch]

@Gobot1234 I went down a rabbit hole with custom enum types but ended up doing as you suggested. Updated!

[Gobot1234]

Please can you also run poe fmt

[Gobot1234]

Suggested change

	def name(enum_class, value):
	obj = enum_class(value)
	if hasattr(obj.__class__, 'full_name') and isinstance(obj.__class__.full_name, property):
	return obj.full_name
	return obj.name
	def name(enum_class, value):
	obj = enum_class(value)
	if hasattr(obj.__class__, 'full_name') and isinstance(obj.__class__.full_name, property):
	return obj.full_name
	return obj.name

This should probably go in utils or enum.py

[Gobot1234]

Suggested change

	def obj(enum_class, value):
	return enum_class.from_full_name(value) if hasattr(enum_class, 'from_full_name') else enum_class.from_string(value)
	def obj(enum_class, value):
	return enum_class.from_full_name(value) if hasattr(enum_class, 'from_full_name') else enum_class.from_string(value)

Same as previous here